commit 00e8562f26211a13114890f8e036ede25d205a7b
author Goktug Gokdogan <goktug@google.com> Mon Aug 12 11:54:52 2013 -0700
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri Aug 30 23:50:59 2013 +0000
tree b4f3945a02b3244272813a062d1c3fe34043a143
parent 98694475fe750212b3eb9b982e81feb116732c59

Adds SuppressWarnings for self-referential collection operations.

Self-referential collection operations (c.addAll(c), c.removeAll(c), c.retainAll(c),
and c.containsAll(c)). Such cases are either no-ops, undefined behavior, or
unnecessarily complicated, and often reveal bugs.
In GWT's case, we are testing the collection itself so it makes sense. The patch
suppresses the warning to make Google internal static analysis tools happy with GWT.

Change-Id: Ie8679f1eb9790441e0da9f81e2329386bdc7d7e2

dev/core/test/org/apache/commons/collections/collection/AbstractTestCollection.java

diff --git a/dev/core/test/org/apache/commons/collections/collection/AbstractTestCollection.java b/dev/core/test/org/apache/commons/collections/collection/AbstractTestCollection.java
index a3591db..1d45be0 100644
--- a/dev/core/test/org/apache/commons/collections/collection/AbstractTestCollection.java
+++ b/dev/core/test/org/apache/commons/collections/collection/AbstractTestCollection.java
@@ -691,6 +691,7 @@
     /**
      *  Tests {@link Collection#containsAll(Collection)}.
      */
+    @SuppressWarnings("ModifyingCollectionWithItself")
     public void testCollectionContainsAll() {
         resetEmpty();
         Collection col = new HashSet();

user/test/com/google/gwt/emultest/java/util/TreeSetTest.java

diff --git a/user/test/com/google/gwt/emultest/java/util/TreeSetTest.java b/user/test/com/google/gwt/emultest/java/util/TreeSetTest.java
index 29a84e7..cc020fc 100644
--- a/user/test/com/google/gwt/emultest/java/util/TreeSetTest.java
+++ b/user/test/com/google/gwt/emultest/java/util/TreeSetTest.java
@@ -316,6 +316,7 @@
    * 
    * @see java.util.Set#addAll(Map)
    */
+  @SuppressWarnings("ModifyingCollectionWithItself")
   public void testAddAll_self() {
     // The _throwsUnsupportedOperationException version of this test will
     // verify that the method is not supported.

user/test/org/apache/commons/collections/TestCollection.java

diff --git a/user/test/org/apache/commons/collections/TestCollection.java b/user/test/org/apache/commons/collections/TestCollection.java
index 66d187f..1af31e9 100644
--- a/user/test/org/apache/commons/collections/TestCollection.java
+++ b/user/test/org/apache/commons/collections/TestCollection.java
@@ -565,6 +565,7 @@
     /**
      *  Tests {@link Collection#containsAll(Collection)}.
      */
+    @SuppressWarnings("ModifyingCollectionWithItself")
     public void testCollectionContainsAll() {
         resetEmpty();
         Collection col = new HashSet();