Add system property to optionally strip comments generated in resource bundles used for debugging purposes. This causes build instabilities in some cases, where the source code doesn't change, but the comment does.
Review by: johnlenz@google.com
git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@10831 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/user/src/com/google/gwt/resources/ext/AbstractResourceGenerator.java b/user/src/com/google/gwt/resources/ext/AbstractResourceGenerator.java
index 5410a30..d5d69e7 100644
--- a/user/src/com/google/gwt/resources/ext/AbstractResourceGenerator.java
+++ b/user/src/com/google/gwt/resources/ext/AbstractResourceGenerator.java
@@ -25,6 +25,8 @@
* @see com.google.gwt.resources.ext.ResourceGeneratorUtil
*/
public abstract class AbstractResourceGenerator implements ResourceGenerator {
+ protected static final boolean STRIP_COMMENTS = System.getProperty("gwt.resourceBundle.stripComments") != null;
+
public abstract String createAssignment(TreeLogger logger,
ResourceContext context, JMethod method) throws UnableToCompleteException;
diff --git a/user/src/com/google/gwt/resources/rg/DataResourceGenerator.java b/user/src/com/google/gwt/resources/rg/DataResourceGenerator.java
index c5392d7..9f0f140 100644
--- a/user/src/com/google/gwt/resources/rg/DataResourceGenerator.java
+++ b/user/src/com/google/gwt/resources/rg/DataResourceGenerator.java
@@ -60,7 +60,9 @@
SourceWriter sw = new StringSourceWriter();
// Convenience when examining the generated code.
- sw.println("// " + resource.toExternalForm());
+ if (!AbstractResourceGenerator.STRIP_COMMENTS) {
+ sw.println("// " + resource.toExternalForm());
+ }
sw.println("new " + DataResourcePrototype.class.getName() + "(");
sw.indent();
sw.println('"' + method.getName() + "\",");
diff --git a/user/src/com/google/gwt/resources/rg/TextResourceGenerator.java b/user/src/com/google/gwt/resources/rg/TextResourceGenerator.java
index 95c1d4e..2743814 100644
--- a/user/src/com/google/gwt/resources/rg/TextResourceGenerator.java
+++ b/user/src/com/google/gwt/resources/rg/TextResourceGenerator.java
@@ -61,8 +61,10 @@
sw.println("new " + TextResource.class.getName() + "() {");
sw.indent();
- // Convenience when examining the generated code.
- sw.println("// " + resource.toExternalForm());
+ if (!AbstractResourceGenerator.STRIP_COMMENTS) {
+ // Convenience when examining the generated code.
+ sw.println("// " + resource.toExternalForm());
+ }
sw.println("public String getText() {");
sw.indent();
