commit 09b00704f42c55e07e6a02b4081806c946ab479c
author jlabanca@google.com <jlabanca@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Wed Oct 28 18:45:03 2009 +0000
committer jlabanca@google.com <jlabanca@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Wed Oct 28 18:45:03 2009 +0000
tree 6afb2806054b058384a486c8d2b9b84e01e2429e
parent 49c413c770632bffdfa256f42db77e05d8a2369d

Fixes a bug where JavaToJavaScriptCompiler assumes PropertyOracle#getSelectionProperty will return null if a property is not defined, but it actually throws a BadPropertyException.

Patch by: jlabanca
Review by: spoon



git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@6515 8db76d5a-ed1c-0410-87a9-c151d255dfc7

dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java

diff --git a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
index 93c4a11..58ee760 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
@@ -15,6 +15,7 @@
  */
 package com.google.gwt.dev.jjs;
 
+import com.google.gwt.core.ext.BadPropertyValueException;
 import com.google.gwt.core.ext.PropertyOracle;
 import com.google.gwt.core.ext.SelectionProperty;
 import com.google.gwt.core.ext.TreeLogger;
@@ -334,8 +335,9 @@
       // blocks, this class now handles non-top level blocks only.
       SelectionProperty userAgentProperty = null;
       for (PropertyOracle oracle : propertyOracles) {
-        userAgentProperty = oracle.getSelectionProperty(logger, "user.agent");
-        if (userAgentProperty != null) {
+        try {
+          userAgentProperty = oracle.getSelectionProperty(logger, "user.agent");
+        } catch (BadPropertyValueException e) {
           break;
         }
       }