)]}'
{
  "commit": "0c5c2ef4adbeaf0d28d2b32e0f5c2676b2f669d4",
  "tree": "08fa6123de545f505181adbaeb9027aa0b6cfec9",
  "parents": [
    "e20feb2b74659fe08d18285e88e203852900a58e"
  ],
  "author": {
    "name": "jasonparekh@google.com",
    "email": "jasonparekh@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7",
    "time": "Fri Apr 16 13:41:24 2010 +0000"
  },
  "committer": {
    "name": "jasonparekh@google.com",
    "email": "jasonparekh@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7",
    "time": "Fri Apr 16 13:41:24 2010 +0000"
  },
  "message": "Fixes a couple of issues with the RemoteUI and GPE DevMode view interaction.  The problem is GPE shows the startup URLs in the DevMode view _before_ the modules were fully loaded.  The root issue is GPE does not receive the moduleLoadComplete message.  When we went to push this message to GPE, we discovered the protobuf is too restricted:  the RequestType cannot have new values and maintain backwards compatibility.  This is because requestType is a \"required\" field, so older GPE versions will not understand the new moduleLoadComplete message and thus have an undefined requestType, at which point an error is thrown because requestType is required.\n\nFor the protobuf issue, this patch changes the \"required\" to \"optional\".\nWe will still have compatibility issues with GWT or GPE versions\nearlier than this patch, but this allows for future versions to have new\nvalues added to the enums.  It is up to the application layer to check\nthe validity of the message.\n\nFor the GPE startup URL issue, it will show a \"Loading\" state as soon\nas DevMode is launched.  Then, GWT will send the startup URLs in\nmoduleLoadComplete.  Upon receiving these, GPE will display them.  The\nuser will not see startup URLs before they are ready.\n\nReview at http://gwt-code-reviews.appspot.com/323801\n\nReview by: rdayal@google.com\n\ngit-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@7931 8db76d5a-ed1c-0410-87a9-c151d255dfc7\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "36e1a160ef61bdb3ba3d285e0f389cabe09e6abe",
      "old_mode": 33188,
      "old_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/DevModeServiceRequestProcessor.java",
      "new_id": "b1f0378e92e869dbc9b05139513eaf5ad56ee242",
      "new_mode": 33188,
      "new_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/DevModeServiceRequestProcessor.java"
    },
    {
      "type": "modify",
      "old_id": "f6ef21bb9f0712e8967acd843d7c88047abc79d8",
      "old_mode": 33188,
      "old_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/MessageTransport.java",
      "new_id": "2b608083cf94d0c32b460d46077345dc3d2ae820",
      "new_mode": 33188,
      "new_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/MessageTransport.java"
    },
    {
      "type": "modify",
      "old_id": "d782bfd9e7e3fe4b75d1ed0bf940f1270ed4ad30",
      "old_mode": 33188,
      "old_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteMessageProto.java",
      "new_id": "d3fd08e3b8b155c64bb029702b9fb23979a24524",
      "new_mode": 33188,
      "new_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteMessageProto.java"
    },
    {
      "type": "modify",
      "old_id": "3c1a94373654e313a7f15fc2c548524951bfc4e4",
      "old_mode": 33188,
      "old_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java",
      "new_id": "450319cc729b5bea3cba5ddf7e0d3c9cb641987f",
      "new_mode": 33188,
      "new_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java"
    },
    {
      "type": "modify",
      "old_id": "62c8b00981a1ccbe731de15c3045d6a50fdc2d37",
      "old_mode": 33188,
      "old_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/ViewerServiceClient.java",
      "new_id": "e04a3ff32e638820e3e24309c688d8529c9a18ad",
      "new_mode": 33188,
      "new_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/ViewerServiceClient.java"
    },
    {
      "type": "modify",
      "old_id": "71e243beb6fa783191923ae53b280cb2d4071724",
      "old_mode": 33188,
      "old_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/remotemessage.proto",
      "new_id": "31ba92ba1f119e1f35b6035122df44c253a93631",
      "new_mode": 33188,
      "new_path": "dev/core/src/com/google/gwt/dev/shell/remoteui/remotemessage.proto"
    }
  ]
}