commit 11c3e1bcca091a8eb9aae41e178a30e54d4c7ed5
author Goktug Gokdogan <goktug@google.com> Fri Jun 03 19:22:34 2016 -0700
committer Goktug Gokdogan <goktug@google.com> Mon Jun 06 22:02:55 2016 +0000
tree 68278d8d3396d9c4e0b7204f58be6d67846358d6
parent 705e748494aaaf0d9d3d712f185009a41fb5c5b7

Add missing null check String.toString

Change-Id: I1c95cf6978c172b3eebf828f22e4076b8b479e4a

user/super/com/google/gwt/emul/java/lang/String.java

diff --git a/user/super/com/google/gwt/emul/java/lang/String.java b/user/super/com/google/gwt/emul/java/lang/String.java
index cfe2586..6421e68 100644
--- a/user/super/com/google/gwt/emul/java/lang/String.java
+++ b/user/super/com/google/gwt/emul/java/lang/String.java
@@ -17,6 +17,7 @@
 package java.lang;
 
 import static javaemul.internal.InternalPreconditions.checkCriticalStringBounds;
+import static javaemul.internal.InternalPreconditions.checkNotNull;
 
 import java.io.Serializable;
 import java.io.UnsupportedEncodingException;
@@ -750,7 +751,7 @@
      * Magic: this method is only used during compiler optimizations; the generated JS will instead alias
      * this method to the native String.prototype.toString() function.
      */
-    return this;
+    return checkNotNull(this);
   }
 
   public String trim() {

user/super/com/google/gwt/emul/java/util/StringJoiner.java

diff --git a/user/super/com/google/gwt/emul/java/util/StringJoiner.java b/user/super/com/google/gwt/emul/java/util/StringJoiner.java
index 6071c03..c93b3b4 100644
--- a/user/super/com/google/gwt/emul/java/util/StringJoiner.java
+++ b/user/super/com/google/gwt/emul/java/util/StringJoiner.java
@@ -35,11 +35,6 @@
   }
 
   public StringJoiner(CharSequence delimiter, CharSequence prefix, CharSequence suffix) {
-    // TODO: null.toString() does not throw exception
-    checkCriticalNotNull(delimiter, "delimiter");
-    checkCriticalNotNull(prefix, "prefix");
-    checkCriticalNotNull(suffix, "suffix");
-
     this.delimiter = delimiter.toString();
     this.prefix = prefix.toString();
     this.suffix = suffix.toString();
@@ -96,4 +91,4 @@
       builder.append(delimiter);
     }
   }
-}
\ No newline at end of file
+}