| commit | 297d7757b08f37969e8e7df5a32f7e9a48b14d6d | [log] [tgz] |
|---|---|---|
| author | Daniel Kurka <dankurka@google.com> | Fri Dec 04 16:37:57 2015 +0100 |
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | Mon Dec 07 09:51:16 2015 +0000 |
| tree | 403307ad322b361f4d45a25375502151d07ea5b2 | |
| parent | 890af9157ae03365f8d38281fda2e1467bf6b9ba [diff] |
Fix instanceof for primitives & string. Without this change a native type with name="Object" would return true in an instance of tests against a js boolean, number or String. Change-Id: I91e7f32f0d2fd76e842d6c1618160a63e0837aa0
diff --git a/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java b/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java index 993ffc1..355616f 100644 --- a/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java +++ b/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Cast.java
@@ -241,7 +241,7 @@ if (jsTypeStr == "Object") { // TODO(rluble): Handle this case in the compiler side. - return true; + return (typeof obj) == "object"; } else if (jsTypeStr == "Array" ) { // TODO(rluble): remove array special handling once // instanceOf can be customized for native classes.