Fixed checkstyle violations.
git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@2372 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/dev/core/src/com/google/gwt/dev/jdt/LongFromJSNIChecker.java b/dev/core/src/com/google/gwt/dev/jdt/LongFromJSNIChecker.java
index 158c65a..d9a424a 100644
--- a/dev/core/src/com/google/gwt/dev/jdt/LongFromJSNIChecker.java
+++ b/dev/core/src/com/google/gwt/dev/jdt/LongFromJSNIChecker.java
@@ -28,7 +28,6 @@
import org.eclipse.jdt.internal.compiler.ast.MethodDeclaration;
import org.eclipse.jdt.internal.compiler.ast.TypeReference;
import org.eclipse.jdt.internal.compiler.classfmt.ClassFileConstants;
-import org.eclipse.jdt.internal.compiler.lookup.ArrayBinding;
import org.eclipse.jdt.internal.compiler.lookup.BaseTypeBinding;
import org.eclipse.jdt.internal.compiler.lookup.ClassScope;
import org.eclipse.jdt.internal.compiler.lookup.FieldBinding;
diff --git a/user/src/com/google/gwt/dom/client/BaseElement.java b/user/src/com/google/gwt/dom/client/BaseElement.java
index 5863ca6..2084f95 100644
--- a/user/src/com/google/gwt/dom/client/BaseElement.java
+++ b/user/src/com/google/gwt/dom/client/BaseElement.java
@@ -20,7 +20,7 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/links.html#edef-BASE
*/
-public class BaseElement extends Element{
+public class BaseElement extends Element {
/**
* Assert that the given {@link Element} is compatible with this class and
@@ -45,6 +45,15 @@
}-*/;
/**
+ * The default target frame.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/present/frames.html#adef-target
+ */
+ public final native String getTarget() /*-{
+ return this.target;
+ }-*/;
+
+ /**
* The base URI See the href attribute definition in HTML
* 4.01.
*
@@ -59,15 +68,6 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/present/frames.html#adef-target
*/
- public final native String getTarget() /*-{
- return this.target;
- }-*/;
-
- /**
- * The default target frame.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/present/frames.html#adef-target
- */
public final native void setTarget(String target) /*-{
this.target = target;
}-*/;
diff --git a/user/src/com/google/gwt/dom/client/ButtonElement.java b/user/src/com/google/gwt/dom/client/ButtonElement.java
index 0d6608c..f29f2da 100644
--- a/user/src/com/google/gwt/dom/client/ButtonElement.java
+++ b/user/src/com/google/gwt/dom/client/ButtonElement.java
@@ -42,14 +42,6 @@
}-*/;
/**
- * Returns the FORM element containing this control. Returns null if this
- * control is not within the context of a form.
- */
- public final native FormElement getForm() /*-{
- return this.form;
- }-*/;
-
- /**
* A single character access key to give access to the form control.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-accesskey
@@ -59,15 +51,6 @@
}-*/;
/**
- * A single character access key to give access to the form control.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-accesskey
- */
- public final native void setAccessKey(String accessKey) /*-{
- this.accessKey = accessKey;
- }-*/;
-
- /**
* The control is unavailable in this context.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled
@@ -77,12 +60,11 @@
}-*/;
/**
- * The control is unavailable in this context.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled
+ * Returns the FORM element containing this control. Returns null if this
+ * control is not within the context of a form.
*/
- public final native void setDisabled(String disabled) /*-{
- this.disabled = disabled;
+ public final native FormElement getForm() /*-{
+ return this.form;
}-*/;
/**
@@ -95,15 +77,6 @@
}-*/;
/**
- * Form control or object name when submitted with a form.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-name-BUTTON
- */
- public final native void setName(String name) /*-{
- this.name = name;
- }-*/;
-
- /**
* Index that represents the element's position in the tabbing order.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-tabindex
@@ -113,15 +86,6 @@
}-*/;
/**
- * Index that represents the element's position in the tabbing order.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-tabindex
- */
- public final native void setTabIndex(int tabIndex) /*-{
- this.tabIndex = tabIndex;
- }-*/;
-
- /**
* The type of button (all lower case).
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-type-BUTTON
@@ -140,6 +104,42 @@
}-*/;
/**
+ * A single character access key to give access to the form control.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-accesskey
+ */
+ public final native void setAccessKey(String accessKey) /*-{
+ this.accessKey = accessKey;
+ }-*/;
+
+ /**
+ * The control is unavailable in this context.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled
+ */
+ public final native void setDisabled(String disabled) /*-{
+ this.disabled = disabled;
+ }-*/;
+
+ /**
+ * Form control or object name when submitted with a form.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-name-BUTTON
+ */
+ public final native void setName(String name) /*-{
+ this.name = name;
+ }-*/;
+
+ /**
+ * Index that represents the element's position in the tabbing order.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-tabindex
+ */
+ public final native void setTabIndex(int tabIndex) /*-{
+ this.tabIndex = tabIndex;
+ }-*/;
+
+ /**
* The current form control value.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-value-BUTTON
diff --git a/user/src/com/google/gwt/dom/client/DOMImpl.java b/user/src/com/google/gwt/dom/client/DOMImpl.java
index 40964fc..19ab00c 100644
--- a/user/src/com/google/gwt/dom/client/DOMImpl.java
+++ b/user/src/com/google/gwt/dom/client/DOMImpl.java
@@ -71,6 +71,13 @@
return top;
}-*/;
+ public native Element getFirstChildElement(Element elem) /*-{
+ var child = elem.firstChild;
+ while (child && child.nodeType != 1)
+ child = child.nextSibling;
+ return child || null;
+ }-*/;
+
public native String getInnerHTML(Element elem) /*-{
var ret = elem.innerHTML;
return (ret == null) ? null : ret;
@@ -96,13 +103,6 @@
return parseInt(elem.style[attr]) || 0;
}-*/;
- public native Element getFirstChildElement(Element elem) /*-{
- var child = elem.firstChild;
- while (child && child.nodeType != 1)
- child = child.nextSibling;
- return child || null;
- }-*/;
-
public native Element getNextSiblingElement(Element elem) /*-{
var sib = elem.nextSibling;
while (sib && sib.nodeType != 1)
@@ -171,6 +171,11 @@
}
}-*/;
+ public native void selectAdd(SelectElement select, OptionElement option,
+ OptionElement before) /*-{
+ select.add(option, before);
+ }-*/;
+
public native int selectGetLength(SelectElement select) /*-{
return select.options.length;
}-*/;
@@ -179,11 +184,6 @@
return select.options;
}-*/;
- public native void selectAdd(SelectElement select, OptionElement option,
- OptionElement before) /*-{
- select.add(option, before);
- }-*/;
-
public native void selectRemoveOption(SelectElement select, int index) /*-{
select.remove(index);
}-*/;
diff --git a/user/src/com/google/gwt/dom/client/Document.java b/user/src/com/google/gwt/dom/client/Document.java
index d5fde31..148c236 100644
--- a/user/src/com/google/gwt/dom/client/Document.java
+++ b/user/src/com/google/gwt/dom/client/Document.java
@@ -305,11 +305,11 @@
return this.URL;
}-*/;
- public final native void setTitle(String title) /*-{
- this.title = title;
- }-*/;
-
public final native void importNode(Node node, boolean deep) /*-{
this.importNode(node, deep);
}-*/;
+
+ public final native void setTitle(String title) /*-{
+ this.title = title;
+ }-*/;
}
diff --git a/user/src/com/google/gwt/dom/client/Element.java b/user/src/com/google/gwt/dom/client/Element.java
index ed76351..bd41b03 100644
--- a/user/src/com/google/gwt/dom/client/Element.java
+++ b/user/src/com/google/gwt/dom/client/Element.java
@@ -15,7 +15,6 @@
*/
package com.google.gwt.dom.client;
-import com.google.gwt.core.client.JavaScriptObject;
/**
* All HTML element interfaces derive from this class.
diff --git a/user/src/com/google/gwt/dom/client/FormElement.java b/user/src/com/google/gwt/dom/client/FormElement.java
index 00ba146..eb97743 100644
--- a/user/src/com/google/gwt/dom/client/FormElement.java
+++ b/user/src/com/google/gwt/dom/client/FormElement.java
@@ -30,20 +30,13 @@
*/
public static FormElement as(Element elem) {
assert elem.getTagName().equalsIgnoreCase("form");
- return (FormElement)elem;
+ return (FormElement) elem;
}
protected FormElement() {
}
/**
- * Returns a collection of all form control elements in the form.
- */
- public final native NodeCollection<Element> getElements() /*-{
- return this.elements;
- }-*/;
-
- /**
* List of character sets supported by the server.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-accept-charset
@@ -62,6 +55,13 @@
}-*/;
/**
+ * Returns a collection of all form control elements in the form.
+ */
+ public final native NodeCollection<Element> getElements() /*-{
+ return this.elements;
+ }-*/;
+
+ /**
* The content type of the submitted form, generally
* "application/x-www-form-urlencoded".
*
diff --git a/user/src/com/google/gwt/dom/client/InputElement.java b/user/src/com/google/gwt/dom/client/InputElement.java
index 9a27a0a..a23a647 100644
--- a/user/src/com/google/gwt/dom/client/InputElement.java
+++ b/user/src/com/google/gwt/dom/client/InputElement.java
@@ -232,15 +232,6 @@
}-*/;
/**
- * Use client-side image map.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/objects.html#adef-usemap
- */
- public final native boolean useMap() /*-{
- return this.useMap;
- }-*/;
-
- /**
* Select the contents of the text area. For INPUT elements whose type
* attribute has one of the following values: "text", "file", or "password".
*/
@@ -409,4 +400,13 @@
public final native void setValue(String value) /*-{
this.value = value;
}-*/;
+
+ /**
+ * Use client-side image map.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/objects.html#adef-usemap
+ */
+ public final native boolean useMap() /*-{
+ return this.useMap;
+ }-*/;
}
diff --git a/user/src/com/google/gwt/dom/client/NodeCollection.java b/user/src/com/google/gwt/dom/client/NodeCollection.java
index a40b556..c84a6c7 100644
--- a/user/src/com/google/gwt/dom/client/NodeCollection.java
+++ b/user/src/com/google/gwt/dom/client/NodeCollection.java
@@ -23,6 +23,8 @@
*
* Note: Collections in the HTML DOM are assumed to be live meaning that they
* are automatically updated when the underlying document is changed.
+ *
+ * @param <T> the type of contained node
*/
public class NodeCollection<T extends Node> extends JavaScriptObject {
@@ -30,13 +32,6 @@
}
/**
- * This attribute specifies the length or size of the list.
- */
- public final native int getLength() /*-{
- return this.length;
- }-*/;
-
- /**
* This method retrieves a node specified by ordinal index. Nodes are numbered
* in tree order (depth-first traversal order).
*
@@ -49,6 +44,13 @@
}-*/;
/**
+ * This attribute specifies the length or size of the list.
+ */
+ public final native int getLength() /*-{
+ return this.length;
+ }-*/;
+
+ /**
* This method retrieves a Node using a name. With [HTML 4.01] documents, it
* first searches for a Node with a matching id attribute. If it doesn't find
* one, it then searches for a Node with a matching name attribute, but only
diff --git a/user/src/com/google/gwt/dom/client/NodeList.java b/user/src/com/google/gwt/dom/client/NodeList.java
index 2e3fa0b..6557c28 100644
--- a/user/src/com/google/gwt/dom/client/NodeList.java
+++ b/user/src/com/google/gwt/dom/client/NodeList.java
@@ -24,6 +24,8 @@
*
* The items in the NodeList are accessible via an integral index, starting from
* 0.
+ *
+ * @param <T> the type of contained node
*/
public class NodeList<T extends Node> extends JavaScriptObject {
diff --git a/user/src/com/google/gwt/dom/client/ObjectElement.java b/user/src/com/google/gwt/dom/client/ObjectElement.java
index 90e54a8..12b7b97 100644
--- a/user/src/com/google/gwt/dom/client/ObjectElement.java
+++ b/user/src/com/google/gwt/dom/client/ObjectElement.java
@@ -107,15 +107,6 @@
}-*/;
/**
- * Use client-side image map.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/objects.html#adef-usemap
- */
- public final native boolean useMap() /*-{
- return this.useMap;
- }-*/;
-
- /**
* Override width.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/objects.html#adef-width-IMG
@@ -193,4 +184,13 @@
public final native void setWidth(String width) /*-{
this.width = width;
}-*/;
+
+ /**
+ * Use client-side image map.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/objects.html#adef-usemap
+ */
+ public final native boolean useMap() /*-{
+ return this.useMap;
+ }-*/;
}
diff --git a/user/src/com/google/gwt/dom/client/OptGroupElement.java b/user/src/com/google/gwt/dom/client/OptGroupElement.java
index c2db673..fe7d914 100644
--- a/user/src/com/google/gwt/dom/client/OptGroupElement.java
+++ b/user/src/com/google/gwt/dom/client/OptGroupElement.java
@@ -44,15 +44,6 @@
}-*/;
/**
- * The control is unavailable in this context.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled
- */
- public final native void setDisabled(String disabled) /*-{
- this.disabled = disabled;
- }-*/;
-
- /**
* Assigns a label to this option group.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-label-OPTGROUP
@@ -62,6 +53,15 @@
}-*/;
/**
+ * The control is unavailable in this context.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled
+ */
+ public final native void setDisabled(String disabled) /*-{
+ this.disabled = disabled;
+ }-*/;
+
+ /**
* Assigns a label to this option group.
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-label-OPTGROUP
diff --git a/user/src/com/google/gwt/dom/client/OptionElement.java b/user/src/com/google/gwt/dom/client/OptionElement.java
index d87a3e1..9c852ab 100644
--- a/user/src/com/google/gwt/dom/client/OptionElement.java
+++ b/user/src/com/google/gwt/dom/client/OptionElement.java
@@ -38,14 +38,14 @@
* Returns the FORM element containing this control. Returns null if this
* control is not within the context of a form.
*/
- public native final FormElement getForm() /*-{
+ public final native FormElement getForm() /*-{
return form;
}-*/;
/**
* The index of this OPTION in its parent SELECT, starting from 0.
*/
- public native final int getIndex() /*-{
+ public final native int getIndex() /*-{
return this.index;
}-*/;
@@ -54,14 +54,14 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-label-OPTION
*/
- public native final String getLabel() /*-{
+ public final native String getLabel() /*-{
return this.label;
}-*/;
/**
* The text contained within the option element.
*/
- public native final String getText() /*-{
+ public final native String getText() /*-{
return this.text;
}-*/;
@@ -70,7 +70,7 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-value-OPTION
*/
- public native final String getValue() /*-{
+ public final native String getValue() /*-{
return this.value;
}-*/;
@@ -81,7 +81,7 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-selected
*/
- public native final boolean isDefaultSelected() /*-{
+ public final native boolean isDefaultSelected() /*-{
return this.defaultSelected;
}-*/;
@@ -90,7 +90,7 @@
*
* @param see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled
*/
- public native final boolean isDisabled() /*-{
+ public final native boolean isDisabled() /*-{
return this.disabled;
}-*/;
@@ -100,7 +100,7 @@
* form control, but does not change the value of the HTML selected attribute
* of the element.
*/
- public native final boolean isSelected() /*-{
+ public final native boolean isSelected() /*-{
return this.selected;
}-*/;
@@ -111,16 +111,16 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-selected
*/
- public native final void setDefaultSelected(boolean selected) /*-{
+ public final native void setDefaultSelected(boolean selected) /*-{
this.defaultSelected = selected;
}-*/;
/**
* The control is unavailable in this context.
*
- * @param see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled
*/
- public native final void setDisabled(boolean disabled) /*-{
+ public final native void setDisabled(boolean disabled) /*-{
return this.disabled = disabled;
}-*/;
@@ -129,7 +129,7 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-label-OPTION
*/
- public native final void setLabel(String label) /*-{
+ public final native void setLabel(String label) /*-{
return this.label = label;
}-*/;
@@ -139,14 +139,14 @@
* form control, but does not change the value of the HTML selected attribute
* of the element.
*/
- public native final void setSelected(boolean selected) /*-{
+ public final native void setSelected(boolean selected) /*-{
this.selected = selected;
}-*/;
/**
* The text contained within the option element.
*/
- public native final void setText(String text) /*-{
+ public final native void setText(String text) /*-{
this.text = text;
}-*/;
@@ -155,7 +155,7 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-value-OPTION
*/
- public native final void setValue(String value) /*-{
+ public final native void setValue(String value) /*-{
this.value = value;
}-*/;
}
diff --git a/user/src/com/google/gwt/dom/client/StyleElement.java b/user/src/com/google/gwt/dom/client/StyleElement.java
index 3a5d025..210b238 100644
--- a/user/src/com/google/gwt/dom/client/StyleElement.java
+++ b/user/src/com/google/gwt/dom/client/StyleElement.java
@@ -44,6 +44,24 @@
}-*/;
/**
+ * Designed for use with one or more target media.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/present/styles.html#adef-media
+ */
+ public final native String getMedia() /*-{
+ return this.media;
+ }-*/;
+
+ /**
+ * The content type of the style sheet language.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/present/styles.html#adef-type-STYLE
+ */
+ public final native String getType() /*-{
+ return this.type;
+ }-*/;
+
+ /**
* Enables/disables the style sheet.
*/
public final native void setDisabled(boolean disabled) /*-{
@@ -55,15 +73,6 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/present/styles.html#adef-media
*/
- public final native String getMedia() /*-{
- return this.media;
- }-*/;
-
- /**
- * Designed for use with one or more target media.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/present/styles.html#adef-media
- */
public final native void setMedia(String media) /*-{
this.media = media;
}-*/;
@@ -73,15 +82,6 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/present/styles.html#adef-type-STYLE
*/
- public final native String getType() /*-{
- return this.type;
- }-*/;
-
- /**
- * The content type of the style sheet language.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/present/styles.html#adef-type-STYLE
- */
public final native void setType(String type) /*-{
this.type = type;
}-*/;
diff --git a/user/src/com/google/gwt/dom/client/TableCellElement.java b/user/src/com/google/gwt/dom/client/TableCellElement.java
index 7b7b31a..fbe0a7a 100644
--- a/user/src/com/google/gwt/dom/client/TableCellElement.java
+++ b/user/src/com/google/gwt/dom/client/TableCellElement.java
@@ -35,6 +35,15 @@
}
/**
+ * Horizontal alignment of data in cell.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-align-TD
+ */
+ public final native String getAlign() /*-{
+ return this.align;
+ }-*/;
+
+ /**
* The index of this cell in the row, starting from 0. This index is in
* document tree order and not display order.
*
@@ -45,12 +54,57 @@
}-*/;
/**
- * Horizontal alignment of data in cell.
+ * Alignment character for cells in a column.
*
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-align-TD
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-char
*/
- public final native String getAlign() /*-{
- return this.align;
+ public final native String getCh() /*-{
+ return this.ch;
+ }-*/;
+
+ /**
+ * Offset of alignment character.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-charoff
+ */
+ public final native String getChOff() /*-{
+ return this.chOff;
+ }-*/;
+
+ /**
+ * Number of columns spanned by cell.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-colspan
+ */
+ public final native int getColSpan() /*-{
+ return this.colSpan;
+ }-*/;
+
+ /**
+ * List of id attribute values for header cells.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-headers
+ */
+ public final native String getHeaders() /*-{
+ return this.headers;
+ }-*/;
+
+ /**
+ * Number of rows spanned by cell.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-rowspan
+ */
+ public final native int getRowSpan() /*-{
+ return this.rowSpan;
+ }-*/;
+
+ /**
+ * Vertical alignment of data in cell.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-valign
+ */
+ public final native String getVAlign() /*-{
+ return this.vAlign;
}-*/;
/**
@@ -67,15 +121,6 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-char
*/
- public final native String getCh() /*-{
- return this.ch;
- }-*/;
-
- /**
- * Alignment character for cells in a column.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-char
- */
public final native void setCh(String ch) /*-{
this.ch = ch;
}-*/;
@@ -85,15 +130,6 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-charoff
*/
- public final native String getChOff() /*-{
- return this.chOff;
- }-*/;
-
- /**
- * Offset of alignment character.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-charoff
- */
public final native void setChOff(String chOff) /*-{
this.chOff = chOff;
}-*/;
@@ -103,15 +139,6 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-colspan
*/
- public final native int getColSpan() /*-{
- return this.colSpan;
- }-*/;
-
- /**
- * Number of columns spanned by cell.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-colspan
- */
public final native void setColSpan(int colSpan) /*-{
this.colSpan = colSpan;
}-*/;
@@ -121,15 +148,6 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-headers
*/
- public final native String getHeaders() /*-{
- return this.headers;
- }-*/;
-
- /**
- * List of id attribute values for header cells.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-headers
- */
public final native void setHeaders(String headers) /*-{
this.headers = headers;
}-*/;
@@ -139,15 +157,6 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-rowspan
*/
- public final native int getRowSpan() /*-{
- return this.rowSpan;
- }-*/;
-
- /**
- * Number of rows spanned by cell.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-rowspan
- */
public final native void setRowSpan(int rowSpan) /*-{
this.rowSpan = rowSpan;
}-*/;
@@ -157,15 +166,6 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-valign
*/
- public final native String getVAlign() /*-{
- return this.vAlign;
- }-*/;
-
- /**
- * Vertical alignment of data in cell.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#adef-valign
- */
public final native void setVAlign(String vAlign) /*-{
this.vAlign = vAlign;
}-*/;
diff --git a/user/src/com/google/gwt/dom/client/Text.java b/user/src/com/google/gwt/dom/client/Text.java
index c122368..61b4df9 100644
--- a/user/src/com/google/gwt/dom/client/Text.java
+++ b/user/src/com/google/gwt/dom/client/Text.java
@@ -26,7 +26,7 @@
*/
public static Text as(Node node) {
assert node.getNodeType() == Node.TEXT_NODE;
- return (Text)node;
+ return (Text) node;
}
protected Text() {
@@ -40,16 +40,16 @@
}-*/;
/**
- * The character data of this text node.
- */
- public final native void setData(String data) /*-{
- this.data = data;
- }-*/;
-
- /**
* The number of characters available through the data property.
*/
public final native int getLength() /*-{
return this.length;
}-*/;
+
+ /**
+ * The character data of this text node.
+ */
+ public final native void setData(String data) /*-{
+ this.data = data;
+ }-*/;
}
diff --git a/user/src/com/google/gwt/dom/client/TextAreaElement.java b/user/src/com/google/gwt/dom/client/TextAreaElement.java
index 406707d..b2cf63e 100644
--- a/user/src/com/google/gwt/dom/client/TextAreaElement.java
+++ b/user/src/com/google/gwt/dom/client/TextAreaElement.java
@@ -137,6 +137,24 @@
}-*/;
/**
+ * The control is unavailable in this context.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled
+ */
+ public final native boolean isDisabled() /*-{
+ return this.disabled;
+ }-*/;
+
+ /**
+ * This control is read-only.
+ *
+ * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-readonly
+ */
+ public final native boolean isReadOnly() /*-{
+ return this.readOnly;
+ }-*/;
+
+ /**
* Select the contents of the TEXTAREA.
*/
public final native void select() /*-{
@@ -175,15 +193,6 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled
*/
- public final native boolean isDisabled() /*-{
- return this.disabled;
- }-*/;
-
- /**
- * The control is unavailable in this context.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-disabled
- */
public final native void setDisabled(boolean disabled) /*-{
this.disabled = disabled;
}-*/;
@@ -202,15 +211,6 @@
*
* @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-readonly
*/
- public final native boolean isReadOnly() /*-{
- return this.readOnly;
- }-*/;
-
- /**
- * This control is read-only.
- *
- * @see http://www.w3.org/TR/1999/REC-html401-19991224/interact/forms.html#adef-readonly
- */
public final native void setReadOnly(boolean readOnly) /*-{
this.readOnly = readOnly;
}-*/;
diff --git a/user/src/com/google/gwt/user/client/DOM.java b/user/src/com/google/gwt/user/client/DOM.java
index ca42517..b2c7d8b 100644
--- a/user/src/com/google/gwt/user/client/DOM.java
+++ b/user/src/com/google/gwt/user/client/DOM.java
@@ -15,8 +15,6 @@
*/
package com.google.gwt.user.client;
-import java.util.ArrayList;
-
import com.google.gwt.core.client.GWT;
import com.google.gwt.core.client.GWT.UncaughtExceptionHandler;
import com.google.gwt.dom.client.Document;
@@ -25,6 +23,8 @@
import com.google.gwt.dom.client.SelectElement;
import com.google.gwt.user.client.impl.DOMImpl;
+import java.util.ArrayList;
+
/**
* This class provides a set of static methods that allow you to manipulate the
* browser's Document Object Model (DOM). It contains methods for manipulating
diff --git a/user/src/com/google/gwt/user/client/Event.java b/user/src/com/google/gwt/user/client/Event.java
index 01c2b86..f387190 100644
--- a/user/src/com/google/gwt/user/client/Event.java
+++ b/user/src/com/google/gwt/user/client/Event.java
@@ -173,17 +173,17 @@
}
/**
- * TODO
+ * TODO: doc.
*/
- public static void sinkEvents(Element elem, int eventBits) {
- DOM.sinkEvents((com.google.gwt.user.client.Element)elem, eventBits);
+ public static int getEventsSunk(Element elem) {
+ return DOM.getEventsSunk((com.google.gwt.user.client.Element) elem);
}
/**
- * TODO
+ * TODO: doc.
*/
- public static int getEventsSunk(Element elem) {
- return DOM.getEventsSunk((com.google.gwt.user.client.Element)elem);
+ public static void sinkEvents(Element elem, int eventBits) {
+ DOM.sinkEvents((com.google.gwt.user.client.Element) elem, eventBits);
}
/**
@@ -194,26 +194,6 @@
}
/**
- * Gets the current target element of this event. This is the element whose
- * listener fired last, not the element which fired the event initially.
- *
- * @return the event's current target element
- */
- public final Element getCurrentTarget() {
- return DOM.eventGetCurrentTarget(this);
- }
-
- /**
- * Gets the enumerated type of this event, as defined by {@link #ONCLICK},
- * {@link #ONMOUSEDOWN}, and so forth.
- *
- * @return the event's enumerated type
- */
- public final int getTypeInt() {
- return DOM.eventGetType(this);
- }
-
- /**
* Cancels bubbling for the given event. This will stop the event from being
* propagated to parent elements.
*
@@ -270,6 +250,16 @@
}
/**
+ * Gets the current target element of this event. This is the element whose
+ * listener fired last, not the element which fired the event initially.
+ *
+ * @return the event's current target element
+ */
+ public final Element getCurrentTarget() {
+ return DOM.eventGetCurrentTarget(this);
+ }
+
+ /**
* Gets the element from which the mouse pointer was moved (only valid for
* {@link Event#ONMOUSEOVER}).
*
@@ -359,6 +349,18 @@
}
/**
+ * Gets a string representation of this event.
+ *
+ * We do not override {@link #toString()} because it is final in
+ * {@link JavaScriptObject}.
+ *
+ * @return the string representation of this event
+ */
+ public final String getString() {
+ return DOM.eventToString(this);
+ }
+
+ /**
* Returns the element that was the actual target of the given event.
*
* @return the target element
@@ -380,7 +382,6 @@
/**
* Gets the enumerated type of this event (as defined in {@link Event}).
*
- * @param evt the event to be tested
* @return the event's enumerated type
*/
public final String getType() {
@@ -388,21 +389,19 @@
}
/**
+ * Gets the enumerated type of this event, as defined by {@link #ONCLICK},
+ * {@link #ONMOUSEDOWN}, and so forth.
+ *
+ * @return the event's enumerated type
+ */
+ public final int getTypeInt() {
+ return DOM.eventGetType(this);
+ }
+
+ /**
* Prevents the browser from taking its default action for the given event.
*/
public final void preventDefault() {
DOM.eventPreventDefault(this);
}
-
- /**
- * Gets a string representation of this event.
- *
- * We do not override {@link #toString()} because it is final in
- * {@link JavaScriptObject}.
- *
- * @return the string representation of this event
- */
- public final String getString() {
- return DOM.eventToString(this);
- }
}
diff --git a/user/test/com/google/gwt/dom/DOMSuite.java b/user/test/com/google/gwt/dom/DOMSuite.java
index 54d66ab..db4114b 100644
--- a/user/test/com/google/gwt/dom/DOMSuite.java
+++ b/user/test/com/google/gwt/dom/DOMSuite.java
@@ -15,8 +15,6 @@
*/
package com.google.gwt.dom;
-import junit.framework.Test;
-
import com.google.gwt.dom.client.DocumentTest;
import com.google.gwt.dom.client.ElementTest;
import com.google.gwt.dom.client.FormTests;
@@ -26,6 +24,11 @@
import com.google.gwt.dom.client.TableTests;
import com.google.gwt.junit.tools.GWTTestSuite;
+import junit.framework.Test;
+
+/**
+ * Tests for the DOM package.
+ */
public class DOMSuite {
public static Test suite() {
GWTTestSuite suite = new GWTTestSuite(
