commit 3a0cfb37f1330ea64dc546cbc16bf20517eba017
author scottb@google.com <scottb@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Wed Mar 26 18:20:04 2008 +0000
committer scottb@google.com <scottb@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Wed Mar 26 18:20:04 2008 +0000
tree 5c51945e6acb83d7fb2fccc6f2979cb7b92e335e
parent b06dbc20efb7e9f94cdc1dd191a121b6c4473b57

Fixes an ICE in LongEmulationNormalizer for a "long <concat> string" operation.

Found by: jburley
Review by: spoon (postmortem)


git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@2224 8db76d5a-ed1c-0410-87a9-c151d255dfc7

dev/core/src/com/google/gwt/dev/jjs/impl/LongEmulationNormalizer.java

diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/LongEmulationNormalizer.java b/dev/core/src/com/google/gwt/dev/jjs/impl/LongEmulationNormalizer.java
index 0127090..2b7a8c6 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/LongEmulationNormalizer.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/LongEmulationNormalizer.java
@@ -49,9 +49,14 @@
 

     @Override

     public void endVisit(JBinaryOperation x, Context ctx) {

+      // Concats are handled by CastNormalizer.ConcatVisitor.

+      if (x.getType() == program.getTypeJavaLangString()) {

+        return;

+      }

       JType lhsType = x.getLhs().getType();

       JType rhsType = x.getRhs().getType();

       if (lhsType != longType) {

+        assert (rhsType != longType);

         return;

       }