Adding Element#getPreviousSibling().
Issue: 3670
Review at http://gwt-code-reviews.appspot.com/1581803
Review by: skybrian@google.com
git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@10722 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/user/src/com/google/gwt/dom/client/DOMImpl.java b/user/src/com/google/gwt/dom/client/DOMImpl.java
index 881aded..08aa00d 100644
--- a/user/src/com/google/gwt/dom/client/DOMImpl.java
+++ b/user/src/com/google/gwt/dom/client/DOMImpl.java
@@ -268,6 +268,13 @@
return parent;
}-*/;
+ public native Element getPreviousSiblingElement(Element elem) /*-{
+ var sib = elem.previousSibling;
+ while (sib && sib.nodeType != 1)
+ sib = sib.previousSibling;
+ return sib;
+ }-*/;
+
public int getScrollLeft(Document doc) {
return doc.getViewportElement().getScrollLeft();
}
diff --git a/user/src/com/google/gwt/dom/client/Element.java b/user/src/com/google/gwt/dom/client/Element.java
index 3a11935..663a1bf 100644
--- a/user/src/com/google/gwt/dom/client/Element.java
+++ b/user/src/com/google/gwt/dom/client/Element.java
@@ -345,6 +345,14 @@
}-*/;
/**
+ * The element immediately preceeding this element. If there is no such
+ * element, this returns null.
+ */
+ public final Element getPreviousSiblingElement() {
+ return DOMImpl.impl.getPreviousSiblingElement(this);
+ }
+
+ /**
* Gets a boolean property from this element.
*
* @param name the name of the property to be retrieved
diff --git a/user/test/com/google/gwt/dom/client/ElementTest.java b/user/test/com/google/gwt/dom/client/ElementTest.java
index ba87b94..f1e1950 100644
--- a/user/test/com/google/gwt/dom/client/ElementTest.java
+++ b/user/test/com/google/gwt/dom/client/ElementTest.java
@@ -16,13 +16,13 @@
package com.google.gwt.dom.client;
import com.google.gwt.core.client.JavaScriptObject;
+import com.google.gwt.core.client.Scheduler;
+import com.google.gwt.core.client.Scheduler.ScheduledCommand;
import com.google.gwt.dom.client.Style.Position;
import com.google.gwt.dom.client.Style.Unit;
import com.google.gwt.junit.DoNotRunWith;
import com.google.gwt.junit.Platform;
import com.google.gwt.junit.client.GWTTestCase;
-import com.google.gwt.user.client.Command;
-import com.google.gwt.user.client.DeferredCommand;
/**
* Element tests (many stolen from DOMTest).
@@ -52,7 +52,7 @@
}
/**
- * firstChildElement, nextSiblingElement.
+ * firstChildElement, nextSiblingElement, previousSiblingElement.
*/
public void testChildElements() {
Document doc = Document.get();
@@ -67,8 +67,13 @@
Element fc = parent.getFirstChildElement();
Element ns = fc.getNextSiblingElement();
+ Element ps = ns.getPreviousSiblingElement();
assertEquals(div0, fc);
assertEquals(div1, ns);
+ assertEquals(div0, ps);
+
+ assertNull(fc.getPreviousSiblingElement());
+ assertNull(ns.getNextSiblingElement());
}
/**
@@ -201,7 +206,8 @@
elem.getStyle().setPropertyPx("width", width);
elem.getStyle().setPropertyPx("height", height);
- DeferredCommand.addCommand(new Command() {
+ Scheduler.get().scheduleDeferred(new ScheduledCommand() {
+ @Override
public void execute() {
int absLeft = left + margin;
int absTop = top + margin;
