Fixing HasWidgetsTester#testAll to actually call testDoDetachChildrenWithError. Currently, it calls testDoAttachChildrenWithError twice. HTMLTableTestBase needs to be modified to work with the test.
Review at http://gwt-code-reviews.appspot.com/1300801
Review by: pdr@google.com
git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@9572 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java b/user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java
index 17c3d57..998500b 100644
--- a/user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java
+++ b/user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java
@@ -33,8 +33,10 @@
*/
public abstract class HTMLTableTestBase extends GWTTestCase {
static class Adder implements HasWidgetsTester.WidgetAdder {
+ private int row = -1;
+
public void addChild(HasWidgets container, Widget child) {
- ((HTMLTable) container).setWidget(0, 0, child);
+ ((HTMLTable) container).setWidget(++row, 0, child);
}
}
@@ -67,7 +69,7 @@
public abstract HTMLTable getTable(int row, int column);
public void testAttachDetachOrder() {
- HasWidgetsTester.testAll(getTable(1, 1), new Adder(), true);
+ HasWidgetsTester.testAll(getTable(25, 1), new Adder(), true);
}
public void testBoundsOnEmptyTable() {
diff --git a/user/test/com/google/gwt/user/client/ui/HasWidgetsTester.java b/user/test/com/google/gwt/user/client/ui/HasWidgetsTester.java
index 4bbbb9c..78fc776 100644
--- a/user/test/com/google/gwt/user/client/ui/HasWidgetsTester.java
+++ b/user/test/com/google/gwt/user/client/ui/HasWidgetsTester.java
@@ -112,7 +112,7 @@
testAttachDetachOrder(container, adder);
testRemovalOfNonExistantChild(container);
testDoAttachChildrenWithError(container, adder, supportsMultipleWidgets);
- testDoAttachChildrenWithError(container, adder, supportsMultipleWidgets);
+ testDoDetachChildrenWithError(container, adder, supportsMultipleWidgets);
}
/**
