Reduce Eclipse warnings to a dull roar
Review at http://gwt-code-reviews.appspot.com/640802
Review by: jat@google.com
git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@8294 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/dev/core/src/com/google/gwt/core/ext/linker/Artifact.java b/dev/core/src/com/google/gwt/core/ext/linker/Artifact.java
index 1e715f5..185246c 100644
--- a/dev/core/src/com/google/gwt/core/ext/linker/Artifact.java
+++ b/dev/core/src/com/google/gwt/core/ext/linker/Artifact.java
@@ -58,7 +58,7 @@
*/
@Override
public final boolean equals(Object obj) {
- if (obj instanceof Artifact) {
+ if (obj instanceof Artifact<?>) {
return compareTo((Artifact<?>) obj) == 0;
} else {
return false;
diff --git a/dev/core/src/com/google/gwt/core/ext/linker/ArtifactSet.java b/dev/core/src/com/google/gwt/core/ext/linker/ArtifactSet.java
index 36ca26a..28502a7 100644
--- a/dev/core/src/com/google/gwt/core/ext/linker/ArtifactSet.java
+++ b/dev/core/src/com/google/gwt/core/ext/linker/ArtifactSet.java
@@ -103,7 +103,7 @@
* UnsupportedOperationException.
*/
public void freeze() {
- if (treeSet instanceof TreeSet) {
+ if (treeSet instanceof TreeSet<?>) {
treeSet = Collections.unmodifiableSortedSet(treeSet);
}
}
diff --git a/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java b/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
index b241738..a59bdad 100644
--- a/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
+++ b/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
@@ -226,6 +226,11 @@
+ ".nocache.js", lastModified);
}
+ /**
+ * @param logger a TreeLogger
+ * @param context a LinkerContext
+ * @param fragment the fragment number
+ */
protected String generateDeferredFragment(TreeLogger logger,
LinkerContext context, int fragment, String js) {
return js;
diff --git a/dev/core/src/com/google/gwt/core/ext/soyc/impl/SizeMapRecorder.java b/dev/core/src/com/google/gwt/core/ext/soyc/impl/SizeMapRecorder.java
index fff9d4e..912f040 100644
--- a/dev/core/src/com/google/gwt/core/ext/soyc/impl/SizeMapRecorder.java
+++ b/dev/core/src/com/google/gwt/core/ext/soyc/impl/SizeMapRecorder.java
@@ -157,6 +157,9 @@
builder.append(c, lastIndex, len - lastIndex);
}
+ /**
+ * @param logger a TreeLogger
+ */
public static void recordMap(TreeLogger logger, OutputStream out,
SizeBreakdown[] sizeBreakdowns, JavaToJavaScriptMap jjsmap,
Map<JsName, String> obfuscateMap) throws IOException {
diff --git a/dev/core/src/com/google/gwt/core/ext/soyc/impl/StandardFunctionMember.java b/dev/core/src/com/google/gwt/core/ext/soyc/impl/StandardFunctionMember.java
index 9b530b7..317565c 100644
--- a/dev/core/src/com/google/gwt/core/ext/soyc/impl/StandardFunctionMember.java
+++ b/dev/core/src/com/google/gwt/core/ext/soyc/impl/StandardFunctionMember.java
@@ -28,6 +28,8 @@
/**
* Constructed by {@link MemberFactory#get(JsFunction)}.
+ *
+ * @param factory a MemberFactory instance
*/
public StandardFunctionMember(MemberFactory factory, JsFunction function) {
super(function.getSourceInfo());
diff --git a/dev/core/src/com/google/gwt/dev/HeadlessUI.java b/dev/core/src/com/google/gwt/dev/HeadlessUI.java
index c70e10f..40f3e88 100644
--- a/dev/core/src/com/google/gwt/dev/HeadlessUI.java
+++ b/dev/core/src/com/google/gwt/dev/HeadlessUI.java
@@ -25,6 +25,9 @@
*/
public class HeadlessUI extends DevModeUI {
+ /**
+ * @param options unused
+ */
public HeadlessUI(HostedModeBaseOptions options) {
}
diff --git a/dev/core/src/com/google/gwt/dev/WebServerPanel.java b/dev/core/src/com/google/gwt/dev/WebServerPanel.java
index 4fb3986..dcbd86a 100644
--- a/dev/core/src/com/google/gwt/dev/WebServerPanel.java
+++ b/dev/core/src/com/google/gwt/dev/WebServerPanel.java
@@ -44,6 +44,9 @@
this(serverPort, maxLevel, logFile, null);
}
+ /**
+ * @param serverPort the server port number
+ */
public WebServerPanel(int serverPort, TreeLogger.Type maxLevel,
File logFile, final RestartAction restartServerAction) {
super(new BorderLayout());
diff --git a/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java b/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
index 40110f4..3cf13ec 100644
--- a/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
+++ b/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
@@ -79,7 +79,7 @@
* @param slashedPackageName the '/' separated name of the package to find
* @return <code>true</code> if such a package exists
*/
- public boolean doFindAdditionalPackage(String slashedPackageName);
+ boolean doFindAdditionalPackage(String slashedPackageName);
/**
* Finds a new compilation unit on-the-fly for the requested type, if there
@@ -89,7 +89,7 @@
* @return a unit answering the name, or <code>null</code> if no such unit
* can be created
*/
- public GeneratedUnit doFindAdditionalType(String binaryName);
+ GeneratedUnit doFindAdditionalType(String binaryName);
}
/**
diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java b/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java
index 66c76f2..472f6c0 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java
@@ -328,6 +328,9 @@
return splitPoints.get(0);
}
+ /**
+ * @param numSplitPoints the total number of split points
+ */
public static int getExclusiveFragmentNumber(int splitPoint,
int numSplitPoints) {
return splitPoint;
diff --git a/dev/core/src/com/google/gwt/dev/js/JsStaticEval.java b/dev/core/src/com/google/gwt/dev/js/JsStaticEval.java
index 6845e21..b5ae65c 100644
--- a/dev/core/src/com/google/gwt/dev/js/JsStaticEval.java
+++ b/dev/core/src/com/google/gwt/dev/js/JsStaticEval.java
@@ -830,6 +830,7 @@
return (new JsStaticEval(program)).execImpl();
}
+ @SuppressWarnings("unchecked")
public static <T extends JsVisitable> T exec(JsProgram program, T node) {
return (new JsStaticEval(program)).execImpl(node);
}
@@ -939,6 +940,7 @@
return sev.didChange();
}
+ @SuppressWarnings("unchecked")
public <T extends JsVisitable> T execImpl(T node) {
return new StaticEvalVisitor().accept(node);
}
diff --git a/dev/core/src/com/google/gwt/dev/js/ast/JsName.java b/dev/core/src/com/google/gwt/dev/js/ast/JsName.java
index 0b605e9..96d7e50 100644
--- a/dev/core/src/com/google/gwt/dev/js/ast/JsName.java
+++ b/dev/core/src/com/google/gwt/dev/js/ast/JsName.java
@@ -32,6 +32,7 @@
/**
* A back-reference to the JsNode that the JsName refers to.
*/
+ @SuppressWarnings("unchecked")
private JsNode staticRef;
/**
@@ -56,6 +57,7 @@
return shortIdent;
}
+ @SuppressWarnings("unchecked")
public JsNode getStaticRef() {
return staticRef;
}
@@ -79,6 +81,7 @@
/**
* Should never be called except on immutable stuff.
*/
+ @SuppressWarnings("unchecked")
public void setStaticRef(JsNode node) {
this.staticRef = node;
}
diff --git a/dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java b/dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java
index 4e353e9..c90d35d 100644
--- a/dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java
+++ b/dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java
@@ -59,9 +59,6 @@
static final Message1String NEW_RESOURCE_FOUND = new Message1String(
TreeLogger.DEBUG, "Found new resource: $0");
- static final Message0 NO_RESOURCES_CHANGED = new Message0(TreeLogger.DEBUG,
- "No resources changed");
-
static final Message0 REFRESHING_RESOURCES = new Message0(TreeLogger.TRACE,
"Refreshing resources");
diff --git a/dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java b/dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java
index 5f70df0..27819b3 100644
--- a/dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java
+++ b/dev/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java
@@ -160,7 +160,7 @@
} else if (member instanceof Method) {
name = member.getName();
paramTypes = ((Method) member).getParameterTypes();
- } else if (member instanceof Constructor) {
+ } else if (member instanceof Constructor<?>) {
name = "new";
paramTypes = ((Constructor<?>) member).getParameterTypes();
} else {
diff --git a/dev/core/src/com/google/gwt/dev/shell/HtmlUnitSessionHandler.java b/dev/core/src/com/google/gwt/dev/shell/HtmlUnitSessionHandler.java
index 81edb9b..ceac009 100644
--- a/dev/core/src/com/google/gwt/dev/shell/HtmlUnitSessionHandler.java
+++ b/dev/core/src/com/google/gwt/dev/shell/HtmlUnitSessionHandler.java
@@ -143,6 +143,9 @@
return htmlPage;
}
+ /**
+ * @param jsContext the Context
+ */
public Object getToStringTearOff(Context jsContext) {
return toStringMethod;
}
@@ -153,6 +156,7 @@
+ jsEngine.getWebClient().getBrowserVersion().getUserAgent();
}
+ @SuppressWarnings("unchecked")
@Override
public ExceptionOrReturnValue invoke(BrowserChannelClient channel, Value thisObj,
String methodName, Value[] args) {
@@ -170,7 +174,7 @@
Object obj = makeJsvalFromValue(jsContext, thisObj);
if (obj instanceof ScriptableObject) {
jsThis = (ScriptableObject) obj;
- } else if (obj instanceof SimpleScriptableProxy) {
+ } else if (obj instanceof SimpleScriptableProxy<?>) {
jsThis = ((SimpleScriptableProxy<SimpleScriptable>) obj).getDelegee();
} else {
logger.log(TreeLogger.ERROR, "Unable to convert " + obj + " to either "
@@ -235,6 +239,9 @@
logger.log(TreeLogger.INFO, "LOAD_JSNI: scriptResult=" + scriptResult);
}
+ /**
+ * @param jsContext the Context
+ */
public Value makeValueFromJsval(Context jsContext, Object value) {
if (value == Undefined.instance) {
return new Value();
diff --git a/dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java b/dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java
index 7737996..2323597 100644
--- a/dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java
+++ b/dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java
@@ -106,7 +106,7 @@
Member m = getMember(dispId);
if (m instanceof Method) {
return new MethodAdaptor((Method) m);
- } else if (m instanceof Constructor) {
+ } else if (m instanceof Constructor<?>) {
return new MethodAdaptor((Constructor<?>) m);
} else {
throw new RuntimeException();
@@ -140,7 +140,7 @@
}
Member m = getMember(dispId);
- return (m instanceof Method) || (m instanceof Constructor);
+ return (m instanceof Method) || (m instanceof Constructor<?>);
}
/**
diff --git a/dev/core/src/com/google/gwt/dev/shell/JavaObject.java b/dev/core/src/com/google/gwt/dev/shell/JavaObject.java
index 9a4a0ea..323e710 100644
--- a/dev/core/src/com/google/gwt/dev/shell/JavaObject.java
+++ b/dev/core/src/com/google/gwt/dev/shell/JavaObject.java
@@ -44,6 +44,9 @@
javaRef.getRefid(), context);
}
+ /**
+ * @param cx the Context
+ */
static ExceptionOrReturnValue getReturnFromJavaMethod(Context cx,
HtmlUnitSessionHandler sessionHandler, BrowserChannelClient channel,
int dispatchId, Value thisValue, Value valueArgs[]) {
@@ -66,6 +69,9 @@
}
}
+ /**
+ * @param jsContext the Context
+ */
static boolean isJavaObject(Context jsContext, ScriptableObject javaObject) {
return javaObject instanceof JavaObject;
}
diff --git a/dev/core/src/com/google/gwt/dev/shell/Jsni.java b/dev/core/src/com/google/gwt/dev/shell/Jsni.java
index 102c637..2533cd7 100644
--- a/dev/core/src/com/google/gwt/dev/shell/Jsni.java
+++ b/dev/core/src/com/google/gwt/dev/shell/Jsni.java
@@ -131,7 +131,7 @@
int paramCount = 0;
if (member instanceof Method) {
paramCount = ((Method) member).getParameterTypes().length;
- } else if (member instanceof Constructor) {
+ } else if (member instanceof Constructor<?>) {
paramCount = ((Constructor<?>) member).getParameterTypes().length;
}
@@ -187,14 +187,14 @@
* and rewrite the call site as though -1 is a valid dispid.
*/
if (member == null || member instanceof Method
- || member instanceof Constructor) {
+ || member instanceof Constructor<?>) {
// Use a clone instead of modifying the original JSNI
// __gwt_makeJavaInvoke(paramCount)(obj, dispId, args)
int paramCount = 0;
if (member instanceof Method) {
paramCount = ((Method) member).getParameterTypes().length;
- } else if (member instanceof Constructor) {
+ } else if (member instanceof Constructor<?>) {
paramCount = ((Constructor<?>) member).getParameterTypes().length;
}
@@ -230,6 +230,8 @@
/**
* Gets the body of a JSNI method, with Java refs escaped for hosted mode
* injection.
+ *
+ * @param logger a TreeLogger
*/
public static String getJavaScriptForHostedMode(TreeLogger logger,
DispatchIdOracle dispatchInfo, JsniMethod jsniMethod) {
diff --git a/dev/core/src/com/google/gwt/dev/shell/tomcat/CommonsLoggerAdapter.java b/dev/core/src/com/google/gwt/dev/shell/tomcat/CommonsLoggerAdapter.java
index 9975619..d071d2a 100644
--- a/dev/core/src/com/google/gwt/dev/shell/tomcat/CommonsLoggerAdapter.java
+++ b/dev/core/src/com/google/gwt/dev/shell/tomcat/CommonsLoggerAdapter.java
@@ -24,6 +24,9 @@
private TreeLogger log;
+ /**
+ * @param name unused
+ */
public CommonsLoggerAdapter(String name) {
// NOTE: this is ugly, but I don't know of any other way to get a
// non-static log to which we can delegate.
diff --git a/dev/core/src/com/google/gwt/dev/util/collect/IdentitySingletonMap.java b/dev/core/src/com/google/gwt/dev/util/collect/IdentitySingletonMap.java
index bbd50f3..53d2a96 100644
--- a/dev/core/src/com/google/gwt/dev/util/collect/IdentitySingletonMap.java
+++ b/dev/core/src/com/google/gwt/dev/util/collect/IdentitySingletonMap.java
@@ -26,7 +26,7 @@
@Override
public boolean equals(Object o) {
- if (!(o instanceof Entry)) {
+ if (!(o instanceof Entry<?, ?>)) {
return false;
}
Entry<?, ?> entry = (Entry<?, ?>) o;
diff --git a/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java b/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
index 4d5eeae..94873c6 100644
--- a/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
+++ b/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
@@ -325,8 +325,7 @@
Set<String> existingSet = sortedClasses.get(curSize);
existingSet.add(className);
sortedClasses.put(curSize, existingSet);
- }
- else {
+ } else {
Set<String> newSet = new TreeSet<String>();
newSet.add(className);
sortedClasses.put(curSize, newSet);
@@ -352,7 +351,7 @@
for (Integer size : sortedClasses.keySet()) {
Set<String> classNames = sortedClasses.get(size);
for (String className : classNames) {
- float perc = ((float)size / (float)sumSize) * 100;
+ float perc = ((float) size / sumSize) * 100;
outFile.println("<tr>");
outFile.println("<td>" + className + "</a></td>");
outFile.println("<td>");
@@ -433,8 +432,7 @@
Set<String> existingSet = sortedClasses.get(curSize);
existingSet.add(className);
sortedClasses.put(curSize, existingSet);
- }
- else {
+ } else {
Set<String> newSet = new TreeSet<String>();
newSet.add(className);
sortedClasses.put(curSize, newSet);
@@ -464,7 +462,7 @@
Set<String> classNames = sortedClasses.get(size);
for (String className : classNames) {
String drillDownFileName = depLinker.dependencyLinkForClass(className);
- float perc = ((float)size / (float)sumSize) * 100;
+ float perc = ((float) size / (float) sumSize) * 100;
outFile.println("<tr>");
if (drillDownFileName == null) {
outFile.println("<td>" + className + "</td>");
@@ -575,7 +573,7 @@
int size = breakdown.sizeAllCode;
float perc;
- perc = ((float)size / (float)maxSize) * 100;
+ perc = ((float) size / (float) maxSize) * 100;
outFile.println("<tr>");
outFile.println("<td>" + i + "</td>");
@@ -726,8 +724,7 @@
Set<String> existingSet = sortedCodeTypes.get(curSize);
existingSet.add(codeType);
sortedCodeTypes.put(curSize, existingSet);
- }
- else {
+ } else {
Set<String> newSet = new TreeSet<String>();
newSet.add(codeType);
sortedCodeTypes.put(curSize, newSet);
@@ -755,7 +752,7 @@
for (String codeType : codeTypes) {
String drillDownFileName = breakdown.getId() + "_" + codeType + "-"
+ getPermutationId() + "Classes.html";
- float perc = ((float)size / (float)sumSize) * 100;
+ float perc = ((float) size / (float) sumSize) * 100;
outFile.println("<tr>");
outFile.println("<td><a href=\"" + drillDownFileName
+ "\" target=\"_top\">" + codeType + "</a></td>");
@@ -897,8 +894,7 @@
Set<String> existingSet = sortedPackages.get(curSize);
existingSet.add(packageName);
sortedPackages.put(curSize, existingSet);
- }
- else {
+ } else {
Set<String> newSet = new TreeSet<String>();
newSet.add(packageName);
sortedPackages.put(curSize, newSet);
@@ -926,7 +922,7 @@
for (String packageName : packageNames) {
String drillDownFileName = classesInPackageFileName(breakdown,
packageName, getPermutationId());
- float perc = ((float)size / (float)sumSize) * 100;
+ float perc = (size / sumSize) * 100;
outFile.println("<tr>");
outFile.println("<td><a href=\"" + drillDownFileName
+ "\" target=\"_top\">" + packageName + "</a></td>");
diff --git a/user/src/com/google/gwt/core/client/impl/CrossSiteLoadingStrategy.java b/user/src/com/google/gwt/core/client/impl/CrossSiteLoadingStrategy.java
index b8f2633..599281d 100644
--- a/user/src/com/google/gwt/core/client/impl/CrossSiteLoadingStrategy.java
+++ b/user/src/com/google/gwt/core/client/impl/CrossSiteLoadingStrategy.java
@@ -40,6 +40,7 @@
return (IntToIntMap) JavaScriptObject.createArray();
}
+ @SuppressWarnings("unused")
protected IntToIntMap() {
}
diff --git a/user/src/com/google/gwt/dom/client/DOMImplSafari.java b/user/src/com/google/gwt/dom/client/DOMImplSafari.java
index d928538..fb42962 100644
--- a/user/src/com/google/gwt/dom/client/DOMImplSafari.java
+++ b/user/src/com/google/gwt/dom/client/DOMImplSafari.java
@@ -23,6 +23,8 @@
class DOMImplSafari extends DOMImplStandard {
private static class ClientRect extends JavaScriptObject {
+
+ @SuppressWarnings("unused")
protected ClientRect() {
}
diff --git a/user/src/com/google/gwt/event/dom/client/PrivateMap.java b/user/src/com/google/gwt/event/dom/client/PrivateMap.java
index 9f264bf..0a03cf0 100644
--- a/user/src/com/google/gwt/event/dom/client/PrivateMap.java
+++ b/user/src/com/google/gwt/event/dom/client/PrivateMap.java
@@ -38,6 +38,7 @@
return JavaScriptObject.createObject().cast();
}
+ @SuppressWarnings("unused")
protected JsMap() {
}
diff --git a/user/src/com/google/gwt/i18n/client/impl/ConstantMap.java b/user/src/com/google/gwt/i18n/client/impl/ConstantMap.java
index f683e97..5d206e2 100644
--- a/user/src/com/google/gwt/i18n/client/impl/ConstantMap.java
+++ b/user/src/com/google/gwt/i18n/client/impl/ConstantMap.java
@@ -45,7 +45,7 @@
@Override
public boolean equals(Object o) {
- if (o instanceof Map.Entry) {
+ if (o instanceof Map.Entry<?, ?>) {
Map.Entry<?, ?> other = (Map.Entry<?, ?>) o;
// Key and value known to be non-null.
if (key.equals(other.getKey()) && value.equals(other.getValue())) {
@@ -123,7 +123,7 @@
return new AbstractSet<Entry<String, String>>() {
@Override
public boolean contains(Object o) {
- if (!(o instanceof Entry)) {
+ if (!(o instanceof Entry<?, ?>)) {
return false;
}
Entry<?, ?> other = (Entry<?, ?>) o;
diff --git a/user/src/com/google/gwt/junit/CompileStrategy.java b/user/src/com/google/gwt/junit/CompileStrategy.java
index cc62ecd..c19b98d 100644
--- a/user/src/com/google/gwt/junit/CompileStrategy.java
+++ b/user/src/com/google/gwt/junit/CompileStrategy.java
@@ -78,7 +78,6 @@
*
* @throws UnableToCompleteException if the compilation fails
*/
- @SuppressWarnings("unused")
public void maybeCompileAhead() throws UnableToCompleteException {
}
diff --git a/user/src/com/google/gwt/logging/client/DefaultLevel.java b/user/src/com/google/gwt/logging/client/DefaultLevel.java
index c25bd47..0d16e50 100644
--- a/user/src/com/google/gwt/logging/client/DefaultLevel.java
+++ b/user/src/com/google/gwt/logging/client/DefaultLevel.java
@@ -25,7 +25,7 @@
*/
public interface DefaultLevel {
/**
- * Returns Level.ALL as the default level
+ * Returns Level.ALL as the default level.
*/
public class All implements DefaultLevel {
public Level getLevel() {
@@ -34,7 +34,7 @@
}
/**
- * Returns Level.CONFIG as the default level
+ * Returns Level.CONFIG as the default level.
*/
public class Config implements DefaultLevel {
public Level getLevel() {
@@ -43,7 +43,7 @@
}
/**
- * Returns Level.FINE as the default level
+ * Returns Level.FINE as the default level.
*/
public class Fine implements DefaultLevel {
public Level getLevel() {
@@ -52,7 +52,7 @@
}
/**
- * Returns Level.FINER as the default level
+ * Returns Level.FINER as the default level.
*/
public class Finer implements DefaultLevel {
public Level getLevel() {
@@ -61,7 +61,7 @@
}
/**
- * Returns Level.FINEST as the default level
+ * Returns Level.FINEST as the default level.
*/
public class Finest implements DefaultLevel {
public Level getLevel() {
@@ -70,7 +70,7 @@
}
/**
- * Returns Level.INFO as the default level
+ * Returns Level.INFO as the default level.
*/
public class Info implements DefaultLevel {
public Level getLevel() {
@@ -79,7 +79,7 @@
}
/**
- * Returns Level.SEVERE as the default level
+ * Returns Level.SEVERE as the default level.
*/
public class Severe implements DefaultLevel {
public Level getLevel() {
@@ -88,7 +88,7 @@
}
/**
- * Returns Level.WARNING as the default level
+ * Returns Level.WARNING as the default level.
*/
public class Warning implements DefaultLevel {
public Level getLevel() {
diff --git a/user/src/com/google/gwt/logging/client/FirebugLogHandler.java b/user/src/com/google/gwt/logging/client/FirebugLogHandler.java
index bffd9be..9e84c51 100644
--- a/user/src/com/google/gwt/logging/client/FirebugLogHandler.java
+++ b/user/src/com/google/gwt/logging/client/FirebugLogHandler.java
@@ -21,7 +21,7 @@
import java.util.logging.LogRecord;
/**
- * A Handler that prints logs to window.console which is used by Firebug
+ * A Handler that prints logs to window.console which is used by Firebug.
* Note we are consciously using 'window' rather than '$wnd' to avoid issues
* similar to http://code.google.com/p/fbug/issues/detail?id=2914
*/
diff --git a/user/src/com/google/gwt/logging/client/LoggingPopup.java b/user/src/com/google/gwt/logging/client/LoggingPopup.java
index 955dabb..0ddc1d3 100644
--- a/user/src/com/google/gwt/logging/client/LoggingPopup.java
+++ b/user/src/com/google/gwt/logging/client/LoggingPopup.java
@@ -44,7 +44,7 @@
public class LoggingPopup extends PopupPanel {
/**
- * Handles the logic to track click-drag movements with the mouse
+ * Handles the logic to track click-drag movements with the mouse.
*/
private abstract class MouseDragHandler implements MouseMoveHandler,
MouseUpHandler, MouseDownHandler {
diff --git a/user/src/com/google/gwt/logging/client/SystemLogHandler.java b/user/src/com/google/gwt/logging/client/SystemLogHandler.java
index 1a35ff2..428bbb9 100644
--- a/user/src/com/google/gwt/logging/client/SystemLogHandler.java
+++ b/user/src/com/google/gwt/logging/client/SystemLogHandler.java
@@ -23,7 +23,7 @@
import java.util.logging.LogRecord;
/**
- * A Handler that prints logs to System.out or System.err
+ * A Handler that prints logs to System.out or System.err.
*/
public class SystemLogHandler extends Handler {
diff --git a/user/src/com/google/gwt/logging/client/TextLogFormatter.java b/user/src/com/google/gwt/logging/client/TextLogFormatter.java
index 183d5b1..1c01125 100644
--- a/user/src/com/google/gwt/logging/client/TextLogFormatter.java
+++ b/user/src/com/google/gwt/logging/client/TextLogFormatter.java
@@ -21,7 +21,7 @@
import java.util.logging.LogRecord;
/**
- * Formats LogRecords into 2 lines of text
+ * Formats LogRecords into 2 lines of text.
*/
public class TextLogFormatter extends Formatter {
diff --git a/user/src/com/google/gwt/resources/css/ast/CssCompilerException.java b/user/src/com/google/gwt/resources/css/ast/CssCompilerException.java
index f6a05bd..5e5b9c6 100644
--- a/user/src/com/google/gwt/resources/css/ast/CssCompilerException.java
+++ b/user/src/com/google/gwt/resources/css/ast/CssCompilerException.java
@@ -27,6 +27,9 @@
super(message, cause);
}
+ /**
+ * @param node TODO
+ */
// FIXME - what does this do?
void addNode(CssNode node) {
}
diff --git a/user/src/com/google/gwt/uibinder/elementparsers/InterpreterPipe.java b/user/src/com/google/gwt/uibinder/elementparsers/InterpreterPipe.java
index 0c0ebb9..d4667ac 100644
--- a/user/src/com/google/gwt/uibinder/elementparsers/InterpreterPipe.java
+++ b/user/src/com/google/gwt/uibinder/elementparsers/InterpreterPipe.java
@@ -70,7 +70,7 @@
*/
public String postProcess(String consumedText) throws UnableToCompleteException {
for (XMLElement.Interpreter<T> i : pipe) {
- if (i instanceof PostProcessingInterpreter) {
+ if (i instanceof PostProcessingInterpreter<?>) {
consumedText = ((PostProcessingInterpreter<T>) i).postProcess(consumedText);
}
}
diff --git a/user/src/com/google/gwt/user/client/impl/DOMImplTrident.java b/user/src/com/google/gwt/user/client/impl/DOMImplTrident.java
index 6ee1894..7bed0d0 100644
--- a/user/src/com/google/gwt/user/client/impl/DOMImplTrident.java
+++ b/user/src/com/google/gwt/user/client/impl/DOMImplTrident.java
@@ -87,7 +87,7 @@
@Override
public native void initEventSystem() /*-{
- // All GWT apps on the page register themselves with the globelEventArray
+ // All GWT apps on the page register themselves with the globalEventArray
// so that the first app to handle an event can allow all apps on the page
// to preview it. See issue 3892 for more details.
//
diff --git a/user/src/com/google/gwt/user/client/rpc/core/java/util/Collections.java b/user/src/com/google/gwt/user/client/rpc/core/java/util/Collections.java
index 4c24a79..6984e04 100644
--- a/user/src/com/google/gwt/user/client/rpc/core/java/util/Collections.java
+++ b/user/src/com/google/gwt/user/client/rpc/core/java/util/Collections.java
@@ -110,13 +110,13 @@
List instance) throws SerializationException {
}
- @SuppressWarnings({"unused", "unchecked"})
+ @SuppressWarnings("unchecked")
public static List instantiate(SerializationStreamReader streamReader)
throws SerializationException {
return java.util.Collections.singletonList(streamReader.readObject());
}
- @SuppressWarnings({"unused", "unchecked"})
+ @SuppressWarnings("unchecked")
public static void serialize(SerializationStreamWriter streamWriter,
List instance) throws SerializationException {
streamWriter.writeObject(instance.get(0));
diff --git a/user/src/com/google/gwt/user/client/ui/FastStringMap.java b/user/src/com/google/gwt/user/client/ui/FastStringMap.java
index 36caa12..4316783 100644
--- a/user/src/com/google/gwt/user/client/ui/FastStringMap.java
+++ b/user/src/com/google/gwt/user/client/ui/FastStringMap.java
@@ -47,7 +47,7 @@
@Override
public boolean equals(Object a) {
- if (a instanceof Map.Entry) {
+ if (a instanceof Map.Entry<?, ?>) {
Map.Entry<?, ?> s = (Map.Entry<?, ?>) a;
if (equalsWithNullCheck(key, s.getKey())
&& equalsWithNullCheck(value, s.getValue())) {
diff --git a/user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java b/user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java
index 010f53c..c4b9157 100644
--- a/user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java
+++ b/user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java
@@ -53,7 +53,6 @@
*
* @see SplitLayoutPanel
*/
-@SuppressWarnings("deprecation")
@Deprecated
public final class HorizontalSplitPanel extends SplitPanel {
/**
@@ -175,8 +174,7 @@
* @param rightElem
* @param newRightWidth
*/
- public void updateRightWidth(@SuppressWarnings("unused") Element rightElem,
- @SuppressWarnings("unused") int newRightWidth) {
+ public void updateRightWidth(Element rightElem, int newRightWidth) {
// No need to update the width of the right side; this will be
// recomputed automatically by CSS. This is helpful, as we do not
// have to worry about watching for resize events and adjusting the
diff --git a/user/src/com/google/gwt/user/client/ui/TabPanel.java b/user/src/com/google/gwt/user/client/ui/TabPanel.java
index 3ba2587..9cc0fe1 100644
--- a/user/src/com/google/gwt/user/client/ui/TabPanel.java
+++ b/user/src/com/google/gwt/user/client/ui/TabPanel.java
@@ -68,7 +68,6 @@
*/
//Cannot do anything about tab panel implementing TabListener until next release.
-@SuppressWarnings("deprecation")
@Deprecated
public class TabPanel extends Composite implements TabListener,
SourcesTabEvents, HasWidgets, HasAnimation, IndexedPanel,
diff --git a/user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java b/user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java
index a6b1633..c3f720d 100644
--- a/user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java
+++ b/user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java
@@ -53,7 +53,6 @@
*
* @see SplitLayoutPanel
*/
-@SuppressWarnings("deprecation")
@Deprecated
public final class VerticalSplitPanel extends SplitPanel {
/**
@@ -140,7 +139,7 @@
* @param bottomHeight
*/
protected void updateElements(Element topElem, Element splitElem,
- Element bottomElem, int topHeight, int bottomTop, @SuppressWarnings("unused") int bottomHeight) {
+ Element bottomElem, int topHeight, int bottomTop, int bottomHeight) {
setHeight(topElem, topHeight + "px");
setTop(splitElem, topHeight + "px");
diff --git a/user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java b/user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java
index 6a67d73..83a2ffd 100644
--- a/user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java
+++ b/user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java
@@ -377,6 +377,8 @@
/**
* Generate any fields required by the proxy.
+ *
+ * @param serializableTypeOracle the type oracle
*/
protected void generateProxyFields(SourceWriter srcWriter,
SerializableTypeOracle serializableTypeOracle,
@@ -394,6 +396,8 @@
/**
* Generates the client's asynchronous proxy method.
+ *
+ * @param serializableTypeOracle the type oracle
*/
protected void generateProxyMethod(SourceWriter w,
SerializableTypeOracle serializableTypeOracle, JMethod syncMethod,
diff --git a/user/src/com/google/gwt/user/rebind/rpc/SerializationUtils.java b/user/src/com/google/gwt/user/rebind/rpc/SerializationUtils.java
index a46e5fc..3d33e05 100644
--- a/user/src/com/google/gwt/user/rebind/rpc/SerializationUtils.java
+++ b/user/src/com/google/gwt/user/rebind/rpc/SerializationUtils.java
@@ -66,8 +66,9 @@
* Returns the set of fields that are serializable for a given class type.
* This method does not consider any superclass fields.
*
+ * @param typeOracle the type oracle
* @param classType the class for which we want serializable fields
- * @return array of fields that meet the serialization criteria.
+ * @return array of fields that meet the serialization criteria
*/
public static JField[] getSerializableFields(TypeOracle typeOracle,
JClassType classType) {
diff --git a/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java b/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
index d92c83a..04eb528 100644
--- a/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
+++ b/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
@@ -156,7 +156,7 @@
return Collections.unmodifiableMap(typeStrings);
}
- public String realize(TreeLogger logger) throws UnableToCompleteException {
+ public String realize(TreeLogger logger) {
logger = logger.branch(TreeLogger.DEBUG,
"Generating TypeSerializer for service interface '"
+ getTypeSerializerClassName() + "'", null);
diff --git a/user/src/com/google/gwt/util/regexfilter/RegexFilter.java b/user/src/com/google/gwt/util/regexfilter/RegexFilter.java
index 07a60fa..806151b 100644
--- a/user/src/com/google/gwt/util/regexfilter/RegexFilter.java
+++ b/user/src/com/google/gwt/util/regexfilter/RegexFilter.java
@@ -16,7 +16,6 @@
package com.google.gwt.util.regexfilter;
-import com.google.gwt.core.ext.ConfigurationProperty;
import com.google.gwt.core.ext.TreeLogger;
import com.google.gwt.core.ext.UnableToCompleteException;
@@ -39,7 +38,6 @@
public RegexFilter(TreeLogger logger, List<String> values)
throws UnableToCompleteException {
- ConfigurationProperty prop;
this.values = values;
int size = values.size();
typePatterns = new ArrayList<Pattern>(size);
diff --git a/user/test/com/google/gwt/emultest/benchmarks/java/util/ArrayListBenchmark.java b/user/test/com/google/gwt/emultest/benchmarks/java/util/ArrayListBenchmark.java
index 86adeea..9131632 100644
--- a/user/test/com/google/gwt/emultest/benchmarks/java/util/ArrayListBenchmark.java
+++ b/user/test/com/google/gwt/emultest/benchmarks/java/util/ArrayListBenchmark.java
@@ -15,7 +15,6 @@
*/
package com.google.gwt.emultest.benchmarks.java.util;
-
import java.util.List;
import java.util.ArrayList;
diff --git a/user/test/com/google/gwt/http/client/RequestBuilderTest.java b/user/test/com/google/gwt/http/client/RequestBuilderTest.java
index b35c8f4..0df54c4 100644
--- a/user/test/com/google/gwt/http/client/RequestBuilderTest.java
+++ b/user/test/com/google/gwt/http/client/RequestBuilderTest.java
@@ -198,7 +198,7 @@
* Need to file an HtmlUnit bug. TODO(amitmanjhi): contribute an HtmlUnit
* patch.
*/
- @DoNotRunWith( {Platform.HtmlUnitBug})
+ @DoNotRunWith({Platform.HtmlUnitBug})
public void testSend_HEAD() throws RequestException {
RequestBuilder builder = new RequestBuilder(RequestBuilder.HEAD,
getTestBaseURL());
@@ -237,7 +237,7 @@
* Need to file an HtmlUnit bug. TODO(amitmanjhi): contribute an HtmlUnit
* patch.
*/
- @DoNotRunWith( {Platform.HtmlUnitBug})
+ @DoNotRunWith({Platform.HtmlUnitBug})
public void testSendRequest_HEAD() throws RequestException {
RequestBuilder builder = new RequestBuilder(RequestBuilder.HEAD,
getTestBaseURL());
diff --git a/user/test/com/google/gwt/uibinder/test/client/FooImage.java b/user/test/com/google/gwt/uibinder/test/client/FooImage.java
index cfddeea..1e18a3b 100644
--- a/user/test/com/google/gwt/uibinder/test/client/FooImage.java
+++ b/user/test/com/google/gwt/uibinder/test/client/FooImage.java
@@ -18,7 +18,7 @@
import com.google.gwt.user.client.ui.Image;
/**
- * Tests that custom Image subclasses work
+ * Tests that custom Image subclasses work.
*/
public class FooImage extends Image {
public FooImage() {
diff --git a/user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java b/user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
index fed497f..fbdf469 100644
--- a/user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
+++ b/user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
@@ -201,7 +201,7 @@
assertEquals("Custom dialog am I", widgetUi.fooDialog.getText());
Widget body = widgetUi.fooDialog.iterator().next();
assertTrue(body instanceof Label);
- assertEquals("body", ((Label)body).getText());
+ assertEquals("body", ((Label) body).getText());
}
public void testDomAccessAndComputedAttributeOnPlaceholderedElement() {
