Fixes issue 2261 "DisclosurePanel animation is flickering on IE" by replacing 0px height with 1px height in order for height to be respected by IE7.
Review by:jlabanca(pair review)
Issue:2261
git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@2543 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/user/src/com/google/gwt/user/client/ui/DisclosurePanel.java b/user/src/com/google/gwt/user/client/ui/DisclosurePanel.java
index c1ebab4..9805bc3 100644
--- a/user/src/com/google/gwt/user/client/ui/DisclosurePanel.java
+++ b/user/src/com/google/gwt/user/client/ui/DisclosurePanel.java
@@ -16,11 +16,11 @@
package com.google.gwt.user.client.ui;
import com.google.gwt.core.client.GWT;
+import com.google.gwt.i18n.client.LocaleInfo;
import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.Element;
import com.google.gwt.user.client.Event;
import com.google.gwt.user.client.animation.WidgetAnimation;
-import com.google.gwt.i18n.client.LocaleInfo;
import java.util.ArrayList;
import java.util.Iterator;
@@ -100,6 +100,7 @@
if (!opening) {
height = scrollHeight - height;
}
+ height = Math.max(height, 1);
DOM.setStyleAttribute(curPanel.contentWrapper.getElement(), "height",
height + "px");
DOM.setStyleAttribute(curPanel.contentWrapper.getElement(), "width",
@@ -249,7 +250,7 @@
private static DisclosurePanelImages createDefaultImages() {
if (LocaleInfo.getCurrentLocale().isRTL()) {
- return GWT.create(DisclosurePanelImagesRTL.class);
+ return GWT.create(DisclosurePanelImagesRTL.class);
}
return GWT.create(DisclosurePanelImages.class);
}
@@ -407,9 +408,6 @@
return (widget instanceof HasText) ? (HasText) widget : null;
}
- /**
- * @see HasAnimation#isAnimationEnabled()
- */
public boolean isAnimationEnabled() {
return isAnimationEnabled;
}
@@ -447,10 +445,7 @@
}
handlers.remove(handler);
}
-
- /**
- * @see HasAnimation#setAnimationEnabled(boolean)
- */
+
public void setAnimationEnabled(boolean enable) {
isAnimationEnabled = enable;
}