git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@79 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/eclipse/settings/code-style/gwt-checkstyle.xml b/eclipse/settings/code-style/gwt-checkstyle.xml
index d1e661b..c257c3b 100644
--- a/eclipse/settings/code-style/gwt-checkstyle.xml
+++ b/eclipse/settings/code-style/gwt-checkstyle.xml
@@ -1,148 +1,195 @@
-<?xml version="1.0" encoding="UTF-8"?>
+<?xml version="1.0" encoding="UTF-8"?>
<!--
This configuration file was written by the eclipse-cs plugin configuration editor
--->
+-->
<!--
-Checkstyle-Configuration: GWT Checkstyle Rules
+Checkstyle-Configuration: GWT Checks
Description:
--->
-<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
-<module name="Checker">
- <property name="severity" value="warning"/>
- <module name="TreeWalker">
- <module name="FileContentsHolder"/>
- <module name="InterfaceIsType"/>
- <module name="RedundantImport"/>
- <module name="UnusedImports"/>
- <module name="JavadocType">
- <property name="scope" value="protected"/>
- </module>
- <module name="PackageName">
- <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]{1,})*$"/>
- </module>
- <module name="ParameterName"/>
- <module name="LocalFinalVariableName"/>
- <module name="LocalVariableName"/>
- <module name="LeftCurly"/>
- <module name="RightCurly"/>
- <module name="CovariantEquals"/>
- <module name="HiddenField">
- <property name="tokens" value="VARIABLE_DEF"/>
- <property name="ignoreConstructorParameter" value="true"/>
- <property name="ignoreSetter" value="true"/>
- </module>
- <module name="IllegalInstantiation">
- <property name="classes" value="java.lang.Boolean"/>
- </module>
- <module name="UpperEll">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="checking for 4l rather than 4L"/>
- </module>
- <module name="JavadocStyle">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Well formed java docs"/>
- <property name="checkHtml" value="false"/>
- <property name="tokens" value="CLASS_DEF,CTOR_DEF,INTERFACE_DEF,METHOD_DEF,VARIABLE_DEF"/>
- </module>
- <module name="NeedBraces">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="make sure if has braces"/>
- </module>
- <module name="JavadocMethod">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.lastEnabledSeverity" value="info"/>
- <property name="severity" value="info"/>
- <property name="scope" value="protected"/>
- <property name="allowUndeclaredRTE" value="true"/>
- <property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
- <property name="allowMissingReturnTag" value="true"/>
- <property name="allowMissingJavadoc" value="true"/>
- <property name="allowMissingPropertyJavadoc" value="true"/>
- <property name="logLoadErrors" value="true"/>
- <property name="tokens" value="METHOD_DEF"/>
- </module>
- <module name="Header">
- <property name="header" value="/*\n * Copyright 2006 Google Inc.\n * \n * Licensed under the Apache License, Version 2.0 (the "License"); you may not\n * use this file except in compliance with the License. You may obtain a copy of\n * the License at\n * \n * http://www.apache.org/licenses/LICENSE-2.0\n * \n * Unless required by applicable law or agreed to in writing, software\n * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT\n * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n * License for the specific language governing permissions and limitations under\n * the License.\n */"/>
- </module>
- <module name="ImportOrder">
- <property name="groups" value="com.google, com, junit, net,org, java,javax"/>
- <property name="ordered" value="false"/>
- <property name="separated" value="true"/>
- </module>
- <module name="TabCharacter">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="no tabs"/>
- </module>
- <module name="DefaultComesLast"/>
- <module name="MultipleStringLiterals">
- <property name="severity" value="info"/>
- <property name="ignoreStringsRegexp" value=".{0,3}"/>
- </module>
- <module name="FallThrough"/>
- <module name="IllegalInstantiation">
- <property name="classes" value="Boolean"/>
- </module>
- <module name="Regexp">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="check that a space is left after a colon with an assembled error message"/>
- <property name="severity" value="info"/>
- <property name="format" value="[^:^"]:" .*+"/>
- <property name="message" value="check that a space is left after a colon on an assembled error message"/>
- <property name="illegalPattern" value="true"/>
- </module>
- <module name="Regexp">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="more than one blank line"/>
- <property name="format" value="[\r]?[\n][ \t]*[\r]?[\n][ \t]*[\r]?[\n][ \t]*"/>
- <property name="message" value="more than one blank line"/>
- <property name="illegalPattern" value="true"/>
- </module>
- <module name="WhitespaceAround">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Must have spaces"/>
- <property name="tokens" value="COLON,NOT_EQUAL,QUESTION,DIV,DIV_ASSIGN,BXOR,BXOR_ASSIGN,MINUS,LCURLY,STAR,STAR_ASSIGN,TYPE_EXTENSION_AND,BAND,LAND,BAND_ASSIGN,MOD,MOD_ASSIGN,PLUS,PLUS_ASSIGN,LT,SL,SL_ASSIGN,LE,ASSIGN,MINUS_ASSIGN,EQUAL,GT,GE,SR,SR_ASSIGN,BSR,BSR_ASSIGN,BOR,BOR_ASSIGN,LOR,LITERAL_ASSERT,LITERAL_ASSERT,LITERAL_CATCH,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_RETURN,SLIST,LITERAL_SYNCHRONIZED,LITERAL_TRY,WILDCARD_TYPE,LITERAL_WHILE"/>
- </module>
- <module name="Regexp">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="newline before }"/>
- <property name="format" value="[\r]?[\n][ \t]*[\r]?[\n][ \t]+[}][ ]*[\n]"/>
- <property name="message" value="newline before }"/>
- <property name="illegalPattern" value="true"/>
- </module>
- <module name="ModifierOrder"/>
- <module name="AvoidStarImport"/>
- <module name="com.google.gwt.checkstyle.OrderCheck"/>
- <module name="com.google.gwt.checkstyle.FieldCheck"/>
- <module name="GenericIllegalRegexp">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="bad // comment"/>
- <property name="format" value=" [/][/][A-z]"/>
- <property name="message" value="// comments must be followed by a space and be on their own line"/>
- </module>
- <module name="DoubleCheckedLocking"/>
- <module name="EmptyStatement"/>
- <module name="MethodName"/>
- <module name="MemberName">
- <property name="format" value="[a-z]|[a-z][a-z_0-9][A-Za-z0-9_]*|[a-z](?<!f)[A-Z0-9]*"/>
- </module>
- <module name="TodoComment">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Author tags"/>
- <property name="format" value="@author"/>
- </module>
- <module name="Regexp">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="No one line javadoc comments"/>
- <property name="format" value="[/][*][*][^\n]*[*][/]"/>
- <property name="message" value="No one line javadoc comments"/>
- <property name="illegalPattern" value="true"/>
- </module>
- </module>
- <module name="PackageHtml">
- <property name="severity" value="ignore"/>
- </module>
- <module name="StrictDuplicateCode">
- <property name="severity" value="ignore"/>
- </module>
- <module name="SuppressionCommentFilter">
- <property name="offCommentFormat" value="CHECKSTYLE_OFF"/>
- <property name="onCommentFormat" value="CHECKSTYLE_ON"/>
- </module>
- <module name="SuppressionCommentFilter">
- <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Avoid name checking"/>
+-->
+<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
+<module name="Checker">
+ <property name="severity" value="warning"/>
+ <module name="TreeWalker">
+ <module name="FileContentsHolder"/>
+ <module name="InterfaceIsType">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="RedundantImport">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="UnusedImports">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="JavadocType">
+ <property name="severity" value="error"/>
+ <property name="scope" value="protected"/>
+ </module>
+ <module name="PackageName">
+ <property name="severity" value="error"/>
+ <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]{1,})*$"/>
+ </module>
+ <module name="ParameterName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="LocalFinalVariableName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="LocalVariableName">
+ <property name="severity" value="error"/>
+ <property name="tokens" value="PARAMETER_DEF,VARIABLE_DEF"/>
+ </module>
+ <module name="LeftCurly"/>
+ <module name="RightCurly"/>
+ <module name="CovariantEquals">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="HiddenField">
+ <property name="severity" value="error"/>
+ <property name="tokens" value="VARIABLE_DEF"/>
+ <property name="ignoreConstructorParameter" value="true"/>
+ <property name="ignoreSetter" value="true"/>
+ </module>
+ <module name="IllegalInstantiation">
+ <property name="severity" value="error"/>
+ <property name="classes" value="java.lang.Boolean"/>
+ </module>
+ <module name="UpperEll">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="checking for 4l rather than 4L"/>
+ <property name="severity" value="error"/>
+ </module>
+ <module name="JavadocStyle">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Well formed java docs"/>
+ <property name="severity" value="info"/>
+ <property name="checkHtml" value="false"/>
+ <property name="tokens" value="CLASS_DEF,CTOR_DEF,INTERFACE_DEF,METHOD_DEF,VARIABLE_DEF"/>
+ </module>
+ <module name="NeedBraces">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="make sure if has braces"/>
+ </module>
+ <module name="JavadocMethod">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.lastEnabledSeverity" value="info"/>
+ <property name="severity" value="info"/>
+ <property name="scope" value="protected"/>
+ <property name="allowUndeclaredRTE" value="true"/>
+ <property name="allowMissingParamTags" value="true"/>
+ <property name="allowMissingThrowsTags" value="true"/>
+ <property name="allowMissingReturnTag" value="true"/>
+ <property name="allowMissingJavadoc" value="true"/>
+ <property name="allowMissingPropertyJavadoc" value="true"/>
+ <property name="logLoadErrors" value="true"/>
+ <property name="tokens" value="METHOD_DEF"/>
+ </module>
+ <module name="Header">
+ <property name="severity" value="error"/>
+ <property name="header" value="/*\n * Copyright 2006 Google Inc.\n * \n * Licensed under the Apache License, Version 2.0 (the "License"); you may not\n * use this file except in compliance with the License. You may obtain a copy of\n * the License at\n * \n * http://www.apache.org/licenses/LICENSE-2.0\n * \n * Unless required by applicable law or agreed to in writing, software\n * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT\n * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n * License for the specific language governing permissions and limitations under\n * the License.\n */"/>
+ </module>
+ <module name="ImportOrder">
+ <property name="severity" value="error"/>
+ <property name="groups" value="com.google, com, junit, net,org, java,javax"/>
+ <property name="ordered" value="false"/>
+ <property name="separated" value="true"/>
+ </module>
+ <module name="TabCharacter">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="no tabs"/>
+ <property name="severity" value="error"/>
+ </module>
+ <module name="DefaultComesLast">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="MultipleStringLiterals">
+ <property name="severity" value="info"/>
+ <property name="ignoreStringsRegexp" value=".{0,3}"/>
+ </module>
+ <module name="FallThrough">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="IllegalInstantiation">
+ <property name="severity" value="error"/>
+ <property name="classes" value="Boolean"/>
+ </module>
+ <module name="Regexp">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="check that a space is left after a colon with an assembled error message"/>
+ <property name="severity" value="info"/>
+ <property name="format" value="[^:^"]:" .*+"/>
+ <property name="message" value="check that a space is left after a colon on an assembled error message"/>
+ <property name="illegalPattern" value="true"/>
+ </module>
+ <module name="Regexp">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="more than one blank line"/>
+ <property name="severity" value="info"/>
+ <property name="format" value="[\r]?[\n][ \t]*[\r]?[\n][ \t]*[\r]?[\n][ \t]*"/>
+ <property name="message" value="more than one blank line"/>
+ <property name="illegalPattern" value="true"/>
+ </module>
+ <module name="WhitespaceAround">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Must have spaces"/>
+ <property name="severity" value="error"/>
+ <property name="tokens" value="COLON,NOT_EQUAL,QUESTION,DIV,DIV_ASSIGN,BXOR,BXOR_ASSIGN,MINUS,LCURLY,STAR,STAR_ASSIGN,TYPE_EXTENSION_AND,BAND,LAND,BAND_ASSIGN,MOD,MOD_ASSIGN,PLUS,PLUS_ASSIGN,LT,SL,SL_ASSIGN,LE,ASSIGN,MINUS_ASSIGN,EQUAL,GT,GE,SR,SR_ASSIGN,BSR,BSR_ASSIGN,BOR,BOR_ASSIGN,LOR,LITERAL_ASSERT,LITERAL_ASSERT,LITERAL_CATCH,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_RETURN,SLIST,LITERAL_SYNCHRONIZED,LITERAL_TRY,WILDCARD_TYPE,LITERAL_WHILE"/>
+ </module>
+ <module name="Regexp">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="newline before }"/>
+ <property name="severity" value="error"/>
+ <property name="format" value="[\r]?[\n][ \t]*[\r]?[\n][ \t]+[}][ ]*[\n]"/>
+ <property name="message" value="newline before }"/>
+ <property name="illegalPattern" value="true"/>
+ </module>
+ <module name="ModifierOrder">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="AvoidStarImport">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="com.google.gwt.checkstyle.OrderCheck">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="com.google.gwt.checkstyle.FieldCheck">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="GenericIllegalRegexp">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="bad // comment"/>
+ <property name="severity" value="error"/>
+ <property name="format" value=" [/][/][A-z]"/>
+ <property name="message" value="// comments must be followed by a space and be on their own line"/>
+ </module>
+ <module name="DoubleCheckedLocking">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="EmptyStatement">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="MethodName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="MemberName">
+ <property name="severity" value="error"/>
+ <property name="format" value="[a-z]|[a-z][a-z_0-9][A-Za-z0-9_]*|[a-z](?<!f)[A-Z0-9]*"/>
+ </module>
+ <module name="TodoComment">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Author tags"/>
+ <property name="severity" value="error"/>
+ <property name="format" value="@author"/>
+ </module>
+ <module name="Regexp">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="No one line javadoc comments"/>
+ <property name="severity" value="error"/>
+ <property name="format" value="[/][*][*][^\n]*[*][/]"/>
+ <property name="message" value="No one line javadoc comments"/>
+ <property name="illegalPattern" value="true"/>
+ </module>
+ </module>
+ <module name="PackageHtml">
+ <property name="severity" value="ignore"/>
+ </module>
+ <module name="SuppressionCommentFilter">
+ <property name="offCommentFormat" value="CHECKSTYLE_OFF"/>
+ <property name="onCommentFormat" value="CHECKSTYLE_ON"/>
+ </module>
+ <module name="SuppressionCommentFilter">
+ <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Avoid name checking"/>
<property name="offCommentFormat" value="CHECKSTYLE_NAMING_OFF"/>
- <property name="onCommentFormat" value="CHECKSTYLE_NAMING_ON"/>
- <property name="checkFormat" value=".*Name.*"/>
- <property name="messageFormat" value=".*name.*"/>
- </module>
-</module>
+ <property name="onCommentFormat" value="CHECKSTYLE_NAMING_ON"/>
+ <property name="checkFormat" value=".*Name.*"/>
+ <property name="messageFormat" value=".*name.*"/>
+ </module>
+</module>
