commit 6075b6e9aa9749a317de0a0026a0f6b420034e69
author scottb@google.com <scottb@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Mon Mar 31 20:50:36 2008 +0000
committer scottb@google.com <scottb@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Mon Mar 31 20:50:36 2008 +0000
tree 9468645f3b383f7cd88fc45dfee0fb0b70235e7a
parent c74e8a9ce316c3b3107e3499216e38c70cced205

Tweaked comments to more accurately reflect the 'phases' of compilation.


git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@2299 8db76d5a-ed1c-0410-87a9-c151d255dfc7

dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java

diff --git a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
index a869872..b1de0ef 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
@@ -362,6 +362,8 @@
         allTypeDeclarations = null;
       }
 
+      // (3) Perform Java AST normalizations.
+
       /*
        * TODO: If we defer this until later, we could maybe use the results of
        * the assertions to enable more optimizations.
@@ -374,7 +376,7 @@
         AssertionRemover.exec(jprogram);
       }
 
-      // (3) Resolve all rebinds through GWT.create().
+      // Resolve all rebinds through GWT.create().
       ReplaceRebinds.exec(jprogram);
 
       if (options.isValidateOnly()) {
@@ -443,13 +445,13 @@
       jprogram.typeOracle.recomputeClinits();
       GenerateJavaScriptAST.exec(jprogram, jsProgram, options.getOutput());
 
-      // (8) Fix invalid constructs created during JS AST gen
+      // (8) Normalize the JS AST.
+      // Fix invalid constructs created during JS AST gen.
       JsNormalizer.exec(jsProgram);
-
-      // (9) Resolve all unresolved JsNameRefs
+      // Resolve all unresolved JsNameRefs.
       JsSymbolResolver.exec(jsProgram);
 
-      // (10) Apply optimizations to JavaScript AST
+      // (9) Optimize the JS AST.
       if (options.isAggressivelyOptimize()) {
         do {
           didChange = false;
@@ -463,7 +465,7 @@
         } while (didChange);
       }
 
-      // (11) Obfuscate
+      // (10) Obfuscate
       switch (options.getOutput()) {
         case OBFUSCATED:
           JsStringInterner.exec(jsProgram);
@@ -481,10 +483,13 @@
           throw new InternalCompilerException("Unknown output mode");
       }
 
-      // (12) Work around an IE7 bug
+      // (11) Perform any post-obfuscation normalizations.
+
+      // Work around an IE7 bug,
       // http://code.google.com/p/google-web-toolkit/issues/detail?id=1440
       JsIEBlockSizeVisitor.exec(jsProgram);
 
+      // (12) Generate the final output text.
       DefaultTextOutput out = new DefaultTextOutput(
           options.getOutput().shouldMinimize());
       JsSourceGenerationVisitor v = new JsSourceGenerationVisitor(out);