Added warning comments regarding ASM and COMPUTE_MAXS.
Suggested by: tobyr
git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@2663 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/dev/core/src/com/google/gwt/dev/shell/rewrite/RewriteJsniMethods.java b/dev/core/src/com/google/gwt/dev/shell/rewrite/RewriteJsniMethods.java
index 475a7d7..54a536f 100644
--- a/dev/core/src/com/google/gwt/dev/shell/rewrite/RewriteJsniMethods.java
+++ b/dev/core/src/com/google/gwt/dev/shell/rewrite/RewriteJsniMethods.java
@@ -237,6 +237,11 @@
public void visitCode() {
super.visitCode();
+ /*
+ * If you modify the generated code, you must recompute the stack size
+ * in visitEnd().
+ */
+
// First argument - JSNI signature
String jsniTarget = getJsniSignature(name, descriptor);
visitLdcInsn(jsniTarget);
@@ -278,6 +283,9 @@
/*
* For speed, we don't ask ASM to COMPUTE_MAXS. We manually calculated a
* max depth of 8.
+ *
+ * Also, when tobyr tried getting ASM to compute the correct stack size,
+ * ASM seemed to compute the wrong value for reasons we don't understand.
*/
int maxStack = 8;
int maxLocals = 0; // Computed by GeneratorAdapter superclass.
