commit 64b86735cc6f8b0a5fe1416fc88d1faa5bdbc0cb
author scottb@google.com <scottb@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Wed Apr 21 00:38:52 2010 +0000
committer scottb@google.com <scottb@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Wed Apr 21 00:38:52 2010 +0000
tree 05c334ef77b5b39686d3a7b9ff053641f42459e4
parent ec121f872ce7478cd5f0b1588e00c0dfd74b9f6c

NPE in RunStyleExternalBrowser

If the module fails to startup, an NPE can get tripped here.

http://gwt-code-reviews.appspot.com/375801/show
Review by: amitmanjhi


git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@7956 8db76d5a-ed1c-0410-87a9-c151d255dfc7

user/src/com/google/gwt/junit/RunStyleExternalBrowser.java

diff --git a/user/src/com/google/gwt/junit/RunStyleExternalBrowser.java b/user/src/com/google/gwt/junit/RunStyleExternalBrowser.java
index adf4af8..ed967e5 100644
--- a/user/src/com/google/gwt/junit/RunStyleExternalBrowser.java
+++ b/user/src/com/google/gwt/junit/RunStyleExternalBrowser.java
@@ -57,11 +57,13 @@
     @Override
     public void run() {
       for (ExternalBrowser browser : externalBrowsers) {
-        try {
-          browser.getProcess().exitValue();
-        } catch (IllegalThreadStateException e) {
-          // The process is still active. Kill it.
-          browser.getProcess().destroy();
+        if (browser.getProcess() != null) {
+          try {
+            browser.getProcess().exitValue();
+          } catch (IllegalThreadStateException e) {
+            // The process is still active. Kill it.
+            browser.getProcess().destroy();
+          }
         }
       }
     }