commit 66ef7c7a5b824cec80bdb4b3b8d5897497d75f18
author Daniel Kurka <dankurka@google.com> Wed Sep 17 17:08:33 2014 -0700
committer Daniel Kurka <dankurka@google.com> Wed Sep 17 17:27:16 2014 -0700
tree 8e67c4761b3257528d12534825e206b051e7f763
parent 37338d9604d76e0baba22d45a517bb1f7b7918f3

Make CssResourceGenerator produce stable and correct output.

In incremental mode CssResourceGenerator produces collisions of CSS class
names, since its obfuscation depends in an internal counter.
We need the generator to produce stable and unique names,
so we are forcing this in incremental compiles.

Change-Id: I636f8d8254961e2b724a9442cd8b5df83067051b

dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java

diff --git a/dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java b/dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java
index 7bd1d72..2086185 100644
--- a/dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java
+++ b/dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java
@@ -440,6 +440,17 @@
     maybeOverrideConfig(moduleDef, "propertiesJs",
         "com/google/gwt/core/ext/linker/impl/properties.js");
 
+    if (options.shouldCompilePerFile()) {
+      // CSSResourceGenerator needs to produce stable, unique naming for its input.
+      // Currently on default settings CssResourceGenerator's obfuscation depends on
+      // whole world knowledge and thus will produce collision in obfuscated mode, since in
+      // incremental compiles that information is not available.
+      //
+      // TODO(dankurka): Once we do proper stable hashing of classes in CssResourceGenerator, we
+      // can probably replace / remove this.
+      maybeOverrideConfig(moduleDef, "CssResource.style", "stable");
+    }
+
     overrideBinding(moduleDef, "compiler.useSourceMaps", "true");
     overrideBinding(moduleDef, "compiler.useSymbolMaps", "false");
     overrideBinding(moduleDef, "superdevmode", "on");