commit 6e31a1594fc154fbdce4184a133d0e0475d9019b
author Goktug Gokdogan <goktug@google.com> Tue Jan 28 12:40:25 2014 -0800
committer Goktug Gokdogan <goktug@google.com> Tue Jan 28 12:57:51 2014 -0800
tree ae7af32cd3e6bcdf74b18d0909d45281ded672a5
parent 12a8262eb2534f79af49e2a830eb7a5b770cba87

Sync back internal build file changes

Change-Id: Ic7dabac2c44cf8c46759a1a03ed99eeff2403f89

dev/BUILD

diff --git a/dev/BUILD b/dev/BUILD
index 89e0a47..0f9b2a0 100644
--- a/dev/BUILD
+++ b/dev/BUILD
@@ -145,6 +145,8 @@
     deps = [
         ":compiler.standalone.super",
         "//third_party/java_src/gwt/svn/tools:dev_deps",
+        # Safe to depend on servlet_api_3 because nobody directly depends on gwt-dev-classes
+        "//third_party/java_src/gwt/svn/tools:servlet_api_3",
     ],
 )
 

dev/codeserver/BUILD

diff --git a/dev/codeserver/BUILD b/dev/codeserver/BUILD
index 942bd0a..dc4ba24 100644
--- a/dev/codeserver/BUILD
+++ b/dev/codeserver/BUILD
@@ -45,7 +45,8 @@
         # approved dependencies (for open source code)
         "//third_party/java_src/gwt:gwt-dev",
         "//third_party/java_src/gwt:gwt-dev-private",
-        # no other dependencies allowed
+        # Codeserver is known to leak servlet_api_3 - dependents should be cautious
+        "//third_party/java_src/gwt/svn/tools:servlet_api_3",
         "//third_party/java/json",  # undeclared dependency of SourceMapConsumer. TODO: fix
     ],
 )