)]}'
{
  "commit": "7041820d8789d3f5babbdc89df53e1d3ca51d121",
  "tree": "8328d2b1af2d9c85595aed192c310b055378a85c",
  "parents": [
    "02d203ece2b7ca2999c51f996a075a71ee815d68"
  ],
  "author": {
    "name": "gwt.team.jgw",
    "email": "gwt.team.jgw@8db76d5a-ed1c-0410-87a9-c151d255dfc7",
    "time": "Thu Jul 12 16:46:21 2007 +0000"
  },
  "committer": {
    "name": "gwt.team.jgw",
    "email": "gwt.team.jgw@8db76d5a-ed1c-0410-87a9-c151d255dfc7",
    "time": "Thu Jul 12 16:46:21 2007 +0000"
  },
  "message": "PopupPanel.onEventPreview doesn\u0027t call the onKeyXXXPreview method unless the\nkey event originates from a Widget inside the PopupPanel.  If the PopupPanel\ndoes not contain a key event source (such as an input element), the key events\nwill be ignored entirely.\n\nChange: I changed the logic to always fire the onKeyXXXPreview method, then\ncancel the event based on the return value of the call, the event target, and\nthe modal setting.\n\nboolean allow \u003d onKeyXXXPreview((char) DOM.eventGetKeyCode(event),\nKeyboardListenerCollection.getKeyboardModifiers(event)); return allow \u0026\u0026\n(eventTargetsPopup || !modal);\n\nThere are 8 logical combinations to deal with when deciding whether or not to\ncancel the event: \n\nonKeyXXXPreview | target within PopupPanel | Modal \u003d Do Not Cancel Event\ntrue | true | true  \u003d true\ntrue | true | false  \u003d true\ntrue | false | true  \u003d false\ntrue | false | false \u003d true\n\nfalse | true | true  \u003d false\nfalse | true | false  \u003d false\nfalse | false | true  \u003d false\nfalse | false | false  \u003d false\n\nIssue: 1316\nFound by: danielm777\nFixed by: jlabanca\nReview by: jgw\n\n\n\ngit-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@1241 8db76d5a-ed1c-0410-87a9-c151d255dfc7\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "430e3d334ea6bd6e0eaafa5b605d6e19a2138d4c",
      "old_mode": 33188,
      "old_path": "user/src/com/google/gwt/user/client/ui/PopupPanel.java",
      "new_id": "e42eada49067e9956d48513fdaa0c027df1e116c",
      "new_mode": 33188,
      "new_path": "user/src/com/google/gwt/user/client/ui/PopupPanel.java"
    }
  ]
}