commit 73744323310b2101fe093236ff0f7e837689bb91
author Daniel Kurka <dankurka@google.com> Sun Jun 30 15:11:55 2013 +0200
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Sun Jun 30 15:35:10 2013 +0000
tree 101953ea15f0c3b5dad2b508d05470162af305f4
parent 6941fb088129bced231d416ae5a20138ab2ff1c0

Let ValueListBox implement HasEnabled

fixes issue 6112

Change-Id: Ib866657960d0a3d41e0b3b1f08fa9a97091149a9

user/src/com/google/gwt/user/client/ui/ValueListBox.java

diff --git a/user/src/com/google/gwt/user/client/ui/ValueListBox.java b/user/src/com/google/gwt/user/client/ui/ValueListBox.java
index 1bdbdf8..61f6f85 100644
--- a/user/src/com/google/gwt/user/client/ui/ValueListBox.java
+++ b/user/src/com/google/gwt/user/client/ui/ValueListBox.java
@@ -42,7 +42,8 @@
  * @param <T> the value type
  */
 public class ValueListBox<T> extends Composite implements
-    Focusable, HasConstrainedValue<T>, IsEditor<TakesValueEditor<T>> {
+    Focusable, HasConstrainedValue<T>, HasEnabled,
+    IsEditor<TakesValueEditor<T>> {
 
   private final List<T> values = new ArrayList<T>();
   private final Map<Object, Integer> valueKeyToIndex = new HashMap<Object, Integer>();
@@ -97,6 +98,11 @@
     return value;
   }
 
+  @Override
+  public boolean isEnabled() {
+    return getListBox().isEnabled();
+  }
+
   public void setAcceptableValues(Collection<T> newValues) {
     values.clear();
     valueKeyToIndex.clear();
@@ -116,6 +122,11 @@
   }
 
   @Override
+  public void setEnabled(boolean enabled) {
+    getListBox().setEnabled(enabled);
+  }
+
+  @Override
   public void setFocus(boolean focused) {
     getListBox().setFocus(focused);
   }

user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java

diff --git a/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java b/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
index bc6384e..714de32 100644
--- a/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
+++ b/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
@@ -65,6 +65,14 @@
     return "com.google.gwt.user.User";
   }
 
+  public void testEnabled() {
+    subject.setEnabled(true);
+    assertTrue(subject.isEnabled());
+
+    subject.setEnabled(false);
+    assertFalse(subject.isEnabled());
+  }
+
   public void xx_testExtraValueSet() {  // TODO(rjrjr) Strange failures on firefox
     Foo[] values = new Foo[] {new Foo("able"), new Foo("baker")};
     Foo baz = new Foo("baz");