| commit | 86a1789cf9d92d9da59052d67e213193c39a3ab5 | [log] [tgz] |
|---|---|---|
| author | xtof@google.com <xtof@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> | Mon Jun 06 19:20:50 2011 +0000 |
| committer | xtof@google.com <xtof@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> | Mon Jun 06 19:20:50 2011 +0000 |
| tree | b45cdeb686fd4bd81cd7c04d02da18fbaa30435d | |
| parent | 77f5cee2df553c6e6a6ae069a5b4c6af6707ec17 [diff] |
Disable regex checking of URLs in SafeUriHostedModeUtils; this regex appears to cause stack overflows in some cases. Review at http://gwt-code-reviews.appspot.com/1443813 git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@10285 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java b/user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java index 597e63c..7b3dbe2 100644 --- a/user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java +++ b/user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
@@ -104,9 +104,11 @@ } private static boolean isValidUri(String uri) { - if (!uri.matches(HREF_UCSCHAR)) { - return false; - } + // TODO(xtof): The regex appears to cause stack overflows in some cases. + // Investigate and re-enable. + // if (!uri.matches(HREF_UCSCHAR)) { + // return false; + // } /* * pre-process to turn href-ucschars into ucschars, and encode to URI. *