gwt /
gwt /
87de65e18f8f5a12df2662013a192a03a696eb36 Completes the move of AttributeParsers from UiBinderWriter to XMLElement. Turns
out the consumeEnumAttribute call wasn't enum specific--it works for all types,
and has been renamed.
All custom parsers are visited to ensure that they are using unparsed raw
attribute values only if they really should.
CustomButtonParser is tweaked to user lower case names for its non-widget
children, as is the new convention. It also now allows (requires) ImageResource
references instead of raw URLs. Also get rid of its face element's silly,
redundant text and html attributes.
Parsing of attributes that hold multiple strings is now centralized in
XMLElement. This is particularly used by UiObjectParser--field references work
in addStyleNames and addDependentStyleNames. Such lists can be comma and/or
space separated.
Fixed some error reporting:
in HasWidgetsParser, to give useful message when bad stuff is stuffed into a
panel.
in MessagesWriter, to fail nicely if they try to make a {field.ref} a default
value for a localized message
Get rid of unnecessary DummyTreeLogger.
Ironically our unit testability suffers a bit as XMLElement becomes dependent on
TypeOracle. TypeOracle can be mocked, but I don't know how and don't have time
to learn this week.
Review by bobv
git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@6653 8db76d5a-ed1c-0410-87a9-c151d255dfc7
26 files changed
