commit 9187780c3b172d630fd8347c6710a697d58f9141
author juliog@google.com <juliog@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Fri May 13 15:01:50 2011 +0000
committer juliog@google.com <juliog@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Fri May 13 15:01:50 2011 +0000
tree 3c0c9c30828f5cdf5f10fb3d4070018042a76858
parent 248d3ab7e1ba50599820a7f5529977ad14361944

Attachable elements in UiBinder: always run logicalAdd(Attachable) for
Attachable widgets.

Before this patch, if we declared a <gwt:Attachable/> in the UiBinder template
and a corresponding @UiField(provided=true) field in the Java class, no event
handlers were attached to the widget.

This happened because of a check in UiBinder's AttachableInterpreter. It invoked
logicalAdd only if the field derived from IsWidget, which is not the case of
Attachable. As we were declaring it only as an Attachable, it did not run
logicalAdd over it, so the event handlers were not installed.

logicalAdd(Attachable) does all type checks necessary. This patch makes UiBinder always produce code to logicalAdd(Attachable) the widget declared as <gwt:Attachable/> in the template, which causes the event handlers to get attached correctly.

Review at http://gwt-code-reviews.appspot.com/1446801


git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@10182 8db76d5a-ed1c-0410-87a9-c151d255dfc7