)]}' { "commit": "a456f2e847e962cf520269bdca3a6b11ccc4863f", "tree": "a2ab13f8297db85866752595ff55cc539e238235", "parents": [ "be8e565d41a94c35ae472f808191794160c4abe3" ], "author": { "name": "gwt.team.mmendez", "email": "gwt.team.mmendez@8db76d5a-ed1c-0410-87a9-c151d255dfc7", "time": "Tue Jul 10 17:57:22 2007 +0000" }, "committer": { "name": "gwt.team.mmendez", "email": "gwt.team.mmendez@8db76d5a-ed1c-0410-87a9-c151d255dfc7", "time": "Tue Jul 10 17:57:22 2007 +0000" }, "message": "This commit addresses issues 1129, 1161, and 1163 and it includes some general \ncleanup.\n\nIssue 1129:\nThe fix is that if we are in a manually serialized type that uses Object or Object[]\nwe will consider all serializable subtypes of Object. Without being able to deal\nwith arrays dynamically and without giving additional information to CFS this is the\nbest that we can do. We should be able to handle this correctly in RPC v2.\n\nIssue 1161: \nWe only checked for native methods if the class was automatically serializable. \nSince all of our JRE classes with native methods use custom field serializers we\nnever saw the native method warning. When external developers added auto\nserializable types to the JRE they did get warnings. This patch will skip the check\nfor native methods if the type is part of our JRE emulation. We assume that all \ntypes whose package names begin with \"java.\" are part of our JRE. This does not \naccount for javax and org.* packages which are part of the real JRE.\n\nIssue 1163:\nThere were a few problems with this code. First, when generating a log message we\ndid not store whether or not it was a warning or an error. If the type was seen\nmultiple times, it was possible that what was previously a warning would be treated\nas an error.\n\nSecond, abstract classes that did not have any instantiable subtypes would be\nconsidered an error.\n\nGeneral cleanup:\nRemoved several warnings about assignment to parameters and member \nvisibility causing synthetic access methods to be generated. Updated the test code \nto remove work arounds for TypeSerializer exceptions which were no longer necessary.\n\nBased on scottb\u0027s review feedback, I renamed some of the test classes to clarify \nhow they are used. Fixed a couple of latent bugs where we were forcing abstract classes \nto be default instantiable. I moved the async interface validation code into the \nProxyCreator class since it is not really appropriate for STOB. Lastly, updated \nthe documentation for STOB to give more background on how it works.\n\nReview by: scottb\n\n\n\ngit-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@1228 8db76d5a-ed1c-0410-87a9-c151d255dfc7\n", "tree_diff": [ { "type": "modify", "old_id": "12e995f4409894a523a7b67d162ccb2112b96862", "old_mode": 33188, "old_path": "user/src/com/google/gwt/user/rebind/rpc/CustomFieldSerializerValidator.java", "new_id": "8f6684ea09123624c59c478c29b92872216626d6", "new_mode": 33188, "new_path": "user/src/com/google/gwt/user/rebind/rpc/CustomFieldSerializerValidator.java" }, { "type": "modify", "old_id": "e2f11c0e9461fb471703c5d66865856de852bd40", "old_mode": 33188, "old_path": "user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java", "new_id": "436d956fb56b2e3a0e54980f1d9a43e9c7756e67", "new_mode": 33188, "new_path": "user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java" }, { "type": "modify", "old_id": "bb46011123b63f76cb10d9503109a23a4c6c7494", "old_mode": 33188, "old_path": "user/src/com/google/gwt/user/rebind/rpc/RemoteServiceAsyncValidator.java", "new_id": "29ce7d3b37edd80978292670234fad088b42ca32", "new_mode": 33188, "new_path": "user/src/com/google/gwt/user/rebind/rpc/RemoteServiceAsyncValidator.java" }, { "type": "modify", "old_id": "fa01c3e56a5ae03aac762184f548ba2789fe6802", "old_mode": 33188, "old_path": "user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java", "new_id": "b6d404ff4ab05956a904bf969c7e744b9e7c94bf", "new_mode": 33188, "new_path": "user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java" }, { "type": "modify", "old_id": "63aed74e9eeb1c1874e1d977f0648306088379c6", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTest.java", "new_id": "26c1abe811378a968ae9ca4f5296bd5e3c2e6d7a", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTest.java" }, { "type": "modify", "old_id": "c486868ef175bacca751138d4110b433c84ba9fa", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTestService.java", "new_id": "e90d71e2a161d5c325dcfd6456e039ce0eff1635", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTestService.java" }, { "type": "modify", "old_id": "fa0b92d9685c58de6b664e8e07b49267ffa28e21", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTestServiceAsync.java", "new_id": "9260623460e4fbff72c97330b13ea9e91538b127", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTestServiceAsync.java" }, { "type": "modify", "old_id": "12613fecd466d9b47e87629672b566d4562be8a1", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTestSetFactory.java", "new_id": "a075066b6460c0721452cfa2988e7f3d14fef7d1", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTestSetFactory.java" }, { "type": "modify", "old_id": "21b0c3f0546d2d02ac9d22053c4fce6594b2b0ae", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTestSetValidator.java", "new_id": "0d16946ce6a04a1f82b17522c1c93e51721ad016", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTestSetValidator.java" }, { "type": "modify", "old_id": "8f180af25244c7d8469830075d74d973952b2880", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/InheritanceTest.java", "new_id": "4a87a104f0e1dd160804af3c4d0a128147522c3d", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/client/rpc/InheritanceTest.java" }, { "type": "modify", "old_id": "8e4f3094f41ba3a7c9adbb3cd8cd0852b6b9d60d", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/InheritanceTestService.java", "new_id": "dc401e1d07adc781b1527a26b53127fe1b6cc7aa", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/client/rpc/InheritanceTestService.java" }, { "type": "modify", "old_id": "f19010f54345842f10b8147a9109d40e39213c63", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/InheritanceTestServiceAsync.java", "new_id": "5630faaa99a7c7793571a3b3a9d679693e093aa0", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/client/rpc/InheritanceTestServiceAsync.java" }, { "type": "modify", "old_id": "4c1b4482484bee1c28980bccc4c5597c68df6a65", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/InheritanceTestSetFactory.java", "new_id": "f775a6987de441b5281ff05d5acece48a58e07f0", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/client/rpc/InheritanceTestSetFactory.java" }, { "type": "rename", "old_id": "69fef97ad0f34925d9c6aa6ff25e511f95c33206", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/UnserializableClass.java", "new_id": "2fa58ce63848c832871f02de381e8be3cfdcdb19", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/client/rpc/ManuallySerializedClass.java", "score": 97 }, { "type": "rename", "old_id": "db24d49898d3e3704a8c2eab125fd0d2db4a2527", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/UnserializableClass_CustomFieldSerializer.java", "new_id": "1c9531d292812064b7c04c15c36061f48c992c71", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/client/rpc/ManuallySerializedClass_CustomFieldSerializer.java", "score": 86 }, { "type": "delete", "old_id": "bbd85dcbd60180f085cfdb14ce1b812fb7e20f16", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/client/rpc/TypeSerializerWorkAround.java", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "addfbf91a3eccadad59c5914d01a97fd50cf47ef", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/server/rpc/CustomFieldSerializerTestServiceImpl.java", "new_id": "309702eb3b860c73eea65e60f23be3aaeda9a518", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/server/rpc/CustomFieldSerializerTestServiceImpl.java" }, { "type": "modify", "old_id": "ec64347e0293fcc847e0c77cea1eaf375414538e", "old_mode": 33188, "old_path": "user/test/com/google/gwt/user/server/rpc/InheritanceTestServiceImpl.java", "new_id": "77545dacc54d7368db8526555fccab6fdc921bc7", "new_mode": 33188, "new_path": "user/test/com/google/gwt/user/server/rpc/InheritanceTestServiceImpl.java" } ] }