Review by:jgw
Adds documentation for issue 316 to clarify that setSize,setWidth, and setHeight cannot use % values.
git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@1554 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/user/src/com/google/gwt/user/client/ui/ScrollPanel.java b/user/src/com/google/gwt/user/client/ui/ScrollPanel.java
index 2cc275f..1cc47c9 100644
--- a/user/src/com/google/gwt/user/client/ui/ScrollPanel.java
+++ b/user/src/com/google/gwt/user/client/ui/ScrollPanel.java
@@ -32,8 +32,8 @@
public ScrollPanel() {
setAlwaysShowScrollBars(false);
sinkEvents(Event.ONSCROLL);
-
- // Prevent IE standard mode bug when a AbsolutePanel is contained.
+
+ // Prevent IE standard mode bug when a AbsolutePanel is contained.
DOM.setStyleAttribute(getElement(), "position", "relative");
}
@@ -112,6 +112,18 @@
}
/**
+ * Sets the object's height. This height does not include decorations such as
+ * border, margin, and padding.
+ *
+ * @param height the object's new height, in absolute CSS units (e.g. "10px",
+ * "1em" but not "50%")
+ */
+ @Override
+ public void setHeight(String height) {
+ super.setHeight(height);
+ }
+
+ /**
* Sets the horizontal scroll position.
*
* @param position the new horizontal scroll position, in pixels
@@ -129,6 +141,32 @@
DOM.setElementPropertyInt(getElement(), "scrollTop", position);
}
+ /**
+ * Sets the object's size. This size does not include decorations such as
+ * border, margin, and padding.
+ *
+ * @param width the object's new width, in absolute CSS units (e.g. "10px",
+ * "1em", but not "50%")
+ * @param height the object's new height, in absolute CSS units (e.g. "10px",
+ * "1em", but not "50%")
+ */
+ @Override
+ public void setSize(String width, String height) {
+ super.setSize(width, height);
+ }
+
+ /**
+ * Sets the object's width. This width does not include decorations such as
+ * border, margin, and padding.
+ *
+ * @param width the object's new width, in absolute CSS units (e.g. "10px",
+ * "1em", but not "50%")
+ */
+ @Override
+ public void setWidth(String width) {
+ super.setWidth(width);
+ }
+
private native void ensureVisibleImpl(Element scroll, Element e) /*-{
if (!e)
return;
@@ -142,4 +180,5 @@
scroll.scrollTop = realOffset - scroll.offsetHeight / 2;
}-*/;
+
}
