Adds more logging to JUnitShell. The redundant logging will be removed later.
Patch by: amitmanjhi
Review by: scottb, jat
git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@8283 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/dev/core/src/com/google/gwt/core/ext/ServletContainerLauncher.java b/dev/core/src/com/google/gwt/core/ext/ServletContainerLauncher.java
index 5d5e87a..c599507 100644
--- a/dev/core/src/com/google/gwt/core/ext/ServletContainerLauncher.java
+++ b/dev/core/src/com/google/gwt/core/ext/ServletContainerLauncher.java
@@ -70,6 +70,7 @@
* @return true if the arguments were processed successfully
*/
public boolean processArguments(TreeLogger logger, String arguments) {
+ logger.log(TreeLogger.ERROR, getName() + " does not accept any arguments");
return false;
}
diff --git a/dev/core/src/com/google/gwt/dev/DevModeBase.java b/dev/core/src/com/google/gwt/dev/DevModeBase.java
index 3d21bc9..2867cf0 100644
--- a/dev/core/src/com/google/gwt/dev/DevModeBase.java
+++ b/dev/core/src/com/google/gwt/dev/DevModeBase.java
@@ -1047,12 +1047,23 @@
started = true;
if (!doStartup()) {
+ /*
+ * TODO (amitmanjhi): Adding this redundant logging to narrow down a
+ * failure. Remove soon.
+ */
+ getTopLogger().log(TreeLogger.ERROR, "shell failed in doStartup method");
return false;
}
if (!options.isNoServer()) {
int resultPort = doStartUpServer();
if (resultPort < 0) {
+ /*
+ * TODO (amitmanjhi): Adding this redundant logging to narrow down a
+ * failure. Remove soon.
+ */
+ getTopLogger().log(TreeLogger.ERROR,
+ "shell failed in doStartupServer method");
return false;
}
options.setPort(resultPort);
@@ -1074,6 +1085,12 @@
setStartupUrls(getTopLogger());
if (!doSlowStartup()) {
+ /*
+ * TODO (amitmanjhi): Adding this redundant logging to narrow down a
+ * failure. Remove soon.
+ */
+ getTopLogger().log(TreeLogger.ERROR,
+ "shell failed in doSlowStartup method");
return false;
}
