)]}' { "commit": "c4643f0ed90f1c48c471e3c0b987c57fc5056f6c", "tree": "50b2791298b708696cd5e9b11f05fbd78208ec9e", "parents": [ "8a777b11edf8977c4a431f74b3cead2824005a12" ], "author": { "name": "rjrjr@google.com", "email": "rjrjr@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7", "time": "Mon Nov 02 20:47:15 2009 +0000" }, "committer": { "name": "rjrjr@google.com", "email": "rjrjr@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7", "time": "Mon Nov 02 20:47:15 2009 +0000" }, "message": "Moving AttributeParsers to XMLElement, where they belong.\n\nThis is a pretty major refactoring, and it\u0027s not done yet. Management of the\nAttributeParser and the BundleAttributeParsers is now in dedicated classes.\nXMLElement has access to them, and uses them for Boolean and Double values. All\nother parsing is still going through old calls through UiBinderWriter to the new\nmanagers, for now.\n\nOf particular note: there are now many fewer direct dependencies on\nUiBinderWriter, and much more DI style injection of logging and other services.\nAlso, dummy loggers are introduced to eliminate console noise from unit tests.\n\nNext steps are making ComputedAttributeParser use the new game (and in the\nprocess tidy its fix for currently broken {{ escaping), and making the new\nLayoutPanelParsers get their enum values in the new style. Then on to strings.\n\nReview by: hermes@google.com\n\ngit-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@6589 8db76d5a-ed1c-0410-87a9-c151d255dfc7\n", "tree_diff": [ { "type": "modify", "old_id": "0e91b943f62b91d90d5c19199fbf72f1e865c8dd", "old_mode": 33188, "old_path": "user/src/com/google/gwt/junit/JUnitShell.java", "new_id": "edd5f1604c9c49355846be73467f894f1f3de14f", "new_mode": 33188, "new_path": "user/src/com/google/gwt/junit/JUnitShell.java" }, { "type": "modify", "old_id": "a39a7792c9642f694f31b6cccd10647b8f19ef5f", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/AttributeParser.java", "new_id": "c4d383a3cc3d01fee0801424dea2a41bd49beb12", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/AttributeParser.java" }, { "type": "modify", "old_id": "ebb4fce172f3057eaf9e0a75083ad98aa172aa7e", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/BeanParser.java", "new_id": "cf6708d4a0c167ef6ef0240e68337646b364d72e", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/BeanParser.java" }, { "type": "modify", "old_id": "6179dfa31125eb83bcceab8486ed12589dfdacb0", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/BooleanAttributeParser.java", "new_id": "22db05942b80126588076ef087e1e06cc3904323", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/BooleanAttributeParser.java" }, { "type": "modify", "old_id": "37a2d9298f985b5c630dbb34b6b38ce46a459222", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/BundleAttributeParser.java", "new_id": "811fd8515916c90272ac4a579fcbceee787ad750", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/BundleAttributeParser.java" }, { "type": "modify", "old_id": "4bdede2a3605b0d03a223955f25db81cade978a6", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/CellPanelParser.java", "new_id": "404aadae10a8fa1bf6a3eba33c60fe795dec05d5", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/CellPanelParser.java" }, { "type": "modify", "old_id": "3ce52faeb28ab6b60785722903ee5c590a233475", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/ComputedAttributeInterpreter.java", "new_id": "b483249757e38682e7e2e1ec84880a60fd6962ea", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/ComputedAttributeInterpreter.java" }, { "type": "modify", "old_id": "70c428bcdbcbf26cc893277ba9aa29e2c36870bd", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/CustomButtonParser.java", "new_id": "e5ef60e5edca1c88ea4a67b6ab7ce2279fc60281", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/CustomButtonParser.java" }, { "type": "modify", "old_id": "690c927d492471c80c70309a645b88ccf4e6c262", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/DisclosurePanelParser.java", "new_id": "9cf50199496f40fc28bc1e1eefabdbe7ca8ca912", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/DisclosurePanelParser.java" }, { "type": "modify", "old_id": "face22a9fbb05605a15eabeddea1f85febdb798f", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/DockLayoutPanelParser.java", "new_id": "2ce28a58423b12d1bbb02646f1dc00f49f60eef6", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/DockLayoutPanelParser.java" }, { "type": "modify", "old_id": "45b7dea51f33ac90f6c9a774b136e286fa66dee6", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/DockPanelParser.java", "new_id": "c67f073e2f44534cb3c8acfa153cb8ded537a7ab", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/DockPanelParser.java" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "056bfd29b022c254215fec1aa740328ca020c1fb", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/DoubleAttributeParser.java" }, { "type": "modify", "old_id": "20c51335aa6e13be735d13a9fd5a7d956b4bcfe9", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/FieldInterpreter.java", "new_id": "3f0143e427587f358df63de2fe11a327b4b6a44d", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/FieldInterpreter.java" }, { "type": "modify", "old_id": "6aba4e778d18f058b6d1d3a55f328741317b321d", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/HTMLPanelParser.java", "new_id": "ce63d2f5e51a7a7b3a6ab12dba13a7537a105065", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/HTMLPanelParser.java" }, { "type": "modify", "old_id": "6352e9d5a7ae430e10299cd98c6df08a269c1a6e", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/HorizontalAlignmentConstantParser.java", "new_id": "b70b717b5bbc3deef703b974d111f2e84f55831a", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/HorizontalAlignmentConstantParser.java" }, { "type": "rename", "old_id": "924b1da3d98c1662673cb8ebf78a67983856b44b", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/IntParser.java", "new_id": "dbb11bc8d62ff8a27139c31bb0f75b90c7bc7e23", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/IntAttributeParser.java", "score": 65 }, { "type": "modify", "old_id": "070718c62bbb8e8506b9aa27c43eece54f8931f7", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/IntPairParser.java", "new_id": "beb078fb60476228ab93c203a659d0eec03094c5", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/IntPairParser.java" }, { "type": "modify", "old_id": "2d1cedc7a2310721981ddcc01529150517b07c78", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/MenuBarParser.java", "new_id": "448b9eecbd53ec5f3ece1d70524b56c01ea20eb2", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/MenuBarParser.java" }, { "type": "modify", "old_id": "0c8d6d6d05579a8efa88ad8632617093ff47b4d2", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/RadioButtonParser.java", "new_id": "5ca789f1cbaa764a8b827cfa064770bddc1a09ec", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/RadioButtonParser.java" }, { "type": "delete", "old_id": "4ba503eeaf2ebe61ad83dece875742164939e616", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/SimpleAttributeParser.java", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "58feb85e3c41e39d7bfe18da141a4b4199701905", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/StackLayoutPanelParser.java", "new_id": "85e126192683ab9d2f32f7047cb445ff13b47633", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/StackLayoutPanelParser.java" }, { "type": "modify", "old_id": "2897280d0da29c86cfee2126bc3436cf10ab4f92", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/StackPanelParser.java", "new_id": "3d3870412f49c050ea8169faaa4372b5a0e7dc98", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/StackPanelParser.java" }, { "type": "modify", "old_id": "4285c8aabfb393221c46fbd9ed832afda33b6b98", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/StrictAttributeParser.java", "new_id": "18acbc738c649cd899642cfc2c677b6b722a99d0", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/StrictAttributeParser.java" }, { "type": "modify", "old_id": "4261ec6d7e8377b09fe5592f6c2baba608b0873e", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/StringAttributeParser.java", "new_id": "8e4de2b94cf2ef1593892c9331703be4452dbb19", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/StringAttributeParser.java" }, { "type": "modify", "old_id": "18dc393560018e311c06eb42476975b05c9f7aa9", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/TabLayoutPanelParser.java", "new_id": "3d0e42c3ff3240205a2eb412e6e80d81f7de0e5d", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/TabLayoutPanelParser.java" }, { "type": "modify", "old_id": "728d1844e22fd1c71f071e511302f52747a9f856", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/TabPanelParser.java", "new_id": "ae17c34776077e6276f40484bdd35f0292a894df", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/TabPanelParser.java" }, { "type": "modify", "old_id": "4ce0858af1db745872cdda2851931e35baaaf8de", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/UIObjectParser.java", "new_id": "d2a0d372a4fc5a999d1d25b790526b94f973dad1", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/UIObjectParser.java" }, { "type": "modify", "old_id": "70ba1ca9a87eee9fc03580d2a21cc80e78e6fa2b", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/parsers/VerticalAlignmentConstantParser.java", "new_id": "6a7fcada0b03c5a13dc63415719b0be591e533c2", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/parsers/VerticalAlignmentConstantParser.java" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "b5c65d8ed92708d1929e130b319206a268b85b2c", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/rebind/AttributeParsers.java" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "ad8fcbc847084f54ef37832942f8594e774145a0", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/rebind/BundleAttributeParsers.java" }, { "type": "modify", "old_id": "d3de4346374c37cc5755dd89dab94e5e79a5d26f", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/rebind/GetEscapedInnerTextVisitor.java", "new_id": "24cf27c763f1b0fdee08ae50c13d9466d400273c", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/rebind/GetEscapedInnerTextVisitor.java" }, { "type": "modify", "old_id": "79ab82af83edc679a039a3dfcc5da85ec3915e96", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/rebind/GetInnerHtmlVisitor.java", "new_id": "4eae5ddec080bb621b99cf088a4590a1bb2a88c4", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/rebind/GetInnerHtmlVisitor.java" }, { "type": "modify", "old_id": "e746a4428c9ad9bf2639d3a474f12fe61b7c9d5f", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java", "new_id": "689665ee8079f4321ded32a237935b011665708d", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java" }, { "type": "modify", "old_id": "7879c230191a504e0274dd70ec6fa0d560818334", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java", "new_id": "e094e7e46b063ea6246ae7d8787211735d5f33b9", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java" }, { "type": "modify", "old_id": "c0a381885dff1dda98c3d8259a36190ff78e3dca", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/rebind/XMLAttribute.java", "new_id": "811a91f757ffc23657316d1c83224b08079eaaa6", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/rebind/XMLAttribute.java" }, { "type": "modify", "old_id": "9ef746178ae8a027054e2ec287f2367bed7af8da", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/rebind/XMLElement.java", "new_id": "6e9babc02989e7ccc53339c939ae0dbd1de1c0e8", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/rebind/XMLElement.java" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "7e4745175771fef1facce508c775880416e874a3", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/rebind/XMLElementProvider.java" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "a3576f696ed4983c1964f67dd867a971172043e9", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/rebind/XMLElementProviderImpl.java" }, { "type": "modify", "old_id": "d99ff50bc4e8575349bd860567ac46590a7b2cf5", "old_mode": 33188, "old_path": "user/src/com/google/gwt/uibinder/rebind/messages/MessagesWriter.java", "new_id": "f9f424806fac12e517c189735e999cae628aaf9b", "new_mode": 33188, "new_path": "user/src/com/google/gwt/uibinder/rebind/messages/MessagesWriter.java" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "8ad61c4cb0917b9ee7d523e3d2920cce9814bb14", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/All.java" }, { "type": "modify", "old_id": "1d0fff2f551f6e8ab7fcadd61df4cbd7f954b32f", "old_mode": 33188, "old_path": "user/test/com/google/gwt/uibinder/UiBinderGwtSuite.java", "new_id": "6bd28efc6c5e36fbb0d39daa60727b93ac91853e", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/UiBinderGwtSuite.java" }, { "type": "modify", "old_id": "428590be36e888e6f02ef7cac61132046db6aae0", "old_mode": 33188, "old_path": "user/test/com/google/gwt/uibinder/UiBinderJreSuite.java", "new_id": "a59d7e241bf6da0e379aa15bfd0d953084506ad5", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/UiBinderJreSuite.java" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "f4f8d5c0fba5bccc2abf184c4e2d58094c12b1eb", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/parsers/IntAttributeParserTest.java" }, { "type": "delete", "old_id": "acd91e10280b6aa7f473630e39ed6eed3ce06458", "old_mode": 33188, "old_path": "user/test/com/google/gwt/uibinder/parsers/SimpleAttributeParserTest.java", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "65a130fbe773e61760d06ae86d36db7c9feef0f1", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/rebind/DummyMortalLogger.java" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "061d635f9edeb0529b96996459c910e63665e7d4", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/rebind/DummyTreeLogger.java" }, { "type": "modify", "old_id": "bdaaaa189e6f252e345610f22f88841cb0ebb29f", "old_mode": 33188, "old_path": "user/test/com/google/gwt/uibinder/rebind/XMLElementTest.java", "new_id": "28f20c9a1337cbcb7a6aee65961cfc7823a89e60", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/rebind/XMLElementTest.java" }, { "type": "modify", "old_id": "fd4e161b2a75cc09ea654c8aecaf3e587b529e3e", "old_mode": 33188, "old_path": "user/test/com/google/gwt/uibinder/rebind/model/OwnerClassTest.java", "new_id": "68756b6fed8518e253e7c81d98f4e8a8b2520bff", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/rebind/model/OwnerClassTest.java" }, { "type": "modify", "old_id": "5477c02ec0af76787e5822464f6ff8ca20269716", "old_mode": 33188, "old_path": "user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java", "new_id": "7746a020fd4b604cb5c2a35b322086bda1ea165e", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java" }, { "type": "modify", "old_id": "37a77e419c5aa69ec0f4ec8ee35254610c39928d", "old_mode": 33188, "old_path": "user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldTest.java", "new_id": "c34347fca06f870f4854950d9bc44ff8a4f70f3c", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldTest.java" }, { "type": "modify", "old_id": "c58c289898840c656b8e17e0509268aced848bec", "old_mode": 33188, "old_path": "user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java", "new_id": "465ff75b1f48fc8758ef72e9c7dc23429f2684e5", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java" }, { "type": "modify", "old_id": "c819f6b1fd51ea611bc2ad05c5a243d71b854ba8", "old_mode": 33188, "old_path": "user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java", "new_id": "39500f2d56ff5d7074ea25c1ca8f97739a18462c", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java" }, { "type": "modify", "old_id": "ada70ec7b06a73be0a4c5ca39df6fa648cca9b7f", "old_mode": 33188, "old_path": "user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml", "new_id": "9c3ed83d46e365d7676be8dfdd154ffee21e3ca0", "new_mode": 33188, "new_path": "user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml" } ] }