Fixing maven example pom files with sourceLevel 8
Since 2.8 needs sourceLevel set to 1.8 or auto, we have to
define sourceLevel to avoid gwt-maven-plugin selecting an
an incorrect value.
Change-Id: I2059f3b84dadede5c0de5a05c0edc3dba250b034
diff --git a/samples/dynatablerf/pom.xml b/samples/dynatablerf/pom.xml
index 8ba1316..b68d432 100644
--- a/samples/dynatablerf/pom.xml
+++ b/samples/dynatablerf/pom.xml
@@ -15,7 +15,9 @@
<!-- Convenience property to set the GWT version -->
<gwt.version>2.8.0-SNAPSHOT</gwt.version>
- <!-- GWT needs at least java 1.7 -->
+ <!-- Setting maven.compiler.source to something different to 1.8
+ needs that you configure the sourceLevel in gwt-maven-plugin since
+ GWT 2.8 requires 1.8 (see gwt-maven-plugin block below) -->
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
@@ -129,6 +131,10 @@
<moduleName>com.google.gwt.sample.dynatablerf.DynaTableRf</moduleName>
<moduleShortName>DynaTableRf</moduleShortName>
<failOnError>true</failOnError>
+ <!-- GWT and Java Compilers might not use the same source language.
+ GWT 2.8 requires 1.8, hence define sourceLevel here if you use
+ a different source language for java compilation -->
+ <sourceLevel>1.8</sourceLevel>
<!-- Compiler configuration -->
<compilerArgs>
<!-- Ask GWT to create the Story of Your Compile (SOYC) (gwt:compile) -->
diff --git a/samples/mobilewebapp/pom.xml b/samples/mobilewebapp/pom.xml
index 5c57299..8517f57 100644
--- a/samples/mobilewebapp/pom.xml
+++ b/samples/mobilewebapp/pom.xml
@@ -13,8 +13,12 @@
<!-- Convenience property to set the GWT version -->
<gwt.version>2.8.0-SNAPSHOT</gwt.version>
- <!-- GWT needs at least java 1.7 -->
+ <!-- Setting maven.compiler.source to something different to 1.8
+ needs that you configure the sourceLevel in gwt-maven-plugin since
+ GWT 2.8 requires 1.8 (see gwt-maven-plugin block below) -->
<maven.compiler.source>1.7</maven.compiler.source>
+ <!-- This is an appengine webapp, so it must generate Java 7 classes
+ https://cloud.google.com/appengine/docs/java/tools/maven#java_requirements -->
<maven.compiler.target>1.7</maven.compiler.target>
<!-- App Engine properties -->
@@ -196,6 +200,9 @@
<moduleName>com.google.gwt.sample.mobilewebapp.MobileWebApp</moduleName>
<moduleShortName>MobileWebApp</moduleShortName>
<failOnError>true</failOnError>
+ <!-- GWT 2.8 requires 1.8, hence define sourceLevel here if you use
+ a different source language for java compilation -->
+ <sourceLevel>1.8</sourceLevel>
<!-- Compiler configuration -->
<compilerArgs>
<!-- Ask GWT to create the Story of Your Compile (SOYC) (gwt:compile) -->
diff --git a/samples/validation/pom.xml b/samples/validation/pom.xml
index 520da29..e050657 100644
--- a/samples/validation/pom.xml
+++ b/samples/validation/pom.xml
@@ -13,7 +13,9 @@
<!-- Convenience property to set the GWT version -->
<gwt.version>2.8.0-SNAPSHOT</gwt.version>
- <!-- GWT needs at least java 1.7 -->
+ <!-- Setting maven.compiler.source to something different to 1.8
+ needs that you configure the sourceLevel in gwt-maven-plugin since
+ GWT 2.8 requires 1.8 (see gwt-maven-plugin block below) -->
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
@@ -134,6 +136,9 @@
<moduleName>com.google.gwt.sample.validation.Validation</moduleName>
<moduleShortName>Validation</moduleShortName>
<failOnError>true</failOnError>
+ <!-- GWT compiler 2.8 requires 1.8, hence define sourceLevel here if you use
+ a different source language for java compilation -->
+ <sourceLevel>1.8</sourceLevel>
<!-- Compiler configuration -->
<compilerArgs>
<!-- Ask GWT to create the Story of Your Compile (SOYC) (gwt:compile) -->
diff --git a/user/src/com/google/gwt/user/tools/templates/maven/pom.xmlsrc b/user/src/com/google/gwt/user/tools/templates/maven/pom.xmlsrc
index 8a506bb..f79163a 100644
--- a/user/src/com/google/gwt/user/tools/templates/maven/pom.xmlsrc
+++ b/user/src/com/google/gwt/user/tools/templates/maven/pom.xmlsrc
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<!-- POM file generated with GWT webAppCreator -->
@@ -9,11 +9,14 @@
<packaging>war</packaging>
<version>1.0-SNAPSHOT</version>
<name>@moduleName</name>
-
+
<properties>
- <!-- Note: GWT needs at least java 1.7 -->
- <maven.compiler.source>1.7</maven.compiler.source>
- <maven.compiler.target>1.7</maven.compiler.target>
+
+ <!-- Setting maven.compiler.source to something different to 1.8
+ needs that you configure the sourceLevel in gwt-maven-plugin since
+ GWT compiler 2.8 requires 1.8 (see gwt-maven-plugin block below) -->
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
<!-- Don't let your Mac use a crazy non-standard encoding -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
@@ -56,13 +59,13 @@
<scope>test</scope>
</dependency>
</dependencies>
-
+
<build>
<!-- Output classes directly into the webapp, so that IDEs and "mvn process-classes" update them in DevMode -->
<outputDirectory>${project.build.directory}/${project.build.finalName}/WEB-INF/classes</outputDirectory>
<plugins>
-
+
<!-- GWT Maven Plugin-->
<plugin>
<groupId>net.ltgt.gwt.maven</groupId>
@@ -82,6 +85,9 @@
<moduleName>@moduleName</moduleName>
<moduleShortName>@moduleShortName</moduleShortName>
<failOnError>true</failOnError>
+ <!-- GWT compiler 2.8 requires 1.8, hence define sourceLevel here if you use
+ a different source language for java compilation -->
+ <sourceLevel>1.8</sourceLevel>
<!-- Compiler configuration -->
<compilerArgs>
<!-- Ask GWT to create the Story of Your Compile (SOYC) (gwt:compile) -->
