commit dcaf355d92e6660954c5f030e6dc2f67d13b84c6
author gwt.team.mmendez <gwt.team.mmendez@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Fri Mar 21 05:19:04 2008 +0000
committer gwt.team.mmendez <gwt.team.mmendez@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Fri Mar 21 05:19:04 2008 +0000
tree 35e1825a73a5852beed0f0dd74f1a15a6094ab2a
parent 6e015f808e5cb2c16427705490e69c57f1222ef0

Fixes problems introduced by the original fix to issue 1830 committed at r1944.  It modified AbstractCompiler to satisfy INameEnvironment.findType requests with a .class file if we could not locate source code for the requested type.  However, this change had several bad side effects if you referenced a binary type outside the context of an annotation or if you forgot to add a inherits to your GWT module XML file:

* TypeOracleBuilder would fail to fully resolve types which could result in NPEs in generators.
* GWTCompiler would generate ICEs if it ever encountered a binary type as part of its compilation.

This change adds a visitor to AbstractCompiler.CompilerImpl.process(CompilationUnitDeclaration, int) which scans the compilation unit for binary type refrences outside the context of an annotation.  If it finds any, it will record the problem against the compilation unit as a normal JDT error.

Review by: scottb

git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@2191 8db76d5a-ed1c-0410-87a9-c151d255dfc7