commit efc9a6e2652fd11c42b323e7b3c7c061968c3e60
author gwt.team.rdayal <gwt.team.rdayal@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Fri Feb 23 17:08:02 2007 +0000
committer gwt.team.rdayal <gwt.team.rdayal@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Fri Feb 23 17:08:02 2007 +0000
tree b73c53c92953999884e9141e70c3440b1f437d28
parent 57b44c4726c742508ca1d5c22105e0769fbf5588

Fix issue #328: To prevent 'null' from being displayed in Safari and Opera when we call setInnerText on an Element with a value of null, do not create new text node when the incoming string has a null value. Has the side-effect of no longer creating an empty text node in firefox.
Patch by: sandymac
Review by: knorton


git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@449 8db76d5a-ed1c-0410-87a9-c151d255dfc7

user/src/com/google/gwt/user/client/impl/DOMImpl.java

diff --git a/user/src/com/google/gwt/user/client/impl/DOMImpl.java b/user/src/com/google/gwt/user/client/impl/DOMImpl.java
index 8382056..5b19508 100644
--- a/user/src/com/google/gwt/user/client/impl/DOMImpl.java
+++ b/user/src/com/google/gwt/user/client/impl/DOMImpl.java
@@ -315,7 +315,9 @@
       elem.removeChild(elem.firstChild);
     }
     // Add a new text node.
-    elem.appendChild($doc.createTextNode(text));
+    if (text != null) {
+      elem.appendChild($doc.createTextNode(text));
+    }
   }-*/;
 
   public native void setIntAttribute(Element elem, String attr, int value) /*-{