Fix warnings in samples/expenses

Review at http://gwt-code-reviews.appspot.com/1447810

Review by: jlabanca@google.com

git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@10243 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/samples/expenses/src/main/java/com/google/gwt/mobile/client/TouchHandler.java b/samples/expenses/src/main/java/com/google/gwt/mobile/client/TouchHandler.java
index 78bff27..74effb7 100644
--- a/samples/expenses/src/main/java/com/google/gwt/mobile/client/TouchHandler.java
+++ b/samples/expenses/src/main/java/com/google/gwt/mobile/client/TouchHandler.java
@@ -415,12 +415,10 @@
       scrollOffTimer.schedule(100);
     }
 
-    boolean firstDrag = false;
     if (!dragging) {
       if (totalMoveY > MIN_TRACKING_FOR_DRAG
           || totalMoveX > MIN_TRACKING_FOR_DRAG) {
         dragging = true;
-        firstDrag = true;
         dragDelegate.onDragStart(e);
       }
     }
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.java
index 0fcb598..5b0d883 100644
--- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.java
+++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.java
@@ -42,7 +42,6 @@
 import com.google.gwt.i18n.client.NumberFormat;
 import com.google.gwt.resources.client.ImageResource;
 import com.google.gwt.safehtml.client.SafeHtmlTemplates;
-import com.google.gwt.safehtml.client.SafeHtmlTemplates.Template;
 import com.google.gwt.safehtml.shared.SafeHtml;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
 import com.google.gwt.safehtml.shared.SafeHtmlUtils;
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java
index c0dd528..3d2fffd 100644
--- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java
+++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java
@@ -22,7 +22,6 @@
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.dom.client.Style.Overflow;
 import com.google.gwt.safehtml.client.SafeHtmlTemplates;
-import com.google.gwt.safehtml.client.SafeHtmlTemplates.Template;
 import com.google.gwt.safehtml.shared.SafeHtml;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
 import com.google.gwt.sample.expenses.client.style.Styles;
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java
index f087fcc..a32fb80 100644
--- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java
+++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java
@@ -18,7 +18,6 @@
 import com.google.gwt.cell.client.AbstractCell;
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.safehtml.client.SafeHtmlTemplates;
-import com.google.gwt.safehtml.client.SafeHtmlTemplates.Template;
 import com.google.gwt.safehtml.shared.SafeHtml;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
 import com.google.gwt.sample.expenses.shared.ExpenseProxy;
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/PhaseAnimation.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/PhaseAnimation.java
index fa4b588..d047ce0 100644
--- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/PhaseAnimation.java
+++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/PhaseAnimation.java
@@ -59,12 +59,12 @@
 
     @Override
     protected T getDisplayedItem(int index) {
-      return cellList.getDisplayedItem(index);
+      return cellList.getVisibleItem(index);
     }
 
     @Override
     protected List<T> getDisplayedItems() {
-      return cellList.getDisplayedItems();
+      return cellList.getVisibleItems();
     }
 
     @Override
@@ -97,12 +97,12 @@
 
     @Override
     protected T getDisplayedItem(int index) {
-      return cellTable.getDisplayedItem(index);
+      return cellTable.getVisibleItem(index);
     }
 
     @Override
     protected List<T> getDisplayedItems() {
-      return cellTable.getDisplayedItems();
+      return cellTable.getVisibleItems();
     }
 
     @Override
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/SlidingPanel.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/SlidingPanel.java
index 0cc5a51..7fe60f3 100644
--- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/SlidingPanel.java
+++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/SlidingPanel.java
@@ -90,6 +90,7 @@
    * Set the widget to show, adding it to the end of our sliding set if we
    * haven't seen it before. Nulls are ignored.
    */
+  @SuppressWarnings("deprecation")
   // Conflict btw deprecated Composite#setWidget and HasOneWidget#setWidget
   @Override
   public void setWidget(Widget widget) {
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/EntityCounter.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/EntityCounter.java
index 84795ec..b90b8aa 100644
--- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/EntityCounter.java
+++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/domain/EntityCounter.java
@@ -47,7 +47,7 @@
 
   private static final Long ZERO = Long.valueOf(0L);
 
-  private static final boolean DENSE_IDS = false;
+//  private static final boolean DENSE_IDS = false;
 
   public static final EntityManager entityManager() {
     return EMF.get().createEntityManager();
@@ -167,10 +167,10 @@
             + mmin + " and id < " + mmax;
         Number count = (Number) em.createQuery(query).getSingleResult();
         long value = count.longValue();
-        if (value == 0 && DENSE_IDS) {
-          log.info("Got 0 results between " + mmin + " and " + mmax);
-          break;
-        }
+//        if (value == 0 && DENSE_IDS) {
+//          log.info("Got 0 results between " + mmin + " and " + mmax);
+//          break;
+//        }
 
         mmin = mmax;
         min = Long.valueOf(mmin);
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthRequestTransport.java b/samples/expenses/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthRequestTransport.java
index 9d7e408..e10eb5e 100644
--- a/samples/expenses/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthRequestTransport.java
+++ b/samples/expenses/src/main/java/com/google/gwt/sample/gaerequest/client/GaeAuthRequestTransport.java
@@ -20,7 +20,6 @@
 import com.google.gwt.http.client.RequestCallback;
 import com.google.gwt.http.client.Response;
 import com.google.web.bindery.requestfactory.gwt.client.DefaultRequestTransport;
-import com.google.web.bindery.requestfactory.shared.RequestTransport.TransportReceiver;
 import com.google.web.bindery.requestfactory.shared.ServerFailure;
 
 /**