commit f4d40ecb7d6a3ac94455c6d199f2a5d4ce357896
author konigsberg@google.com <konigsberg@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Mon Aug 29 13:23:59 2011 +0000
committer konigsberg@google.com <konigsberg@google.com@8db76d5a-ed1c-0410-87a9-c151d255dfc7> Mon Aug 29 13:23:59 2011 +0000
tree c7c7831aba554bdb246072be512f30ad85ce0c0f
parent 72ea86fa6ff923553bb0ea88fb91bb4253fdedef

Trying to generate an ImageResource yields NPE, but not where it should, and
hey, look at that assert that you think won't really be called. I called it!

Add the resource name which is wicked helpful.

Review by: fabbott@google.com

git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@10591 8db76d5a-ed1c-0410-87a9-c151d255dfc7

user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java

diff --git a/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java b/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
index 6d38fb6..4509439 100644
--- a/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
+++ b/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
@@ -471,7 +471,9 @@
     ImageResourceDeclaration image = new ImageResourceDeclaration(method);
     DisplayedImage bundle = getImage(image);
     ImageRect rect = bundle.getImageRect(image);
-    assert rect != null : "No ImageRect ever computed for " + name;
+    if (rect == null) {
+      throw new NullPointerException("No ImageRect ever computed for " + name);
+    }
 
     String[] urlExpressions =
         new String[] {bundle.getNormalContentsFieldName(), bundle.getRtlContentsFieldName()};