commit 034abe71ec9008d7cc9ff48aab508535b72ae5dc
author Goktug Gokdogan <goktug@google.com> Thu Sep 21 20:31:19 2017 -0700
committer Goktug Gokdogan <goktug@google.com> Fri Sep 22 19:24:00 2017 +0000
tree e20795d51fbf8c14e4360b2ecc33b5e8284c804d
parent 06545878da19214fd29bddc9a1a9411938ab1680

Remove window.console reference from ConsoleLogger.

This is causing issues with users using GWT w/ node.js [1] and
also caused issues with SDM earlier.

[1] https://github.com/google/closure-compiler-js/issues/77

Bug: #9412
Bug-Link: https://github.com/gwtproject/gwt/issues/9412

Change-Id: I4e0e5d6c04560d6dd4776eeb386c5a811b1cf8a2

user/super/com/google/gwt/emul/javaemul/internal/ConsoleLogger.java

diff --git a/user/super/com/google/gwt/emul/javaemul/internal/ConsoleLogger.java b/user/super/com/google/gwt/emul/javaemul/internal/ConsoleLogger.java
index 0f30941..ea5a530 100644
--- a/user/super/com/google/gwt/emul/javaemul/internal/ConsoleLogger.java
+++ b/user/super/com/google/gwt/emul/javaemul/internal/ConsoleLogger.java
@@ -24,7 +24,7 @@
  */
 public class ConsoleLogger {
   public static ConsoleLogger createIfSupported() {
-    return getConsole() != null ? new ConsoleLogger() : null;
+    return JsUtils.typeOf(getConsole()).equals("undefined") ? null : new ConsoleLogger();
   }
 
   public void log(String level, String message) {
@@ -101,6 +101,8 @@
     public static LogFn groupEnd;
   }
 
-  @JsProperty(namespace = "<window>", name = "window.console")
+  // Using <window> due to https://code.google.com/archive/p/fbug/issues/2914 but probably not
+  // necessary anymore.
+  @JsProperty(namespace = "<window>", name = "console")
   private static native Console getConsole();
 }

user/super/com/google/gwt/emul/javaemul/internal/JsUtils.java

diff --git a/user/super/com/google/gwt/emul/javaemul/internal/JsUtils.java b/user/super/com/google/gwt/emul/javaemul/internal/JsUtils.java
index 14a8e50..03fb8a1 100644
--- a/user/super/com/google/gwt/emul/javaemul/internal/JsUtils.java
+++ b/user/super/com/google/gwt/emul/javaemul/internal/JsUtils.java
@@ -31,6 +31,9 @@
   @JsMethod(namespace = "<window>")
   public static native int parseInt(String s, int radix);
 
+  @JsMethod(namespace = "<window>", name = "typeof")
+  public static native String typeOf(Object obj);
+
   public static native boolean isUndefined(Object value) /*-{
     return value === undefined;
   }-*/;
@@ -63,9 +66,5 @@
       map[key] = value;
     } catch(ignored) { }
   }-*/;
-
-  public static native String typeOf(Object o) /*-{
-    return typeof o;
-  }-*/;
 }