| /* |
| * Copyright 2015 Google Inc. |
| * |
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not |
| * use this file except in compliance with the License. You may obtain a copy of |
| * the License at |
| * |
| * http://www.apache.org/licenses/LICENSE-2.0 |
| * |
| * Unless required by applicable law or agreed to in writing, software |
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT |
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the |
| * License for the specific language governing permissions and limitations under |
| * the License. |
| */ |
| package com.google.gwt.dev.jjs.impl; |
| |
| import com.google.gwt.core.ext.TreeLogger; |
| import com.google.gwt.core.ext.UnableToCompleteException; |
| import com.google.gwt.dev.MinimalRebuildCache; |
| import com.google.gwt.dev.javac.testing.impl.MockJavaResource; |
| import com.google.gwt.dev.jjs.ast.JMethod; |
| import com.google.gwt.dev.jjs.ast.JProgram; |
| import com.google.gwt.dev.util.UnitTestTreeLogger; |
| |
| /** |
| * Tests for the JsInteropRestrictionChecker. |
| */ |
| public class JsInteropRestrictionCheckerTest extends OptimizerTestBase { |
| |
| private UnitTestTreeLogger errorLogger; |
| |
| // TODO: eventually test this for default methods in Java 8. |
| public void testCollidingAccidentalOverrideConcreteMethodFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface Foo {", |
| " void doIt(Foo foo);", |
| "}", |
| "@JsType", |
| "public static interface Bar {", |
| " void doIt(Bar bar);", |
| "}", |
| "public static class ParentBuggy {", |
| " public void doIt(Foo foo) {}", |
| " public void doIt(Bar bar) {}", |
| "}", |
| "public static class Buggy extends ParentBuggy implements Foo, Bar {", |
| "}"); |
| |
| assertCompileFails( |
| "Method 'test.EntryPoint$Buggy.doIt(Ltest/EntryPoint$Bar;)V' can't be exported in type " |
| + "'test.EntryPoint$Buggy' because the member name 'doIt' is already taken."); |
| } |
| |
| public void testCollidingAccidentalOverrideAbstractMethodFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface Foo {", |
| " void doIt(Foo foo);", |
| "}", |
| "@JsType", |
| "public static interface Bar {", |
| " void doIt(Bar bar);", |
| "}", |
| "public static abstract class Baz implements Foo, Bar {", |
| " public abstract void doIt(Foo foo);", |
| " public abstract void doIt(Bar bar);", |
| "}", |
| "public static class Buggy {} // Unrelated class"); |
| |
| assertCompileFails( |
| "Method 'test.EntryPoint$Baz.doIt(Ltest/EntryPoint$Bar;)V' can't be exported in type " |
| + "'test.EntryPoint$Baz' because the member name 'doIt' is already taken."); |
| } |
| |
| public void testCollidingAccidentalOverrideHalfAndHalfFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "public static interface Foo {", |
| " void doIt(Foo foo);", |
| "}", |
| "@JsType", |
| "public static interface Bar {", |
| " void doIt(Bar bar);", |
| "}", |
| "public static class ParentParent {", |
| " public void doIt(Bar x) {}", |
| "}", |
| "@JsType", |
| "public static class Parent extends ParentParent {", |
| " public void doIt(Foo x) {}", |
| "}", |
| "public static class Buggy extends Parent implements Bar {}"); |
| |
| assertCompileFails( |
| "Method 'test.EntryPoint$Parent.doIt(Ltest/EntryPoint$Foo;)V' can't be exported in type " |
| + "'test.EntryPoint$Buggy' because the member name 'doIt' is already taken."); |
| } |
| |
| public void testCollidingFieldExportsFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsExport"); |
| addSnippetClassDecl( |
| "public static class Buggy {", |
| " @JsExport(\"show\")", |
| " public static final int show = 0;", |
| " @JsExport(\"show\")", |
| " public static final int display = 0;", |
| "}"); |
| |
| assertCompileFails("Member 'test.EntryPoint$Buggy.display' can't be exported because the " |
| + "global name 'show' is already taken."); |
| } |
| |
| public void testJsPropertyGetterStyleSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface IBuggy {", |
| " @JsProperty boolean hasX();", |
| " @JsProperty int getX();", |
| " @JsProperty void setX(int x);", |
| "}", |
| "public static class Buggy implements IBuggy {", |
| " public boolean hasX() {return false;}", |
| " public int getX() {return 0;}", |
| " public void setX(int x) {};", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testJsPropertyNonGetterStyleSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface IBuggy {", |
| " @JsProperty boolean hasX();", |
| " @JsProperty int x();", |
| " @JsProperty void x(int x);", |
| "}", |
| "public static class Buggy implements IBuggy {", |
| " public boolean hasX() {return false;}", |
| " public int x() {return 0;}", |
| " public void x(int x) {};", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testJsPropertyFluentStyleSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface IBuggy {", |
| " @JsProperty boolean hasX();", |
| " @JsProperty int x();", |
| " @JsProperty IBuggy x(int x);", |
| "}", |
| "public static class Buggy implements IBuggy {", |
| " public boolean hasX() {return false;}", |
| " public int x() {return 0;}", |
| " public IBuggy x(int x) {return null;};", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testCollidingJsPropertiesTwoGettersFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface IBuggy {", |
| " @JsProperty", |
| " int x();", |
| " @JsProperty", |
| " int getX();", |
| "}", |
| "public static class Buggy implements IBuggy {", |
| " public int x() {return 0;}", |
| " public int getX() {return 0;}", |
| "}"); |
| |
| assertCompileFails("There can't be more than one getter for JsProperty 'x' " |
| + "in type 'test.EntryPoint$IBuggy'.", |
| "There can't be more than one getter for JsProperty 'x' " |
| + "in type 'test.EntryPoint$Buggy'."); |
| } |
| |
| public void testCollidingJsPropertiesTwoSettersFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface IBuggy {", |
| " @JsProperty", |
| " void x(int x);", |
| " @JsProperty", |
| " void setX(int x);", |
| "}", |
| "public static class Buggy implements IBuggy {", |
| " public void x(int x) {}", |
| " public void setX(int x) {}", |
| "}"); |
| |
| assertCompileFails("There can't be more than one setter for JsProperty 'x' in type " |
| + "'test.EntryPoint$IBuggy'.", |
| "There can't be more than one setter for JsProperty 'x' in type " |
| + "'test.EntryPoint$Buggy'."); |
| } |
| |
| // TODO: duplicate this check with two @JsType interfaces. |
| public void testCollidingJsTypeAndJsPropertyGetterFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface IBuggy {", |
| " boolean x(boolean foo);", |
| " @JsProperty", |
| " int getX();", |
| "}", |
| "public static class Buggy implements IBuggy {", |
| " public boolean x(boolean foo) {return false;}", |
| " public int getX() {return 0;}", |
| "}"); |
| |
| assertCompileFails("The JsType member 'test.EntryPoint$IBuggy.x(Z)Z' and JsProperty " |
| + "'test.EntryPoint$IBuggy.getX()I' can't both be named 'x' in " |
| + "type 'test.EntryPoint$IBuggy'.", |
| "The JsType member 'test.EntryPoint$Buggy.x(Z)Z' and JsProperty " |
| + "'test.EntryPoint$Buggy.getX()I' can't both be named 'x' in " |
| + "type 'test.EntryPoint$Buggy'."); |
| } |
| |
| public void testCollidingJsTypeAndJsPropertySetterFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface IBuggy {", |
| " boolean x(boolean foo);", |
| " @JsProperty", |
| " void setX(int a);", |
| "}", |
| "public static class Buggy implements IBuggy {", |
| " public boolean x(boolean foo) {return false;}", |
| " public void setX(int a) {}", |
| "}"); |
| |
| assertCompileFails("The JsType member 'test.EntryPoint$IBuggy.x(Z)Z' and JsProperty " |
| + "'test.EntryPoint$IBuggy.setX(I)V' can't both be named 'x' in " |
| + "type 'test.EntryPoint$IBuggy'.", |
| "The JsType member 'test.EntryPoint$Buggy.x(Z)Z' and JsProperty " |
| + "'test.EntryPoint$Buggy.setX(I)V' can't both be named 'x' in " |
| + "type 'test.EntryPoint$Buggy'."); |
| } |
| |
| public void testCollidingMethodExportsFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsExport"); |
| addSnippetClassDecl( |
| "public static class Buggy {", |
| " @JsExport(\"show\")", |
| " public static void show() {}", |
| " @JsExport(\"show\")", |
| " public static void display() {}", |
| "}"); |
| |
| assertCompileFails("Member 'test.EntryPoint$Buggy.display()V' can't be exported " |
| + "because the global name 'show' is already taken."); |
| } |
| |
| public void testCollidingMethodToFieldExportsFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsExport"); |
| addSnippetClassDecl( |
| "public static class Buggy {", |
| " @JsExport(\"show\")", |
| " public static void show() {}", |
| " @JsExport(\"show\")", |
| " public static final int display = 0;", |
| "}"); |
| |
| assertCompileFails("Member 'test.EntryPoint$Buggy.show()V' can't be exported because the " |
| + "global name 'show' is already taken."); |
| } |
| |
| public void testCollidingMethodToFieldJsTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static class Buggy {", |
| " public void show() {}", |
| " public final int show = 0;", |
| "}"); |
| |
| assertCompileFails("Method 'test.EntryPoint$Buggy.show()V' can't be exported in type " |
| + "'test.EntryPoint$Buggy' because the member name 'show' is already taken."); |
| } |
| |
| public void testCollidingMethodToMethodJsTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static class Buggy {", |
| " public void show(int x) {}", |
| " public void show() {}", |
| "}"); |
| |
| assertCompileFails("Method 'test.EntryPoint$Buggy.show()V' can't be exported in type " |
| + "'test.EntryPoint$Buggy' because the member name 'show' is already taken."); |
| } |
| |
| public void testCollidingSubclassExportedFieldToFieldJsTypeSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static class ParentBuggy {", |
| " public int foo = 55;", |
| "}", |
| "public static class Buggy extends ParentBuggy {", |
| " public int foo = 110;", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testCollidingSubclassExportedFieldToMethodJsTypeSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static class ParentBuggy {", |
| " public int foo = 55;", |
| "}", |
| "public static class Buggy extends ParentBuggy {", |
| " public void foo(int a) {}", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testCollidingSubclassExportedMethodToMethodJsTypeSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static class ParentBuggy {", |
| " public void foo() {}", |
| "}", |
| "public static class Buggy extends ParentBuggy {", |
| " public void foo(int a) {}", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testCollidingSubclassFieldToExportedFieldJsTypeSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "public static class ParentBuggy {", |
| " public int foo = 55;", |
| "}", |
| "@JsType", |
| "public static class Buggy extends ParentBuggy {", |
| " public int foo = 110;", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testCollidingSubclassFieldToExportedMethodJsTypeSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "public static class ParentBuggy {", |
| " public int foo = 55;", |
| "}", |
| "@JsType", |
| "public static class Buggy extends ParentBuggy {", |
| " public void foo(int a) {}", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testCollidingSubclassFieldToFieldJsTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static class ParentBuggy {", |
| " public int foo = 55;", |
| "}", |
| "@JsType", |
| "public static class Buggy extends ParentBuggy {", |
| " public int foo = 110;", |
| "}"); |
| |
| assertCompileFails("Field 'test.EntryPoint$ParentBuggy.foo' can't be exported in type " |
| + "'test.EntryPoint$Buggy' because the member name 'foo' is already taken."); |
| } |
| |
| public void testCollidingSubclassFieldToMethodJsTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static class ParentBuggy {", |
| " public int foo = 55;", |
| "}", |
| "@JsType", |
| "public static class Buggy extends ParentBuggy {", |
| " public void foo(int a) {}", |
| "}"); |
| |
| assertCompileFails("Field 'test.EntryPoint$ParentBuggy.foo' can't be exported in type " |
| + "'test.EntryPoint$Buggy' because the member name 'foo' is already taken."); |
| } |
| |
| public void testCollidingSubclassMethodToExportedMethodJsTypeSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "public static class ParentBuggy {", |
| " public void foo() {}", |
| "}", |
| "@JsType", |
| "public static class Buggy extends ParentBuggy {", |
| " public void foo(int a) {}", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testCollidingSubclassMethodToMethodInterfaceJsTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public interface IBuggy1 {", |
| " void show();", |
| "}", |
| "@JsType", |
| "public interface IBuggy2 {", |
| " void show(boolean b);", |
| "}", |
| "public static class Buggy implements IBuggy1 {", |
| " public void show() {}", |
| "}", |
| "public static class Buggy2 extends Buggy implements IBuggy2 {", |
| " public void show(boolean b) {}", |
| "}"); |
| |
| assertCompileFails("Method 'test.EntryPoint$Buggy.show()V' can't be exported in type " |
| + "'test.EntryPoint$Buggy2' because the member name 'show' is already taken."); |
| } |
| |
| public void testCollidingSubclassMethodToMethodJsTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static class ParentBuggy {", |
| " public void foo() {}", |
| "}", |
| "@JsType", |
| "public static class Buggy extends ParentBuggy {", |
| " public void foo(int a) {}", |
| "}"); |
| |
| assertCompileFails("Method 'test.EntryPoint$ParentBuggy.foo()V' can't be exported in type " |
| + "'test.EntryPoint$Buggy' because the member name 'foo' is already taken."); |
| } |
| |
| public void testCollidingSubclassMethodToMethodTwoLayerInterfaceJsTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public interface IParentBuggy1 {", |
| " void show();", |
| "}", |
| "public interface IBuggy1 extends IParentBuggy1 {", |
| "}", |
| "@JsType", |
| "public interface IParentBuggy2 {", |
| " void show(boolean b);", |
| "}", |
| "public interface IBuggy2 extends IParentBuggy2 {", |
| "}", |
| "public static class Buggy implements IBuggy1 {", |
| " public void show() {}", |
| "}", |
| "public static class Buggy2 extends Buggy implements IBuggy2 {", |
| " public void show(boolean b) {}", |
| "}"); |
| |
| assertCompileFails("Method 'test.EntryPoint$Buggy.show()V' can't be exported in type " |
| + "'test.EntryPoint$Buggy2' because the member name 'show' is already taken."); |
| } |
| |
| public void testCollidingSyntheticBridgeMethodSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "public static interface Comparable<T> {", |
| " int compareTo(T other);", |
| "}", |
| "@JsType", |
| "public static class Enum<E extends Enum<E>> implements Comparable<E> {", |
| " public int compareTo(E other) {return 0;}", |
| "}", |
| "public static class Buggy {}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testCollidingTwoLayerSubclassFieldToFieldJsTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static class ParentParentBuggy {", |
| " public int foo = 55;", |
| "}", |
| "public static class ParentBuggy extends ParentParentBuggy {", |
| " public int foo = 55;", |
| "}", |
| "@JsType", |
| "public static class Buggy extends ParentBuggy {", |
| " public int foo = 110;", |
| "}"); |
| |
| assertCompileFails("Field 'test.EntryPoint$ParentParentBuggy.foo' can't be exported in type " |
| + "'test.EntryPoint$Buggy' because the member name 'foo' is already taken."); |
| } |
| |
| public void testConsistentPropertyTypeSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface IBuggy {", |
| " @JsProperty", |
| " public int getFoo();", |
| " @JsProperty", |
| " public void setFoo(int value);", |
| "}", |
| "public static class Buggy implements IBuggy {", |
| " public int getFoo() {return 0;}", |
| " public void setFoo(int value) {}", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testInconsistentGetSetPropertyTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface IBuggy {", |
| " @JsProperty", |
| " public int getFoo();", |
| " @JsProperty", |
| " public void setFoo(Integer value);", |
| "}", |
| "public static class Buggy implements IBuggy {", |
| " public int getFoo() {return 0;}", |
| " public void setFoo(Integer value) {}", |
| "}"); |
| |
| assertCompileFails( |
| "The setter and getter for JsProperty 'foo' in type 'test.EntryPoint$IBuggy' " |
| + "must have consistent types.", |
| "The setter and getter for JsProperty 'foo' in type 'test.EntryPoint$Buggy' " |
| + "must have consistent types."); |
| } |
| |
| public void testInconsistentIsSetPropertyTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface IBuggy {", |
| " @JsProperty", |
| " public boolean isFoo();", |
| " @JsProperty", |
| " public void setFoo(Object value);", |
| "}", |
| "public static class Buggy implements IBuggy {", |
| " public boolean isFoo() {return false;}", |
| " public void setFoo(Object value) {}", |
| "}"); |
| |
| assertCompileFails( |
| "The setter and getter for JsProperty 'foo' in type 'test.EntryPoint$IBuggy' " |
| + "must have consistent types.", |
| "The setter and getter for JsProperty 'foo' in type 'test.EntryPoint$Buggy' " |
| + "must have consistent types."); |
| } |
| |
| public void testJsPropertyInNonJsTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "public static class Buggy {", |
| " @JsProperty", |
| " public int x() {return 0;}", |
| "}"); |
| |
| assertCompileFails( |
| "Method 'x' can't be a JsProperty since 'test.EntryPoint$Buggy' " + "is not an interface."); |
| } |
| |
| public void testJsPropertyInTransitiveNonJsTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetImport("com.google.gwt.core.client.js.JsProperty"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static interface ParentExported {", |
| "}", |
| "public static interface Exported extends ParentExported {", |
| " @JsProperty", |
| " public int x();", |
| "}", |
| "public static class Buggy {} // Unrelated class"); |
| |
| assertCompileFails("Method 'x' can't be a JsProperty since interface " |
| + "'test.EntryPoint$Exported' is not a JsType."); |
| } |
| |
| public void testJsTypeInterfaceExtendsNonJsTypeFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "public static interface IBuggyParent {}", |
| "@JsType", |
| "public static interface IBuggy extends IBuggyParent {}", |
| "public static class Buggy {} // Unrelated class"); |
| |
| assertCompileSucceeds("JsType interface 'test.EntryPoint$IBuggy' extends non-JsType " |
| + "interface 'test.EntryPoint$IBuggyParent'. This is not recommended."); |
| } |
| |
| public void testMultiplePrivateConstructorsExportSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsExport"); |
| addSnippetClassDecl( |
| "@JsExport", |
| "public static class Buggy {", |
| " private Buggy() {}", |
| " private Buggy(int a) {}", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testMultiplePublicConstructorsExportFails() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsExport"); |
| addSnippetClassDecl( |
| "@JsExport", |
| "public static class Buggy {", |
| " public Buggy() {}", |
| " public Buggy(int a) {}", |
| "}"); |
| |
| assertCompileFails("Member 'test.EntryPoint$Buggy.EntryPoint$Buggy(I) <init>' can't be " |
| + "exported because the global name 'test.EntryPoint.Buggy' is already taken."); |
| } |
| |
| public void testNonCollidingAccidentalOverrideSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "public static interface Foo {", |
| " void doIt(Foo foo);", |
| "}", |
| "@JsType", |
| "public static interface Bar {", |
| " void doIt(Bar bar);", |
| "}", |
| "public static class ParentParent {", |
| " public void doIt(Bar x) {}", |
| "}", |
| "@JsType", |
| "public static class Parent extends ParentParent {", |
| " public void doIt(Foo x) {}", |
| "}", |
| "public static class Buggy extends Parent implements Foo {}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testSingleExportSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsExport"); |
| addSnippetClassDecl( |
| "public static class Buggy {", |
| " @JsExport(\"show\")", |
| " public static void show() {}", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testSingleJsTypeSucceeds() throws Exception { |
| addSnippetImport("com.google.gwt.core.client.js.JsType"); |
| addSnippetClassDecl( |
| "@JsType", |
| "public static class Buggy {", |
| " public void show() {}", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testJsFunctionSingleInterfaceSucceeds() throws Exception { |
| addAll(jsFunctionInterface1); |
| addSnippetClassDecl( |
| "public static class Buggy implements MyJsFunctionInterface1 {", |
| " public int foo(int x) { return 0; }", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testJsFunctionOneJsFunctionAndOneNonJsFunctionSucceeds() throws Exception { |
| addAll(jsFunctionInterface1, plainInterface); |
| addSnippetClassDecl( |
| "public static class Buggy implements MyJsFunctionInterface1, MyPlainInterface {", |
| " public int foo(int x) { return 0; }", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testJsFunctionSameJsFunctionFromSuperClassAndSuperInterfaceSucceeds() |
| throws Exception { |
| addAll(jsFunctionInterface1, plainInterface, jsFunctionInterfaceImpl); |
| addSnippetClassDecl( |
| "public static class Buggy extends MyJsFunctionInterfaceImpl ", |
| "implements MyJsFunctionInterface1, MyPlainInterface {", |
| " public int foo(int x) { return 0; }", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testJsFunctionSameJsFunctionFromSuperInterfaceAndSuperSuperInterfaceSucceeds() |
| throws Exception { |
| addAll(jsFunctionInterface3, jsFunctionSubSubInterface, jsFunctionSubInterface); |
| addSnippetClassDecl( |
| "public static class Buggy implements MyJsFunctionInterface3,", |
| "MyJsFunctionSubSubInterface {", |
| " public int foo(int x) { return 0; }", |
| "}"); |
| |
| assertCompileSucceeds(); |
| } |
| |
| public void testJsFunctionMultipleSuperInterfacesFails() throws Exception { |
| addAll(jsFunctionInterface1, jsFunctionInterface2); |
| addSnippetClassDecl( |
| "public static class Buggy implements MyJsFunctionInterface1, MyJsFunctionInterface2 {", |
| " public int foo(int x) { return 0; }", |
| " public int bar(int x) { return 0; }", |
| "}"); |
| |
| assertCompileFails("'test.EntryPoint$Buggy' implements more than one JsFunction interfaces: " |
| + "[interface MyJsFunctionInterface1 , interface MyJsFunctionInterface2 ]"); |
| } |
| |
| public void testJsFunctionMultipleInterfacesWithSameSignatureFails() throws Exception { |
| addAll(jsFunctionInterface1, jsFunctionInterface3); |
| addSnippetClassDecl( |
| "public static class Buggy implements MyJsFunctionInterface1, MyJsFunctionInterface3 {", |
| " public int foo(int x) { return 0; }", |
| "}"); |
| |
| assertCompileFails("'test.EntryPoint$Buggy' implements more than one JsFunction interfaces: " |
| + "[interface MyJsFunctionInterface1 , interface MyJsFunctionInterface3 ]"); |
| } |
| |
| public void testJsFunctionFromSuperClassAndSuperInterfaceFails() throws Exception { |
| addAll(jsFunctionInterface1, jsFunctionInterface3, jsFunctionInterfaceImpl); |
| addSnippetClassDecl( |
| "public static class Buggy extends MyJsFunctionInterfaceImpl ", |
| "implements MyJsFunctionInterface3 {", |
| " public int foo(int x) { return 0; }", |
| "}"); |
| |
| assertCompileFails("'test.EntryPoint$Buggy' implements more than one JsFunction interfaces: " |
| + "[interface MyJsFunctionInterface1 , interface MyJsFunctionInterface3 ]"); |
| } |
| |
| public void testJsFunctionFromSuperClassAndSuperSuperInterfaceFails() throws Exception { |
| addAll(jsFunctionSubInterface, jsFunctionInterface1, jsFunctionInterfaceImpl, |
| jsFunctionInterface3); |
| addSnippetClassDecl( |
| "public static class Buggy extends MyJsFunctionInterfaceImpl ", |
| "implements MyJsFunctionSubInterface {", |
| " public int foo(int x) { return 0; }", |
| "}"); |
| |
| assertCompileFails("'test.EntryPoint$Buggy' implements more than one JsFunction interfaces: " |
| + "[interface MyJsFunctionInterface1 , interface MyJsFunctionInterface3 ]"); |
| } |
| |
| public void testJsFunctionFromSuperInterfaceAndSuperSuperSuperInterfaceFails() throws Exception { |
| addAll(jsFunctionSubInterface, jsFunctionInterface1, jsFunctionSubSubInterface, |
| jsFunctionInterface3); |
| addSnippetClassDecl( |
| "public static class Buggy implements MyJsFunctionInterface1, ", |
| "MyJsFunctionSubSubInterface {", |
| " public int foo(int x) { return 0; }", |
| "}"); |
| |
| assertCompileFails("'test.EntryPoint$Buggy' implements more than one JsFunction interfaces: " |
| + "[interface MyJsFunctionInterface1 , interface MyJsFunctionInterface3 ]"); |
| } |
| |
| public void testJsFunctionBuggyInterfaceFails() throws Exception { |
| addAll(buggyInterfaceExtendsMultipleInterfaces, jsFunctionInterface1, jsFunctionInterface2); |
| addSnippetClassDecl("public static class Buggy {}"); |
| |
| assertCompileFails("'test.MyBuggyInterface' implements more than one JsFunction interfaces: " |
| + "[interface MyJsFunctionInterface1 , interface MyJsFunctionInterface2 ]"); |
| } |
| |
| public void testJsFunctionJsTypeCollisionFails1() throws Exception { |
| addAll(buggyInterfaceBothJsFunctionAndJsType); |
| addSnippetClassDecl( |
| "public static class Buggy implements MyBuggyInterface2 {", |
| " public int foo(int x) { return x; }", |
| "}"); |
| |
| assertCompileFails( |
| "'test.EntryPoint$Buggy' cannot be annotated as (or extend) both a @JsFunction and a " |
| + "@JsType at the same time.", |
| "'test.MyBuggyInterface2' cannot be annotated as (or extend) both a @JsFunction and a " |
| + "@JsType at the same time."); |
| } |
| |
| public void testJsFunctionJsTypeCollisionFails2() throws Exception { |
| addAll(jsTypeInterface, jsFunctionInterfaceImpl, jsFunctionInterface1); |
| addSnippetClassDecl( |
| "public static class Buggy extends MyJsFunctionInterfaceImpl ", |
| "implements MyJsTypeInterface {}"); |
| |
| assertCompileFails("'test.EntryPoint$Buggy' cannot be annotated as (or extend) both a " |
| + "@JsFunction and a @JsType at the same time."); |
| } |
| |
| // uncomment after isOrExtendsJsType() is fixed. |
| // public void testJsFunctionJsTypeCollisionFails3() throws Exception { |
| // addAll(jsTypeClass, jsFunctionInterface1); |
| // addSnippetClassDecl( |
| // "public static class Buggy extends MyJsTypeClass implements MyJsFunctionInterface1 {\n", |
| // "public int foo(int x) { return 0; }\n", |
| // "}\n"); |
| // assertCompileFails(); |
| // } |
| |
| private static final MockJavaResource jsFunctionInterface1 = new MockJavaResource( |
| "test.MyJsFunctionInterface1") { |
| @Override |
| public CharSequence getContent() { |
| StringBuilder code = new StringBuilder(); |
| code.append("package test;\n"); |
| code.append("import com.google.gwt.core.client.js.JsFunction;\n"); |
| code.append("@JsFunction public interface MyJsFunctionInterface1 {\n"); |
| code.append("int foo(int x);\n"); |
| code.append("}\n"); |
| return code; |
| } |
| }; |
| |
| private static final MockJavaResource jsFunctionInterface2 = new MockJavaResource( |
| "test.MyJsFunctionInterface2") { |
| @Override |
| public CharSequence getContent() { |
| StringBuilder code = new StringBuilder(); |
| code.append("package test;\n"); |
| code.append("import com.google.gwt.core.client.js.JsFunction;\n"); |
| code.append("@JsFunction public interface MyJsFunctionInterface2 {\n"); |
| code.append("int bar(int x);\n"); |
| code.append("}\n"); |
| return code; |
| } |
| }; |
| |
| private static final MockJavaResource jsFunctionInterface3 = new MockJavaResource( |
| "test.MyJsFunctionInterface3") { |
| @Override |
| public CharSequence getContent() { |
| StringBuilder code = new StringBuilder(); |
| code.append("package test;\n"); |
| code.append("import com.google.gwt.core.client.js.JsFunction;\n"); |
| code.append("@JsFunction public interface MyJsFunctionInterface3 {\n"); |
| code.append("int foo(int x);\n"); |
| code.append("}\n"); |
| return code; |
| } |
| }; |
| |
| private static final MockJavaResource plainInterface = new MockJavaResource( |
| "test.MyPlainInterface") { |
| @Override |
| public CharSequence getContent() { |
| StringBuilder code = new StringBuilder(); |
| code.append("package test;\n"); |
| code.append("public interface MyPlainInterface {\n"); |
| code.append("int foo(int x);\n"); |
| code.append("}\n"); |
| return code; |
| } |
| }; |
| |
| private static final MockJavaResource jsFunctionSubInterface = new MockJavaResource( |
| "test.MyJsFunctionSubInterface") { |
| @Override |
| public CharSequence getContent() { |
| StringBuilder code = new StringBuilder(); |
| code.append("package test;\n"); |
| code.append("public interface MyJsFunctionSubInterface extends MyJsFunctionInterface3 {\n"); |
| code.append("}\n"); |
| return code; |
| } |
| }; |
| |
| private static final MockJavaResource jsFunctionSubSubInterface = new MockJavaResource( |
| "test.MyJsFunctionSubSubInterface") { |
| @Override |
| public CharSequence getContent() { |
| StringBuilder code = new StringBuilder(); |
| code.append("package test;\n"); |
| code.append( |
| "public interface MyJsFunctionSubSubInterface extends MyJsFunctionSubInterface {\n"); |
| code.append("}\n"); |
| return code; |
| } |
| }; |
| |
| private static final MockJavaResource jsFunctionInterfaceImpl = new MockJavaResource( |
| "test.MyJsFunctionInterfaceImpl") { |
| @Override |
| public CharSequence getContent() { |
| StringBuilder code = new StringBuilder(); |
| code.append("package test;\n"); |
| code.append("public class MyJsFunctionInterfaceImpl implements MyJsFunctionInterface1 {\n"); |
| code.append("public int foo(int x) { return 1; }\n"); |
| code.append("}\n"); |
| return code; |
| } |
| }; |
| |
| private static final MockJavaResource buggyInterfaceExtendsMultipleInterfaces = |
| new MockJavaResource("test.MyBuggyInterface") { |
| @Override |
| public CharSequence getContent() { |
| StringBuilder code = new StringBuilder(); |
| code.append("package test;\n"); |
| code.append("public interface MyBuggyInterface extends MyJsFunctionInterface1," |
| + "MyJsFunctionInterface2 {\n"); |
| code.append("}\n"); |
| return code; |
| } |
| }; |
| |
| private static final MockJavaResource buggyInterfaceBothJsFunctionAndJsType = |
| new MockJavaResource("test.MyBuggyInterface2") { |
| @Override |
| public CharSequence getContent() { |
| StringBuilder code = new StringBuilder(); |
| code.append("package test;\n"); |
| code.append("import com.google.gwt.core.client.js.JsFunction;\n"); |
| code.append("import com.google.gwt.core.client.js.JsType;\n"); |
| code.append("@JsFunction @JsType public interface MyBuggyInterface2 {\n"); |
| code.append(" int foo(int a);"); |
| code.append("}\n"); |
| return code; |
| } |
| }; |
| |
| private static final MockJavaResource jsTypeInterface = |
| new MockJavaResource("test.MyJsTypeInterface") { |
| @Override |
| public CharSequence getContent() { |
| StringBuilder code = new StringBuilder(); |
| code.append("package test;\n"); |
| code.append("import com.google.gwt.core.client.js.JsType;\n"); |
| code.append("@JsType public interface MyJsTypeInterface {\n"); |
| code.append("}\n"); |
| return code; |
| } |
| }; |
| |
| @Override |
| protected boolean optimizeMethod(JProgram program, JMethod method) { |
| try { |
| JsInteropRestrictionChecker.exec(errorLogger, program, new MinimalRebuildCache()); |
| } catch (UnableToCompleteException e) { |
| throw new RuntimeException(e); |
| } |
| return false; |
| } |
| |
| private void assertCompileFails(String... expectedErrors) { |
| assert expectedErrors != null : "Failed compiles must specify error messages."; |
| UnitTestTreeLogger.Builder builder = new UnitTestTreeLogger.Builder(); |
| builder.setLowestLogLevel(TreeLogger.ERROR); |
| for (String expectedError : expectedErrors) { |
| builder.expectError(expectedError, null); |
| } |
| errorLogger = builder.createLogger(); |
| |
| try { |
| optimize("void", "new Buggy();"); |
| fail("JsInteropRestrictionCheckerTest should have caught the invalid JsInterop constructs."); |
| } catch (Exception e) { |
| assertTrue(e.getCause() instanceof UnableToCompleteException |
| || e instanceof UnableToCompleteException); |
| } |
| errorLogger.assertCorrectLogEntries(); |
| } |
| |
| private void assertCompileSucceeds(String... expectedWarnings) throws UnableToCompleteException { |
| UnitTestTreeLogger.Builder builder = new UnitTestTreeLogger.Builder(); |
| builder.setLowestLogLevel(TreeLogger.WARN); |
| if (expectedWarnings != null) { |
| for (String expectedWarning : expectedWarnings) { |
| builder.expectWarn(expectedWarning, null); |
| } |
| } |
| errorLogger = builder.createLogger(); |
| |
| optimize("void", "new Buggy();"); |
| errorLogger.assertCorrectLogEntries(); |
| } |
| } |
