Patch updates the collection of tests that are ignored on HtmlUnit, to reflect HtmlUnit being updated from 2.5 to a 2.7-snapshot. The occurrence count for the annotation is down from 95 to 64. Patch by: flin Review by: amitmanjhi git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@6472 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java b/user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java index 25071fb..0637d63 100644 --- a/user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java +++ b/user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java
@@ -34,9 +34,7 @@ * number of more detailed tests are in * {@link com.google.gwt.core.client.impl.AsyncFragmentLoaderTest}. * - * This test is flaky on HtmlUnit. */ -@DoNotRunWith(Platform.Htmlunit) public class RunAsyncMetricsIntegrationTest extends GWTTestCase { private static final class LightweightMetricsEvent extends JavaScriptObject { protected LightweightMetricsEvent() { @@ -123,6 +121,7 @@ lwmObserver.uninstall(); } + @DoNotRunWith(Platform.Htmlunit) public void testMetricsSignalled() { if (!GWT.isScript()) { // There are no runAsync lightweight metrics in hosted mode
diff --git a/user/test/com/google/gwt/dom/client/ElementTest.java b/user/test/com/google/gwt/dom/client/ElementTest.java index 2b82b00..283752c 100644 --- a/user/test/com/google/gwt/dom/client/ElementTest.java +++ b/user/test/com/google/gwt/dom/client/ElementTest.java
@@ -556,7 +556,6 @@ /** * style. */ - @DoNotRunWith({Platform.Htmlunit}) public void testStyle() { DivElement div = Document.get().createDivElement(); @@ -570,7 +569,6 @@ /** * Test that styles only allow camelCase. */ - @DoNotRunWith({Platform.Htmlunit}) public void testStyleCamelCase() { DivElement div = Document.get().createDivElement();
diff --git a/user/test/com/google/gwt/dom/client/MapTests.java b/user/test/com/google/gwt/dom/client/MapTests.java index 3a0938a..7708d92 100644 --- a/user/test/com/google/gwt/dom/client/MapTests.java +++ b/user/test/com/google/gwt/dom/client/MapTests.java
@@ -15,8 +15,6 @@ */ package com.google.gwt.dom.client; -import com.google.gwt.junit.DoNotRunWith; -import com.google.gwt.junit.Platform; import com.google.gwt.junit.client.GWTTestCase; /** @@ -32,7 +30,6 @@ /** * getAreas. */ - @DoNotRunWith({Platform.Htmlunit}) public void testGetArea() { Document doc = Document.get(); MapElement map = doc.createMapElement();
diff --git a/user/test/com/google/gwt/dom/client/NodeTest.java b/user/test/com/google/gwt/dom/client/NodeTest.java index dc4de50..8ff6956 100644 --- a/user/test/com/google/gwt/dom/client/NodeTest.java +++ b/user/test/com/google/gwt/dom/client/NodeTest.java
@@ -16,8 +16,6 @@ package com.google.gwt.dom.client; import com.google.gwt.core.client.JavaScriptObject; -import com.google.gwt.junit.DoNotRunWith; -import com.google.gwt.junit.Platform; import com.google.gwt.junit.client.GWTTestCase; /** @@ -155,7 +153,6 @@ /** * isOrHasChild. */ - @DoNotRunWith({Platform.Htmlunit}) public void testIsOrHasChild() { Document doc = Document.get(); DivElement div = doc.createDivElement();
diff --git a/user/test/com/google/gwt/event/dom/client/DomEventTest.java b/user/test/com/google/gwt/event/dom/client/DomEventTest.java index b75b7c7..e7c211c 100644 --- a/user/test/com/google/gwt/event/dom/client/DomEventTest.java +++ b/user/test/com/google/gwt/event/dom/client/DomEventTest.java
@@ -20,8 +20,6 @@ import com.google.gwt.event.shared.HandlerManager; import com.google.gwt.event.shared.HandlerRegistration; import com.google.gwt.event.shared.HandlerTestBase; -import com.google.gwt.junit.DoNotRunWith; -import com.google.gwt.junit.Platform; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.RootPanel; @@ -133,7 +131,6 @@ "onDoubleClick"); } - @DoNotRunWith({Platform.Htmlunit}) public void testMouseEventCoordinates() { Button b = new Button(); RootPanel.get().add(b);
diff --git a/user/test/com/google/gwt/uibinder/sample/client/UiBinderTest.java b/user/test/com/google/gwt/uibinder/sample/client/UiBinderTest.java index 391303e..b5cf8b3 100644 --- a/user/test/com/google/gwt/uibinder/sample/client/UiBinderTest.java +++ b/user/test/com/google/gwt/uibinder/sample/client/UiBinderTest.java
@@ -278,7 +278,6 @@ widgetUi.totallyPrivateStyleSpan.getClassName().length() > 0); } - @DoNotRunWith(Platform.Htmlunit) public void testRadioButton() { RadioButton able = widgetUi.myRadioAble; RadioButton baker = widgetUi.myRadioBaker;
diff --git a/user/test/com/google/gwt/user/client/ui/AnchorTest.java b/user/test/com/google/gwt/user/client/ui/AnchorTest.java index 4a5804f..20bc444 100644 --- a/user/test/com/google/gwt/user/client/ui/AnchorTest.java +++ b/user/test/com/google/gwt/user/client/ui/AnchorTest.java
@@ -19,8 +19,6 @@ import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickHandler; import com.google.gwt.i18n.client.HasDirection; -import com.google.gwt.junit.DoNotRunWith; -import com.google.gwt.junit.Platform; import com.google.gwt.junit.client.GWTTestCase; import com.google.gwt.user.client.DOM; @@ -147,7 +145,6 @@ } } - @DoNotRunWith({Platform.Htmlunit}) public void testEvents() { Anchor anchor = new Anchor("Trigger obscure JavaScript things");
diff --git a/user/test/com/google/gwt/user/client/ui/ButtonTest.java b/user/test/com/google/gwt/user/client/ui/ButtonTest.java index c2b93eb..f570f20 100644 --- a/user/test/com/google/gwt/user/client/ui/ButtonTest.java +++ b/user/test/com/google/gwt/user/client/ui/ButtonTest.java
@@ -18,8 +18,6 @@ import com.google.gwt.dom.client.EventTarget; import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickHandler; -import com.google.gwt.junit.DoNotRunWith; -import com.google.gwt.junit.Platform; import com.google.gwt.junit.client.GWTTestCase; import com.google.gwt.user.client.Timer; import com.google.gwt.user.client.ui.FormPanel.SubmitEvent; @@ -83,7 +81,6 @@ /** * Tests issues 1585 and 3962: a button shouldn't submit a form. */ - @DoNotRunWith(Platform.Htmlunit) public void testPushButton() { FormPanel f = new FormPanel(); f.setAction("javascript:''");
diff --git a/user/test/com/google/gwt/user/client/ui/CheckBoxTest.java b/user/test/com/google/gwt/user/client/ui/CheckBoxTest.java index 5172647..6f4e8e5 100644 --- a/user/test/com/google/gwt/user/client/ui/CheckBoxTest.java +++ b/user/test/com/google/gwt/user/client/ui/CheckBoxTest.java
@@ -23,8 +23,6 @@ import com.google.gwt.event.logical.shared.ValueChangeEvent; import com.google.gwt.event.logical.shared.ValueChangeHandler; import com.google.gwt.event.shared.HandlerManager; -import com.google.gwt.junit.DoNotRunWith; -import com.google.gwt.junit.Platform; import com.google.gwt.junit.client.GWTTestCase; import com.google.gwt.user.client.DOM; import com.google.gwt.user.client.Element; @@ -68,7 +66,6 @@ * Test accessors. */ @SuppressWarnings("deprecation") - @DoNotRunWith({Platform.Htmlunit}) public void testAccessors() { cb.setHTML("test HTML"); assertEquals(cb.getHTML(), "test HTML");
diff --git a/user/test/com/google/gwt/user/client/ui/CreateEventTest.java b/user/test/com/google/gwt/user/client/ui/CreateEventTest.java index c325523..611dc19 100644 --- a/user/test/com/google/gwt/user/client/ui/CreateEventTest.java +++ b/user/test/com/google/gwt/user/client/ui/CreateEventTest.java
@@ -197,7 +197,6 @@ * Tests that {@link Event#getCurrentEvent()} returns the right value for * synthesized events. */ - @DoNotRunWith({Platform.Htmlunit}) public void testGetCurrentEvent() { CurrentEventListener listener = new CurrentEventListener(); Event.setEventListener(child, listener); @@ -217,7 +216,6 @@ /** * Tests NativeEvent.stopPropagation(). */ - @DoNotRunWith({Platform.Htmlunit}) public void testStopPropagation() { NonBubbleAssertingEventListener listener = new NonBubbleAssertingEventListener( "click") { @@ -261,7 +259,6 @@ /** * Tests createChangeEvent(). */ - @DoNotRunWith({Platform.Htmlunit}) public void testTriggerChangeEvent() { BubbleAssertingEventListener listener = new BubbleAssertingEventListener( "change");
diff --git a/user/test/com/google/gwt/user/client/ui/DOMTest.java b/user/test/com/google/gwt/user/client/ui/DOMTest.java index 00c4b6c..b267f4d 100644 --- a/user/test/com/google/gwt/user/client/ui/DOMTest.java +++ b/user/test/com/google/gwt/user/client/ui/DOMTest.java
@@ -120,7 +120,6 @@ * Tests {@link DOM#getAbsoluteLeft(Element)} and * {@link DOM#getAbsoluteTop(Element)}. */ - @DoNotRunWith({Platform.Htmlunit}) public void testGetAbsolutePosition() { final int border = 8; final int margin = 9; @@ -157,7 +156,6 @@ * contains children and has scrollbars. See issue #1093 for more details. * */ - @DoNotRunWith({Platform.Htmlunit}) public void testGetAbsolutePositionWhenScrolled() { final Element outer = DOM.createDiv(); final Element inner = DOM.createDiv(); @@ -192,7 +190,6 @@ * element has a border. * */ - @DoNotRunWith({Platform.Htmlunit}) public void testGetAbsolutePositionWithPixelBorders() { final Element outer = DOM.createDiv(); final Element inner = DOM.createDiv(); @@ -223,7 +220,6 @@ * Tests getAbsoluteLeft/Top() for the document.body element. This used to * cause exceptions to be thrown on Opera (see issue 1556). */ - @DoNotRunWith({Platform.Htmlunit}) public void testGetBodyAbsolutePosition() { try { // The body's absolute left/top depends upon the browser, but we just @@ -271,7 +267,6 @@ * Tests that {@link DOM#isOrHasChild(Element, Element)} works consistently * across browsers. */ - @DoNotRunWith({Platform.Htmlunit}) public void testIsOrHasChild() { Element div = DOM.createDiv(); Element childDiv = DOM.createDiv();
diff --git a/user/test/com/google/gwt/user/client/ui/HistoryTest.java b/user/test/com/google/gwt/user/client/ui/HistoryTest.java index 0d1bd85..fb72aaa 100644 --- a/user/test/com/google/gwt/user/client/ui/HistoryTest.java +++ b/user/test/com/google/gwt/user/client/ui/HistoryTest.java
@@ -95,7 +95,6 @@ * Tests against issue #879: Ensure that empty history tokens do not add * additional characters after the '#' symbol in the URL. */ - @DoNotRunWith(Platform.Htmlunit) public void testEmptyHistoryTokens() { delayTestFinish(5000);
diff --git a/user/test/com/google/gwt/user/client/ui/ImageTest.java b/user/test/com/google/gwt/user/client/ui/ImageTest.java index 798976f..5abe47d 100644 --- a/user/test/com/google/gwt/user/client/ui/ImageTest.java +++ b/user/test/com/google/gwt/user/client/ui/ImageTest.java
@@ -453,13 +453,7 @@ /** * Tests that wrapping an existing DOM element works if you call * setUrlAndVisibleRect() on it. - *<p> - * Disabled it on HtmlUnit because of a HtmlUnit bug. - * - * @see <a - * href="https://sourceforge.net/tracker/?func=detail&aid=2861064&group_id=47038&atid=448266">bug_report</a> */ - @DoNotRunWith({Platform.Htmlunit}) public void testWrapThenSetUrlAndVisibleRect() { String uid = Document.get().createUniqueId(); DivElement div = Document.get().createDivElement();
diff --git a/user/test/com/google/gwt/user/client/ui/SimpleRadioButtonTest.java b/user/test/com/google/gwt/user/client/ui/SimpleRadioButtonTest.java index c94b96a..9910868 100644 --- a/user/test/com/google/gwt/user/client/ui/SimpleRadioButtonTest.java +++ b/user/test/com/google/gwt/user/client/ui/SimpleRadioButtonTest.java
@@ -15,8 +15,6 @@ */ package com.google.gwt.user.client.ui; -import com.google.gwt.junit.DoNotRunWith; -import com.google.gwt.junit.Platform; import com.google.gwt.junit.client.GWTTestCase; /** @@ -29,7 +27,6 @@ return "com.google.gwt.user.UserTest"; } - @DoNotRunWith({Platform.Htmlunit}) public void testProperties() { SimpleRadioButton radio = new SimpleRadioButton("myName"); assertEquals("myName", radio.getName());
diff --git a/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java b/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java index 9f015e0..feb84c1 100644 --- a/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java +++ b/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
@@ -17,8 +17,6 @@ import com.google.gwt.dom.client.Document; import com.google.gwt.dom.client.Element; -import com.google.gwt.junit.DoNotRunWith; -import com.google.gwt.junit.Platform; import com.google.gwt.junit.client.GWTTestCase; import java.util.Arrays; @@ -36,7 +34,6 @@ /** * Test the basic accessors. */ - @DoNotRunWith({Platform.Htmlunit}) public void testAccessors() { SuggestBox box = createSuggestBox(); @@ -56,7 +53,6 @@ assertTrue(box.isSuggestionListShowing()); } - @DoNotRunWith({Platform.Htmlunit}) public void testShowAndHide() { SuggestBox box = createSuggestBox(); assertFalse(box.isSuggestionListShowing()); @@ -85,7 +81,6 @@ assertFalse(box.isSuggestionListShowing()); } - @DoNotRunWith({Platform.Htmlunit}) public void testDefaults() { MultiWordSuggestOracle oracle = new MultiWordSuggestOracle(); oracle.setDefaultSuggestionsFromText(Arrays.asList("A", "B"));
diff --git a/user/test/com/google/gwt/user/client/ui/TreeTest.java b/user/test/com/google/gwt/user/client/ui/TreeTest.java index 07f8261..b581cf9 100644 --- a/user/test/com/google/gwt/user/client/ui/TreeTest.java +++ b/user/test/com/google/gwt/user/client/ui/TreeTest.java
@@ -15,8 +15,6 @@ */ package com.google.gwt.user.client.ui; -import com.google.gwt.junit.DoNotRunWith; -import com.google.gwt.junit.Platform; import com.google.gwt.junit.client.GWTTestCase; import com.google.gwt.user.client.DOM; import com.google.gwt.user.client.Element; @@ -154,7 +152,6 @@ b.setWidget(null); } - @DoNotRunWith({Platform.Htmlunit}) public void testRemove() { Tree t = new Tree(); TreeItem item = t.addItem("a");
diff --git a/user/test/com/google/gwt/xml/client/XMLTest.java b/user/test/com/google/gwt/xml/client/XMLTest.java index dbc842a..81ce61e 100644 --- a/user/test/com/google/gwt/xml/client/XMLTest.java +++ b/user/test/com/google/gwt/xml/client/XMLTest.java
@@ -206,7 +206,6 @@ } } - @DoNotRunWith({Platform.Htmlunit}) public void testDocument() { Document d = createTestDocument(); NodeList e1Nodes = d.getElementsByTagName("e1"); @@ -225,7 +224,6 @@ assertEquals(e1Node.toString(), alienNode11.toString()); } - @DoNotRunWith({Platform.Htmlunit}) public void testElement() { Document d = createTestDocument(); Element top = d.getDocumentElement(); @@ -267,7 +265,6 @@ } } - @DoNotRunWith({Platform.Htmlunit}) public void testNamedNodeMap() { Document d = createTestDocument(); NamedNodeMap m = d.getDocumentElement().getAttributes(); @@ -275,7 +272,6 @@ assertEquals(m.getLength(), 2); } - @DoNotRunWith({Platform.Htmlunit}) public void testNavigation() { Document d = createTestDocument(); Element documentElement = d.getDocumentElement(); @@ -352,7 +348,6 @@ } } - @DoNotRunWith({Platform.Htmlunit}) public void testPrefix() { Document d = XMLParser.parse("<?xml version=\"1.0\"?>\r\n" + "<!-- both namespace prefixes are available throughout -->\r\n" @@ -366,7 +361,6 @@ assertEquals(d.getElementsByTagName("book").item(0), d.getDocumentElement()); } - @DoNotRunWith({Platform.Htmlunit}) public void testProcessingInstruction() { Document d = createTestDocument(); ProcessingInstruction pi = (ProcessingInstruction) d.getChildNodes().item(0); @@ -376,7 +370,6 @@ assertEquals(pi.getData(), "other data"); } - @DoNotRunWith({Platform.Htmlunit}) public void testText() { Document d = createTestDocument(); List<Node> textLikeNodes = Arrays.asList(new Node[] {