Fix warnings and checkstyle errors Review at http://gwt-code-reviews.appspot.com/882802 Review by: amitmanjhi@google.com git-svn-id: https://google-web-toolkit.googlecode.com/svn/trunk@8796 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java index c86d0c8..4e0755f 100644 --- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java +++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java
@@ -161,6 +161,7 @@ // Add a login widget to the page final LoginWidget login = shell.getLoginWidget(); Receiver<UserInformationProxy> receiver = new Receiver<UserInformationProxy>() { + @Override public void onSuccess(UserInformationProxy userInformationRecord, Set<SyncResult> syncResults) { login.setUserInformation(userInformationRecord); }
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobile.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobile.java index e2ae1bc..ff33e51 100644 --- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobile.java +++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobile.java
@@ -103,6 +103,7 @@ requestFactory.employeeRequest().findEmployee(employeeId).fire( new Receiver<EmployeeProxy>() { + @Override public void onSuccess(EmployeeProxy employee, Set<SyncResult> syncResults) { final ExpensesMobileShell shell = new ExpensesMobileShell(eventBus, @@ -115,6 +116,7 @@ // Add a login widget to the page final LoginWidget login = shell.getLoginWidget(); Receiver<UserInformationProxy> receiver = new Receiver<UserInformationProxy>() { + @Override public void onSuccess(UserInformationProxy userInformationRecord, Set<SyncResult> syncResults) { login.setUserInformation(userInformationRecord);
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseDetails.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseDetails.java index 12c4d79..ce3290b 100644 --- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseDetails.java +++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseDetails.java
@@ -79,6 +79,7 @@ initWidget(BINDER.createAndBindUi(this)); } + @Override public Widget asWidget() { return this; } @@ -109,6 +110,7 @@ public void onRefresh(boolean clear) { requestFactory.expenseRequest().findExpense(expense.getId()).fire( new Receiver<List<ExpenseProxy>>() { + @Override public void onSuccess(List<ExpenseProxy> response, Set<SyncResult> syncResults) { assert response.size() == 1; show(response.get(0));
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java index 4b426c1..7ae1bd5 100644 --- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java +++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java
@@ -69,6 +69,7 @@ populateList(dateDay, 1, 31); } + @Override public Widget asWidget() { return this; } @@ -121,6 +122,7 @@ // TODO: wait throbber requestObject.fire(new Receiver<Void>() { + @Override public void onSuccess(Void ignore, Set<SyncResult> response) { // Check for commit errors. String errorMessage = "";
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java index 9d7ad6f..9ca047f 100644 --- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java +++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java
@@ -78,6 +78,7 @@ populateList(dateDay, 1, 31); } + @Override public Widget asWidget() { return this; } @@ -123,6 +124,7 @@ // TODO: wait throbber requestObject.fire(new Receiver<Void>() { + @Override public void onSuccess(Void ignore, Set<SyncResult> response) { // Check for commit errors. String errorMessage = "";
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpenseProxy.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpenseProxy.java index 1ec0142..4c64694 100644 --- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpenseProxy.java +++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpenseProxy.java
@@ -15,9 +15,8 @@ */ package com.google.gwt.sample.expenses.client.request; -import com.google.gwt.requestfactory.shared.ProxyFor; - import com.google.gwt.requestfactory.shared.EntityProxy; +import com.google.gwt.requestfactory.shared.ProxyFor; import java.util.Date;
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeDetailsView.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeDetailsView.java index 9c76f33..f257cf5 100644 --- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeDetailsView.java +++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeDetailsView.java
@@ -64,6 +64,7 @@ initWidget(BINDER.createAndBindUi(this)); } + @Override public Widget asWidget() { return this; }
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeEditView.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeEditView.java index 831c2e1..4c59912 100644 --- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeEditView.java +++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeEditView.java
@@ -84,6 +84,7 @@ DATA_BINDER.init(this); } + @Override public EmployeeEditView asWidget() { return this; }
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportDetailsView.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportDetailsView.java index 0277ce1..fe459f1 100644 --- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportDetailsView.java +++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportDetailsView.java
@@ -67,6 +67,7 @@ initWidget(BINDER.createAndBindUi(this)); } + @Override public Widget asWidget() { return this; }
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportEditView.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportEditView.java index 1916873..dadfa34 100644 --- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportEditView.java +++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportEditView.java
@@ -77,6 +77,7 @@ DATA_BINDER.init(this); } + @Override public ReportEditView asWidget() { return this; }
diff --git a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/ReportGenerator.java b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/ReportGenerator.java index 07c6717..b073a25 100644 --- a/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/ReportGenerator.java +++ b/samples/expenses/src/main/java/com/google/gwt/sample/expenses/server/ReportGenerator.java
@@ -359,7 +359,7 @@ "Met with COMPANY in CITY", "Met w/ COMPANY in CITY", "Met COMPANY in CITY with FULLNAME", "Met with COMPANY in FULLCITY with FIRSTNAME", "COMPANY lunch", - "Conference", "Sales opportunity", "Sales opprtunity with COMPANY", + "Conference", "Sales opportunity", "Sales opportunity with COMPANY", "Maintenance", "Supplies", "Emergency", "Backup", "Research", "CITY breakfast", "CITY lunch", "CITY dinner", "CITY conference", "Conference in CITY", "Conference in FULLCITY", "Meals with FIRSTNAME",
diff --git a/user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java b/user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java index ac37c30..57a65c5 100644 --- a/user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java +++ b/user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java
@@ -117,6 +117,7 @@ requestObject = null; Receiver<Void> receiver = new Receiver<Void>() { + @Override public void onSuccess(Void ignore, Set<SyncResult> response) { // TODO(rjrjr): This can be simplified with RequestFactory.refresh() if (display == null) { @@ -169,6 +170,7 @@ } else { ProxyRequest<P> findRequest = getFindRequest(getRecord().getId()); findRequest.with(getView().getPaths()).fire(new Receiver<P>() { + @Override public void onSuccess(P record, Set<SyncResult> syncResults) { if (AbstractProxyEditActivity.this.display != null) { doStart(AbstractProxyEditActivity.this.display, record);
diff --git a/user/src/com/google/gwt/app/place/AbstractProxyListView.java b/user/src/com/google/gwt/app/place/AbstractProxyListView.java index 365f9d3..2b150d2 100644 --- a/user/src/com/google/gwt/app/place/AbstractProxyListView.java +++ b/user/src/com/google/gwt/app/place/AbstractProxyListView.java
@@ -52,6 +52,7 @@ return table; } + @Override public AbstractProxyListView<P> asWidget() { return this; }
diff --git a/user/src/com/google/gwt/app/place/WithTokenizers.java b/user/src/com/google/gwt/app/place/WithTokenizers.java index 2b4db6c..df64d75 100644 --- a/user/src/com/google/gwt/app/place/WithTokenizers.java +++ b/user/src/com/google/gwt/app/place/WithTokenizers.java
@@ -25,7 +25,7 @@ * {@link PlaceHistoryHandler} generated by * {@link com.google.gwt.app.rebind.PlaceHistoryHandlerGenerator}. */ -@Target( {ElementType.TYPE}) +@Target({ElementType.TYPE}) @Retention(RetentionPolicy.RUNTIME) public @interface WithTokenizers { Class<? extends PlaceTokenizer<?>>[] value();
diff --git a/user/src/com/google/gwt/cell/client/IconCellDecorator.java b/user/src/com/google/gwt/cell/client/IconCellDecorator.java index 83b6484..34af82f 100644 --- a/user/src/com/google/gwt/cell/client/IconCellDecorator.java +++ b/user/src/com/google/gwt/cell/client/IconCellDecorator.java
@@ -163,11 +163,13 @@ String vert = valign == HasVerticalAlignment.ALIGN_MIDDLE ? "center" : valign.getVerticalAlignString(); // Templates are having problems with url('data:image/png;base64,...') + // CHECKSTYLE_OFF return SafeHtmlUtils.fromTrustedString("<div style=\"position:absolute;" + direction + ":0px;top:0px;height:100%;width:" + res.getWidth() + "px;background:url('" + res.getURL() + "') no-repeat scroll " + SafeHtmlUtils.htmlEscape(vert) // for safety + " center transparent;\"></div>"); + // CHECKSTYLE_ON } }
diff --git a/user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java b/user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java index 6f367e4..d34d270 100644 --- a/user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java +++ b/user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java
@@ -46,6 +46,7 @@ * {@link com.google.gwt.editor.client.EditorError#getUserData() * EditorError.getUserData()}. */ + @Override public T getValue() { try { value = peer.getValueOrThrow(); @@ -57,6 +58,7 @@ return value; } + @Override public void setValue(T value) { peer.setValue(this.value = value); }
diff --git a/user/src/com/google/gwt/editor/rebind/model/EditorAccess.java b/user/src/com/google/gwt/editor/rebind/model/EditorAccess.java index 0e039cf..91aca95 100644 --- a/user/src/com/google/gwt/editor/rebind/model/EditorAccess.java +++ b/user/src/com/google/gwt/editor/rebind/model/EditorAccess.java
@@ -112,6 +112,7 @@ /** * For debugging use only. */ + @Override public String toString() { return path + " = " + type.getParameterizedQualifiedSourceName(); }
diff --git a/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java b/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java index 2f964e5..a8c89c6 100644 --- a/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java +++ b/user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java
@@ -34,13 +34,14 @@ public class RequestFactoryLogHandler extends Handler { /** - * Provides a logging request + * Provides a logging request. */ public static interface LoggingRequestProvider { LoggingRequest getLoggingRequest(); } private class LoggingReceiver extends Receiver<Long> { + @Override public void onSuccess(Long response, Set<SyncResult> syncResults) { if (response > 0) { logger.finest("Remote logging successful");
diff --git a/user/src/com/google/gwt/requestfactory/client/impl/ProxyToTypeMap.java b/user/src/com/google/gwt/requestfactory/client/impl/ProxyToTypeMap.java index ee9b668..023c034 100644 --- a/user/src/com/google/gwt/requestfactory/client/impl/ProxyToTypeMap.java +++ b/user/src/com/google/gwt/requestfactory/client/impl/ProxyToTypeMap.java
@@ -15,8 +15,6 @@ */ package com.google.gwt.requestfactory.client.impl; - - /** * <p> * <span style="color:red">Experimental API: This class is still under rapid
diff --git a/user/src/com/google/gwt/requestfactory/shared/RequestEvent.java b/user/src/com/google/gwt/requestfactory/shared/RequestEvent.java index 838b031..b490984 100644 --- a/user/src/com/google/gwt/requestfactory/shared/RequestEvent.java +++ b/user/src/com/google/gwt/requestfactory/shared/RequestEvent.java
@@ -56,7 +56,7 @@ /** * Will only be non-null if this is an event of type {@link State#RECEIVED}, - * and the RPC was successful + * and the RPC was successful. */ private final Response response;
diff --git a/user/src/com/google/gwt/requestfactory/shared/RequestObject.java b/user/src/com/google/gwt/requestfactory/shared/RequestObject.java index 3de4889..7268c6d 100644 --- a/user/src/com/google/gwt/requestfactory/shared/RequestObject.java +++ b/user/src/com/google/gwt/requestfactory/shared/RequestObject.java
@@ -15,7 +15,6 @@ */ package com.google.gwt.requestfactory.shared; - /** * <p> * <span style="color:red">Experimental API: This class is still under rapid
diff --git a/user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java b/user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java index 67c6d76..69e9ff5 100644 --- a/user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java +++ b/user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java
@@ -39,7 +39,7 @@ private String fieldName; /** - * Mapping of child tag to the number of times it has been called + * Mapping of child tag to the number of times it has been called. */ private Map<String, Integer> numCallsToChildMethod = new HashMap<String, Integer>(); private Map<String, Pair<JMethod, Integer>> uiChildMethods; @@ -96,7 +96,7 @@ } /** - * Process a child element that should be added using a {@link UiChild} method + * Process a child element that should be added using a {@link UiChild} method. */ private void handleChild(XMLElement child) throws UnableToCompleteException { String tag = child.getLocalName();
diff --git a/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java b/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java index 1b81e7c..c8a7052 100644 --- a/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java +++ b/user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
@@ -250,7 +250,7 @@ } /** - * Scans the class to find all methods annotated with @UiChild + * Scans the class to find all methods annotated with @UiChild. * * @param ownerType the type of the owner class * @throws UnableToCompleteException
diff --git a/user/src/com/google/gwt/user/client/ui/HTML.java b/user/src/com/google/gwt/user/client/ui/HTML.java index ed9495f..2480d75 100644 --- a/user/src/com/google/gwt/user/client/ui/HTML.java +++ b/user/src/com/google/gwt/user/client/ui/HTML.java
@@ -137,7 +137,6 @@ setTextOrHtml(html, true); } - /** * Sets the label's content to the given HTML, applying the given direction. * See {@link #setText(String, Direction)} for details on potential effects on
diff --git a/user/src/com/google/gwt/user/client/ui/HasOneWidget.java b/user/src/com/google/gwt/user/client/ui/HasOneWidget.java index 1f2a2dd..aa21396 100644 --- a/user/src/com/google/gwt/user/client/ui/HasOneWidget.java +++ b/user/src/com/google/gwt/user/client/ui/HasOneWidget.java
@@ -27,12 +27,12 @@ * * @return the child widget, or <code>null</code> if none is present */ - public Widget getWidget(); + Widget getWidget(); /** * Sets this panel's widget. Any existing child widget will be removed. * * @param w the panel's new widget, or <code>null</code> to clear the panel */ - public void setWidget(Widget w); + void setWidget(Widget w); }
diff --git a/user/src/com/google/gwt/user/client/ui/IsWidget.java b/user/src/com/google/gwt/user/client/ui/IsWidget.java index 08a6192..85331ca 100644 --- a/user/src/com/google/gwt/user/client/ui/IsWidget.java +++ b/user/src/com/google/gwt/user/client/ui/IsWidget.java
@@ -15,7 +15,6 @@ */ package com.google.gwt.user.client.ui; - /** * Extended by view interfaces that are likely to be implemented by Widgets. * Provides access to that widget, if it exists, without compromising the
diff --git a/user/src/com/google/gwt/validation/client/constraints/PastValidatorForDate.java b/user/src/com/google/gwt/validation/client/constraints/PastValidatorForDate.java index b34c307..4a7f0c8 100644 --- a/user/src/com/google/gwt/validation/client/constraints/PastValidatorForDate.java +++ b/user/src/com/google/gwt/validation/client/constraints/PastValidatorForDate.java
@@ -22,7 +22,7 @@ import javax.validation.constraints.Past; /** - * {@link Past} constraint validator implementation for a {@link java.util.Date} + * {@link Past} constraint validator implementation for a {@link java.util.Date}. */ public class PastValidatorForDate implements ConstraintValidator<Past, Date> {
diff --git a/user/src/com/google/gwt/validation/client/impl/AbstractBeanDescriptor.java b/user/src/com/google/gwt/validation/client/impl/AbstractBeanDescriptor.java index 5fdfcf0..9f42398 100644 --- a/user/src/com/google/gwt/validation/client/impl/AbstractBeanDescriptor.java +++ b/user/src/com/google/gwt/validation/client/impl/AbstractBeanDescriptor.java
@@ -15,7 +15,6 @@ */ package com.google.gwt.validation.client.impl; - import java.util.HashMap; import java.util.HashSet; import java.util.Map;
diff --git a/user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java b/user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java index d04fa92..5ef4804 100644 --- a/user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java +++ b/user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java
@@ -33,7 +33,7 @@ ConstraintDescriptor<T> { /** - * Builder for {@link ConstraintDescriptorImpl} + * Builder for {@link ConstraintDescriptorImpl}. * * @param <T> the constraint annotation to describe. */ @@ -47,7 +47,7 @@ private boolean reportAsSingleViolation; public ConstraintDescriptorImpl<T> build() { - return new ConstraintDescriptorImpl<T>( // + return new ConstraintDescriptorImpl<T>( annotation, // groups, // payload, //
diff --git a/user/src/com/google/gwt/validation/client/impl/GwtSpecificValidator.java b/user/src/com/google/gwt/validation/client/impl/GwtSpecificValidator.java index 83b74d4..2391c8f 100644 --- a/user/src/com/google/gwt/validation/client/impl/GwtSpecificValidator.java +++ b/user/src/com/google/gwt/validation/client/impl/GwtSpecificValidator.java
@@ -15,7 +15,6 @@ */ package com.google.gwt.validation.client.impl; - import java.util.Set; import javax.validation.ConstraintViolation; @@ -87,8 +86,8 @@ /** * Validates all constraints placed on the property named - * <code>propertyName</code> of the class <code>beanType</code> would the - * property value be <code>value</code> + * <code>propertyName</code> of the class <code>beanType</code> where the + * property value is <code>value</code>. * <p/> * <code>ConstraintViolation</code> objects return null for * {@link ConstraintViolation#getRootBean()} and
diff --git a/user/src/com/google/gwt/validation/client/impl/NodeImpl.java b/user/src/com/google/gwt/validation/client/impl/NodeImpl.java index 9b26564..0482ee0 100644 --- a/user/src/com/google/gwt/validation/client/impl/NodeImpl.java +++ b/user/src/com/google/gwt/validation/client/impl/NodeImpl.java
@@ -20,7 +20,7 @@ import javax.validation.Path.Node; /** - * An immutable GWT safe implementation of {@link Node} + * An immutable GWT safe implementation of {@link Node}. */ class NodeImpl implements Node, Serializable {
diff --git a/user/src/com/google/gwt/validation/rebind/AbstractCreator.java b/user/src/com/google/gwt/validation/rebind/AbstractCreator.java index 5a165ac..24c1111 100644 --- a/user/src/com/google/gwt/validation/rebind/AbstractCreator.java +++ b/user/src/com/google/gwt/validation/rebind/AbstractCreator.java
@@ -52,7 +52,7 @@ writeClassBody(sourceWriter); sourceWriter.commit(logger); } - return getQaulifiedName(); + return getQualifiedName(); } protected abstract void compose(ClassSourceFileComposerFactory composerFactory); @@ -65,16 +65,16 @@ protected abstract void writeClassBody(SourceWriter sourceWriter); - private final String getQaulifiedName() { + private String getQualifiedName() { String packageName = getPackage(); return (packageName == "" ? "" : packageName + ".") + getSimpleName(); } - private final String getSimpleName() { + private String getSimpleName() { return validatorType.getSimpleSourceName() + "Impl"; } - private final SourceWriter getSourceWriter(TreeLogger logger, + private SourceWriter getSourceWriter(TreeLogger logger, GeneratorContext ctx) { String packageName = getPackage(); String simpleName = getSimpleName();
diff --git a/user/test/com/google/gwt/app/place/ActivityManagerTest.java b/user/test/com/google/gwt/app/place/ActivityManagerTest.java index df32e1e..369442d 100644 --- a/user/test/com/google/gwt/app/place/ActivityManagerTest.java +++ b/user/test/com/google/gwt/app/place/ActivityManagerTest.java
@@ -26,7 +26,6 @@ import junit.framework.TestCase; - /** * Eponymous unit test. */
diff --git a/user/test/com/google/gwt/app/place/PlaceHistoryHandlerGeneratorTest.java b/user/test/com/google/gwt/app/place/PlaceHistoryHandlerGeneratorTest.java index 906c3bd..16bd4b9 100644 --- a/user/test/com/google/gwt/app/place/PlaceHistoryHandlerGeneratorTest.java +++ b/user/test/com/google/gwt/app/place/PlaceHistoryHandlerGeneratorTest.java
@@ -81,6 +81,7 @@ doTest(subject, factory); } + // CHECKSTYLE_OFF private void doTest(AbstractPlaceHistoryHandler<?> subject, TokenizerFactory factory) { String history1 = subject.getPrefixAndToken(place1).toString(); @@ -91,14 +92,20 @@ assertEquals(TokenizerFactory.PLACE2_PREFIX + ":" + place2.content, history2); } else { + // CHECKSTYLE_OFF assertEquals("Place2:" + place2.content, history2); + // CHECKSTYLE_ON } String history3 = subject.getPrefixAndToken(place3).toString(); + // CHECKSTYLE_OFF assertEquals("Place3:" + place3.content, history3); + // CHECKSTYLE_ON String history4 = subject.getPrefixAndToken(place4).toString(); + // CHECKSTYLE_OFF assertEquals("Place4:" + place4.content, history4); + // CHECKSTYLE_ON if (factory != null) { assertEquals(factory.tokenizer,
diff --git a/user/test/com/google/gwt/validation/client/SimpleSample.java b/user/test/com/google/gwt/validation/client/SimpleSample.java index d549186..86083d8 100644 --- a/user/test/com/google/gwt/validation/client/SimpleSample.java +++ b/user/test/com/google/gwt/validation/client/SimpleSample.java
@@ -18,7 +18,7 @@ import javax.validation.constraints.NotNull; /** - * A simple sample class to test javax.validation + * A simple sample class to test javax.validation. */ public class SimpleSample { @NotNull
diff --git a/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumberTest.java b/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumberTest.java index 45edfbf..c91bb52 100644 --- a/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumberTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForNumberTest.java
@@ -18,7 +18,7 @@ import javax.validation.constraints.DecimalMax; /** - * Tests for {@link DecimalMaxValidatorForNumber} + * Tests for {@link DecimalMaxValidatorForNumber}. */ public class DecimalMaxValidatorForNumberTest extends ConstraintValidatorTestCase<DecimalMax, Number> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForStringTest.java b/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForStringTest.java index 85a8151..cc73112 100644 --- a/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForStringTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/DecimalMaxValidatorForStringTest.java
@@ -18,7 +18,7 @@ import javax.validation.constraints.DecimalMax; /** - * Tests for {@link DecimalMaxValidatorForString} + * Tests for {@link DecimalMaxValidatorForString}. */ public class DecimalMaxValidatorForStringTest extends ConstraintValidatorTestCase<DecimalMax, String> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForNumberTest.java b/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForNumberTest.java index 03ed79c..8b72c9f 100644 --- a/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForNumberTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForNumberTest.java
@@ -18,7 +18,7 @@ import javax.validation.constraints.DecimalMin; /** - * Tests for {@link DecimalMinValidatorForNumber} + * Tests for {@link DecimalMinValidatorForNumber}. */ public class DecimalMinValidatorForNumberTest extends ConstraintValidatorTestCase<DecimalMin, Number> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForStringTest.java b/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForStringTest.java index 089c5f0..1fa77bd 100644 --- a/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForStringTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/DecimalMinValidatorForStringTest.java
@@ -18,7 +18,7 @@ import javax.validation.constraints.DecimalMin; /** - * Tests for {@link DecimalMinValidatorForString} + * Tests for {@link DecimalMinValidatorForString}. */ public class DecimalMinValidatorForStringTest extends ConstraintValidatorTestCase<DecimalMin, String> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForNumberTest.java b/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForNumberTest.java index 9c0cdbb..8131a06 100644 --- a/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForNumberTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForNumberTest.java
@@ -20,7 +20,7 @@ import javax.validation.constraints.Digits; /** - * Tests for {@link DigitsValidatorForNumber} + * Tests for {@link DigitsValidatorForNumber}. */ public class DigitsValidatorForNumberTest extends ConstraintValidatorTestCase<Digits, Number> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForStringTest.java b/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForStringTest.java index e3d30fc..9b60d6d 100644 --- a/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForStringTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/DigitsValidatorForStringTest.java
@@ -18,7 +18,7 @@ import javax.validation.constraints.Digits; /** - * Tests for {@link DigitsValidatorForString} + * Tests for {@link DigitsValidatorForString}. */ public class DigitsValidatorForStringTest extends ConstraintValidatorTestCase<Digits, String> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/FutureValidatorForDateTest.java b/user/test/com/google/gwt/validation/client/constraints/FutureValidatorForDateTest.java index 4ed5ebd..bc3a609 100644 --- a/user/test/com/google/gwt/validation/client/constraints/FutureValidatorForDateTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/FutureValidatorForDateTest.java
@@ -20,12 +20,11 @@ import javax.validation.constraints.Future; /** - * Tests for {@link FutureValidatorForDate} + * Tests for {@link FutureValidatorForDate}. */ public class FutureValidatorForDateTest extends ConstraintValidatorTestCase<Future, Date> { - @SuppressWarnings("unused") @Future private Date defaultField;
diff --git a/user/test/com/google/gwt/validation/client/constraints/GwtCompileTest.java b/user/test/com/google/gwt/validation/client/constraints/GwtCompileTest.java index 0443a79..b031395 100644 --- a/user/test/com/google/gwt/validation/client/constraints/GwtCompileTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/GwtCompileTest.java
@@ -67,6 +67,4 @@ assertEquals(29, temp.size()); } - - }
diff --git a/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForNumberTest.java b/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForNumberTest.java index 6b177dc..f18b5df 100644 --- a/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForNumberTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForNumberTest.java
@@ -18,7 +18,7 @@ import javax.validation.constraints.Max; /** - * Tests for {@link MaxValidatorForNumber} + * Tests for {@link MaxValidatorForNumber}. */ public class MaxValidatorForNumberTest extends ConstraintValidatorTestCase<Max, Number> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForStringTest.java b/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForStringTest.java index 959fe90..b5cb1b7 100644 --- a/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForStringTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/MaxValidatorForStringTest.java
@@ -18,7 +18,7 @@ import javax.validation.constraints.Max; /** - * Tests for {@link MinValidatorForString} + * Tests for {@link MinValidatorForString}. */ public class MaxValidatorForStringTest extends ConstraintValidatorTestCase<Max, String> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/MinValidatorForNumberTest.java b/user/test/com/google/gwt/validation/client/constraints/MinValidatorForNumberTest.java index 522528e..bbb8a44 100644 --- a/user/test/com/google/gwt/validation/client/constraints/MinValidatorForNumberTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/MinValidatorForNumberTest.java
@@ -18,7 +18,7 @@ import javax.validation.constraints.Min; /** - * Tests for {@link MinValidatorForNumber} + * Tests for {@link MinValidatorForNumber}. */ public class MinValidatorForNumberTest extends ConstraintValidatorTestCase<Min, Number> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/MinValidatorForStringTest.java b/user/test/com/google/gwt/validation/client/constraints/MinValidatorForStringTest.java index 475de21..5c1d526 100644 --- a/user/test/com/google/gwt/validation/client/constraints/MinValidatorForStringTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/MinValidatorForStringTest.java
@@ -18,7 +18,7 @@ import javax.validation.constraints.Max; /** - * Tests for {@link MinValidatorForString} + * Tests for {@link MinValidatorForString}. */ public class MinValidatorForStringTest extends ConstraintValidatorTestCase<Max, String> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/NotNullValidatorTest.java b/user/test/com/google/gwt/validation/client/constraints/NotNullValidatorTest.java index c423d17..bf4dc31 100644 --- a/user/test/com/google/gwt/validation/client/constraints/NotNullValidatorTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/NotNullValidatorTest.java
@@ -19,7 +19,7 @@ import javax.validation.constraints.NotNull; /** - * Tests for {@link NotNullValidator} + * Tests for {@link NotNullValidator}. */ public class NotNullValidatorTest extends ConstraintValidatorTestCase<NotNull, Object> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/PastValidatorForDateTest.java b/user/test/com/google/gwt/validation/client/constraints/PastValidatorForDateTest.java index 7223da7..7c3d37a 100644 --- a/user/test/com/google/gwt/validation/client/constraints/PastValidatorForDateTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/PastValidatorForDateTest.java
@@ -20,12 +20,11 @@ import javax.validation.constraints.Past; /** - * Tests for {@link PastValidatorForDate} + * Tests for {@link PastValidatorForDate}. */ public class PastValidatorForDateTest extends ConstraintValidatorTestCase<Past, Date> { - @SuppressWarnings("unused") @Past private Date defaultField;
diff --git a/user/test/com/google/gwt/validation/client/constraints/PatternValidatorTest.java b/user/test/com/google/gwt/validation/client/constraints/PatternValidatorTest.java index f8032e7..60f3fea 100644 --- a/user/test/com/google/gwt/validation/client/constraints/PatternValidatorTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/PatternValidatorTest.java
@@ -20,12 +20,11 @@ import javax.validation.constraints.Pattern; /** - * Tests for {@link PastValidatorForDate} + * Tests for {@link PastValidatorForDate}. */ public class PatternValidatorTest extends ConstraintValidatorTestCase<Pattern, String> { - @SuppressWarnings("unused") @Pattern(regexp = "good") private Date defaultField;
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfBooleanTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfBooleanTest.java index d2e6805..3c70fbd 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfBooleanTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfBooleanTest.java
@@ -20,7 +20,7 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForArrayOfBoolean} + * Tests for {@link SizeValidatorForArrayOfBoolean}. */ public class SizeValidatorForArrayOfBooleanTest extends ConstraintValidatorTestCase<Size, boolean[]> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfByteTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfByteTest.java index ee10768..4efd56f 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfByteTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfByteTest.java
@@ -20,7 +20,7 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForArrayOfByte} + * Tests for {@link SizeValidatorForArrayOfByte}. */ public class SizeValidatorForArrayOfByteTest extends ConstraintValidatorTestCase<Size, byte[]> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfCharTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfCharTest.java index 38650f6..c831e8f 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfCharTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfCharTest.java
@@ -20,7 +20,7 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForArrayOfChar} + * Tests for {@link SizeValidatorForArrayOfChar}. */ public class SizeValidatorForArrayOfCharTest extends ConstraintValidatorTestCase<Size, char[]> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfDoubleTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfDoubleTest.java index c803913..7be25ae 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfDoubleTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfDoubleTest.java
@@ -20,7 +20,7 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForArrayOfDouble} + * Tests for {@link SizeValidatorForArrayOfDouble}. */ public class SizeValidatorForArrayOfDoubleTest extends ConstraintValidatorTestCase<Size, double[]> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfFloatTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfFloatTest.java index 09d5c7f..f265b45 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfFloatTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfFloatTest.java
@@ -20,7 +20,7 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForArrayOfFloat} + * Tests for {@link SizeValidatorForArrayOfFloat}. */ public class SizeValidatorForArrayOfFloatTest extends ConstraintValidatorTestCase<Size, float[]> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfIntTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfIntTest.java index 773d44b..0e37693 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfIntTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfIntTest.java
@@ -20,7 +20,7 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForArrayOfInt} + * Tests for {@link SizeValidatorForArrayOfInt}. */ public class SizeValidatorForArrayOfIntTest extends ConstraintValidatorTestCase<Size, int[]> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfLongTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfLongTest.java index 4581c8f..c8b3b41 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfLongTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfLongTest.java
@@ -20,7 +20,7 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForArrayOfLong} + * Tests for {@link SizeValidatorForArrayOfLong}. */ public class SizeValidatorForArrayOfLongTest extends ConstraintValidatorTestCase<Size, long[]> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfObjectTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfObjectTest.java index b62f599..34da630 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfObjectTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfObjectTest.java
@@ -20,7 +20,7 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForArrayOfObject} + * Tests for {@link SizeValidatorForArrayOfObject}. */ public class SizeValidatorForArrayOfObjectTest extends ConstraintValidatorTestCase<Size, Object[]> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfShortTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfShortTest.java index 18cf983..bfab23f 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfShortTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForArrayOfShortTest.java
@@ -20,7 +20,7 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForArrayOfShort} + * Tests for {@link SizeValidatorForArrayOfShort}. */ public class SizeValidatorForArrayOfShortTest extends ConstraintValidatorTestCase<Size, short[]> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForCollectionTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForCollectionTest.java index f8ea8ea..6a44d53 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForCollectionTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForCollectionTest.java
@@ -23,12 +23,11 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForCollection} + * Tests for {@link SizeValidatorForCollection}. */ public class SizeValidatorForCollectionTest extends ConstraintValidatorTestCase<Size, Collection<?>> { - @SuppressWarnings("unused") @Size(min = 2, max = 5) private Date defaultField;
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForMapTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForMapTest.java index 84c63cf..67eb163 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForMapTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForMapTest.java
@@ -22,7 +22,7 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForMap} + * Tests for {@link SizeValidatorForMap}. */ public class SizeValidatorForMapTest extends ConstraintValidatorTestCase<Size, Map<?, ?>> {
diff --git a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForStringTest.java b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForStringTest.java index 5687313..26c0198 100644 --- a/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForStringTest.java +++ b/user/test/com/google/gwt/validation/client/constraints/SizeValidatorForStringTest.java
@@ -20,7 +20,7 @@ import javax.validation.constraints.Size; /** - * Tests for {@link SizeValidatorForString} + * Tests for {@link SizeValidatorForString}. */ public class SizeValidatorForStringTest extends ConstraintValidatorTestCase<Size, String> {
diff --git a/user/test/com/google/gwt/validation/example/client/Author.java b/user/test/com/google/gwt/validation/example/client/Author.java index c74827b..eadf824 100644 --- a/user/test/com/google/gwt/validation/example/client/Author.java +++ b/user/test/com/google/gwt/validation/example/client/Author.java
@@ -18,7 +18,7 @@ import javax.validation.constraints.Size; /** - * From the jsr spec + * From the jsr spec. */ public class Author {
diff --git a/user/test/com/google/gwt/validation/example/client/FirstLevelCheck.java b/user/test/com/google/gwt/validation/example/client/FirstLevelCheck.java index 320912d..e560fee 100644 --- a/user/test/com/google/gwt/validation/example/client/FirstLevelCheck.java +++ b/user/test/com/google/gwt/validation/example/client/FirstLevelCheck.java
@@ -16,7 +16,7 @@ package com.google.gwt.validation.example.client; /** - * A example group for validation + * A example group for validation. */ public interface FirstLevelCheck {