Removed TabPanel#onBeforeSelection and TabPanel#onSelection for the API. We do not want to provide hooks for events when we already provide Event Handlers for them. Patch by: jlabanca Review by: ecc Issue: 3235 git-svn-id: https://google-web-toolkit.googlecode.com/svn/releases/1.6@4393 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/user/src/com/google/gwt/user/client/ui/TabListener.java b/user/src/com/google/gwt/user/client/ui/TabListener.java index 478fac3..71f80ac 100644 --- a/user/src/com/google/gwt/user/client/ui/TabListener.java +++ b/user/src/com/google/gwt/user/client/ui/TabListener.java
@@ -33,6 +33,9 @@ * @param tabIndex the index of the tab about to be selected * @return <code>false</code> to disallow the selection. If any listener * returns false, then the selection will be disallowed. + * @deprecated use + * {@link TabPanel#addBeforeSelectionHandler(com.google.gwt.event.logical.shared.BeforeSelectionHandler)} + * instead */ @Deprecated boolean onBeforeTabSelected(SourcesTabEvents sender, int tabIndex); @@ -42,6 +45,9 @@ * * @param sender the {@link TabBar} or {@link TabPanel} whose tab was selected * @param tabIndex the index of the tab that was selected + * @deprecated use + * {@link TabPanel#addSelectionHandler(com.google.gwt.event.logical.shared.SelectionHandler)} + * instead */ @Deprecated void onTabSelected(SourcesTabEvents sender, int tabIndex);
diff --git a/user/src/com/google/gwt/user/client/ui/TabPanel.java b/user/src/com/google/gwt/user/client/ui/TabPanel.java index 2203703..2a3bf67 100644 --- a/user/src/com/google/gwt/user/client/ui/TabPanel.java +++ b/user/src/com/google/gwt/user/client/ui/TabPanel.java
@@ -354,22 +354,12 @@ return deck.iterator(); } - public void onBeforeSelection(BeforeSelectionEvent<Integer> event) { - if (!onBeforeTabSelected(tabBar, event.getItem().intValue())) { - event.cancel(); - } - } - @Deprecated public boolean onBeforeTabSelected(SourcesTabEvents sender, int tabIndex) { BeforeSelectionEvent<Integer> event = BeforeSelectionEvent.fire(this, tabIndex); return event == null || !event.isCanceled(); } - public void onSelection(SelectionEvent<Integer> event) { - onTabSelected(tabBar, event.getSelectedItem().intValue()); - } - @Deprecated public void onTabSelected(SourcesTabEvents sender, int tabIndex) { deck.showWidget(tabIndex);