commit b64263eb79d093ef2b5c73dab73e27b89ed24338
author Roberto Lublinerman <rluble@google.com> Tue Aug 16 07:22:06 2016 -0700
committer Roberto Lublinerman <rluble@google.com> Tue Aug 16 07:37:26 2016 -0700
tree e445c6bc3a17d5e633928a81e3e2c7261b807613
parent dadac462feeaa674e43ce7be17264503ffbcc644

Fix typo in DeadCodeElimination.

This patch fixes a missed optimization opportunity due to a typo.

Change-Id: Ia315515f37c5a31a0eec2c5a61ba3c17c3daaa6e

dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java

diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java b/dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java
index 9ee0239..e6cc1ef 100644
--- a/dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java
+++ b/dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java
@@ -1027,7 +1027,7 @@
         case LTE:
         case GT:
         case GTE: {
-          if (isTypeFloatingPoint(lhs) ||  isTypeFloatingPoint(lhs)) {
+          if (isTypeFloatingPoint(lhs) || isTypeFloatingPoint(rhs)) {
             // operate on doubles
             double left = toDouble(lhs);
             double right = toDouble(rhs);

dev/core/test/com/google/gwt/dev/jjs/impl/DeadCodeEliminationTest.java

diff --git a/dev/core/test/com/google/gwt/dev/jjs/impl/DeadCodeEliminationTest.java b/dev/core/test/com/google/gwt/dev/jjs/impl/DeadCodeEliminationTest.java
index ceb6635..a7003ea 100644
--- a/dev/core/test/com/google/gwt/dev/jjs/impl/DeadCodeEliminationTest.java
+++ b/dev/core/test/com/google/gwt/dev/jjs/impl/DeadCodeEliminationTest.java
@@ -383,6 +383,8 @@
     // is printed as a double with the right precision.
     optimize("float", "return 1.1f;").intoString("return " + String.format("%.16g", (double) 1.1f) +
         ";");
+    optimize("boolean", "return 2d > 1;").intoString("return true;");
+    optimize("boolean", "return 1 < 2d;").intoString("return true;");
   }
 
   public void testMultiExpression_RedundantClinitRemoval() throws Exception {