Adds updated @deprecated comments to change listeners to reflect that both change handler and value change handler are valid upgrade paths. Reviewed by:fabbott git-svn-id: https://google-web-toolkit.googlecode.com/svn/releases/1.6@4424 8db76d5a-ed1c-0410-87a9-c151d255dfc7
diff --git a/user/src/com/google/gwt/user/client/ui/ChangeListener.java b/user/src/com/google/gwt/user/client/ui/ChangeListener.java index cf75a46..c93a7e1 100644 --- a/user/src/com/google/gwt/user/client/ui/ChangeListener.java +++ b/user/src/com/google/gwt/user/client/ui/ChangeListener.java
@@ -20,7 +20,10 @@ /** * Event listener interface for 'change' events. * - * @deprecated use {@link com.google.gwt.event.dom.client.ChangeHandler} instead + * @deprecated we have now separated dom and logical change events. Use {@link com.google.gwt.event.dom.client.ChangeHandler} if the + * change listener was triggered by a dom change event or + * {@link com.google.gwt.event.logical.shared.ValueChangeHandler} if + * it was based on a logical event */ @Deprecated public interface ChangeListener extends EventListener { @@ -30,6 +33,12 @@ * sending the event. * * @param sender the widget that has changed + * + * @deprecated use + * {@link com.google.gwt.event.dom.client.ChangeHandler#onChange(com.google.gwt.event.dom.client.ChangeEvent)} + * if the change listener was triggered by a dom change event or + * {@link com.google.gwt.event.logical.shared.ValueChangeHandler#onValueChange(com.google.gwt.event.logical.shared.ValueChangeEvent)} + * if it was based on a logical event */ @Deprecated void onChange(Widget sender);
diff --git a/user/src/com/google/gwt/user/client/ui/ChangeListenerCollection.java b/user/src/com/google/gwt/user/client/ui/ChangeListenerCollection.java index ea4ca5a..c0504e2 100644 --- a/user/src/com/google/gwt/user/client/ui/ChangeListenerCollection.java +++ b/user/src/com/google/gwt/user/client/ui/ChangeListenerCollection.java
@@ -23,7 +23,10 @@ * type {@link com.google.gwt.user.client.ui.ChangeListener}. * * @deprecated use <code>addDomHandler(myHandler, ChangeEvent.getType())</code> - * instead to manage handlers for your widget + * for dom based change events and use + * <code>addHandler(myHandler, ValueChangeEvent.getType())</code> + * for logical change events instead to manage handlers for your + * widget */ @Deprecated public class ChangeListenerCollection extends ArrayList<ChangeListener> {
diff --git a/user/src/com/google/gwt/user/client/ui/SourcesChangeEvents.java b/user/src/com/google/gwt/user/client/ui/SourcesChangeEvents.java index 268f3ad..1987220 100644 --- a/user/src/com/google/gwt/user/client/ui/SourcesChangeEvents.java +++ b/user/src/com/google/gwt/user/client/ui/SourcesChangeEvents.java
@@ -19,8 +19,13 @@ * A widget that implements this interface sources the events defined by the * {@link com.google.gwt.user.client.ui.ChangeListener} interface. * - * @deprecated use {@link com.google.gwt.event.dom.client.HasChangeHandlers} - * instead + * @deprecated we have now separated dom and logical change events. Use + * {@link com.google.gwt.event.dom.client.HasChangeHandlers} if the + * change listener was triggered by a dom change event or + * {@link com.google.gwt.event.logical.shared.HasValueChangeHandlers} + * if it was based on a logical event + * + * */ @Deprecated public interface SourcesChangeEvents { @@ -29,7 +34,8 @@ * Adds a listener interface to receive change events. * * @param listener the listener interface to add - * @deprecated use <code>addChangeHandler</code> instead + * @deprecated use <code>addChangeHandler</code> or + * <code>addValueChangeHandler</code> instead */ @Deprecated void addChangeListener(ChangeListener listener);