commit fa1a1bf057bd4d28dfb8c1590a9a59df396604d3
author Andrei Korzhevskii <a.korzhevskiy@gmail.com> Tue Apr 19 13:51:40 2016 +0300
committer Andrei Korzhevskii <a.korzhevskiy@gmail.com> Wed Apr 20 09:08:40 2016 +0000
tree 34591819b74f4529415c9ec7fcfaf5914e1fa317
parent dc2e7f60bc0d3b6a16d069b797381490f15243b9

Handle NaN and -0.0 in Math.signum

Change-Id: I0aae67a00fb99ac61c17aa80e595cd689e5d18d8

user/super/com/google/gwt/emul/java/lang/Math.java

diff --git a/user/super/com/google/gwt/emul/java/lang/Math.java b/user/super/com/google/gwt/emul/java/lang/Math.java
index cb01dc1..82463fa 100644
--- a/user/super/com/google/gwt/emul/java/lang/Math.java
+++ b/user/super/com/google/gwt/emul/java/lang/Math.java
@@ -324,12 +324,10 @@
   }
 
   public static double signum(double d) {
-    if (d > 0.0d) {
-      return 1.0d;
-    } else if (d < 0.0d) {
-      return -1.0d;
+    if (d == 0. || Double.isNaN(d)) {
+      return d;
     } else {
-      return 0.0d;
+      return d < 0 ? -1 : 1;
     }
   }
 

user/test/com/google/gwt/emultest/java/lang/MathTest.java

diff --git a/user/test/com/google/gwt/emultest/java/lang/MathTest.java b/user/test/com/google/gwt/emultest/java/lang/MathTest.java
index 7f63a27..c47d4ff 100644
--- a/user/test/com/google/gwt/emultest/java/lang/MathTest.java
+++ b/user/test/com/google/gwt/emultest/java/lang/MathTest.java
@@ -475,6 +475,18 @@
     }
   }
 
+  public void testSignum() {
+    assertTrue(Double.isNaN(Math.signum(Double.NaN)));
+    assertTrue(isNegativeZero(Math.signum(-0.)));
+    assertEquals(0., Math.signum(0.), 0);
+    assertEquals(-1, Math.signum(-2), 0);
+    assertEquals(1, Math.signum(2), 0);
+    assertEquals(-1., Math.signum(-Double.MAX_VALUE), 0);
+    assertEquals(1., Math.signum(Double.MAX_VALUE), 0);
+    assertEquals(-1., Math.signum(Double.NEGATIVE_INFINITY), 0);
+    assertEquals(1., Math.signum(Double.POSITIVE_INFINITY), 0);
+  }
+
   public void testSin() {
     double v = Math.sin(0.0);
     assertEquals(0.0, v, 1e-7);